MIME-Version: 1.0
References: 
 <CAHg+QDd4mVPTT1P1E8o1k+2UzHkp55595v2GWpm9dENRwJCuYQ@mail.gmail.com>
 <48F28858-660B-4A70-90D2-C4FF45D9E341@gmail.com>
In-Reply-To: <48F28858-660B-4A70-90D2-C4FF45D9E341@gmail.com>
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Wed, 22 Apr 2026 23:48:28 -0700
Message-ID: 
 <CAHg+QDcrQHBhGJa9Uc4Q2+Q_uH5=V4QN_twWovrs1PUvFTZdwQ@mail.gmail.com>
Subject: Re: Add null check on get_tablespace_name() return in
 pg_get_database_ddl_internal
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000fd954306501b097e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDcrQHBhGJa9Uc4Q2%2BQ_uH5%3DV4QN_twWovrs1PUvFTZdwQ%40mail.gmail.com>
Precedence: bulk

--000000000000fd954306501b097e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Chao,

On Wed, Apr 22, 2026 at 5:03=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:

>
>
> > On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM <
> satyanarlapuram@gmail.com> wrote:
> >
> > Hi Hackers,
> >
> > A concurrent tablespace drop could lead to null deref in
> pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch =
to
> fix this to keep the code clean.
> >
> > Thanks,
> > Satya
> >
> <0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop=
.patch>
>
> This is a dup of my recent patch, see [1].
>
> [1]
> https://www.postgresql.org/message-id/573E45C1-31A4-4885-A00C-1A2171159A2=
A%40gmail.com


Thanks, I replied there.

--000000000000fd954306501b097e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Chao,</div><br><div class=3D"gmail_quo=
te gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Apr=
 22, 2026 at 5:03=E2=80=AFPM Chao Li &lt;<a href=3D"mailto:li.evan.chao@gma=
il.com">li.evan.chao@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex"><br>
<br>
&gt; On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM &lt;<a href=3D"mai=
lto:satyanarlapuram@gmail.com" target=3D"_blank">satyanarlapuram@gmail.com<=
/a>&gt; wrote:<br>
&gt; <br>
&gt; Hi Hackers,<br>
&gt; <br>
&gt; A concurrent tablespace drop could lead to null deref in pg_get_databa=
se_ddl. I acknowledge this is a corner case. Adding a patch to fix this to =
keep the code clean.<br>
&gt; <br>
&gt; Thanks,<br>
&gt; Satya<br>
&gt; &lt;0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespac=
e-drop.patch&gt;<br>
<br>
This is a dup of my recent patch, see [1].<br>
<br>
[1] <a href=3D"https://www.postgresql.org/message-id/573E45C1-31A4-4885-A00=
C-1A2171159A2A%40gmail.com" rel=3D"noreferrer" target=3D"_blank">https://ww=
w.postgresql.org/message-id/573E45C1-31A4-4885-A00C-1A2171159A2A%40gmail.co=
m</a></blockquote><div><br></div><div>Thanks, I replied=C2=A0there.</div><d=
iv>=C2=A0</div></div></div>

--000000000000fd954306501b097e--