MIME-Version: 1.0
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Sat, 25 Apr 2026 12:52:44 -0700
Message-ID: 
 <CAHg+QDcyKNWyzDoKMxiZNjv7C-wAxs8y0ZoNkOV137Y+nk3UXg@mail.gmail.com>
Subject: [PATCH] Resolve unknown-type literals in GRAPH_TABLE COLUMNS
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000004f4fb606504e3a56"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDcyKNWyzDoKMxiZNjv7C-wAxs8y0ZoNkOV137Y%2Bnk3UXg%40mail.gmail.com>
Precedence: bulk

--0000000000004f4fb606504e3a56
Content-Type: multipart/alternative; boundary="0000000000004f4fb506504e3a54"

--0000000000004f4fb506504e3a54
Content-Type: text/plain; charset="UTF-8"

Hi hackers,

transformRangeGraphTable() calls transformExpr() and
assign_list_collations() for COLUMNS expressions but missed calling
resolveTargetListUnknowns(). As a result, literals such as 'val1'
in a COLUMNS clause retained type "unknown", causing failures with
ORDER BY, UNION, and output conversions.

Fix by calling resolveTargetListUnknowns() on the columns target
list right after assign_list_collations(), similar to SELECT target lists
in
transformSelectStmt().

Attached a patch to fix this, which also includes test cases to reproduce.


Thanks,
Satya

--0000000000004f4fb506504e3a54
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi hackers,<div><br></div><div>transformRangeGraphTable() =
calls transformExpr() and<br>assign_list_collations() for COLUMNS expressio=
ns but missed calling<br>resolveTargetListUnknowns(). As a result, literals=
 such as &#39;val1&#39; <br>in a COLUMNS clause retained type &quot;unknown=
&quot;, causing failures with <br>ORDER BY, UNION, and output conversions.<=
br><br>Fix by calling resolveTargetListUnknowns() on the columns target<br>=
list right after assign_list_collations(), similar to SELECT target lists i=
n=C2=A0</div><div>transformSelectStmt().</div><div><br></div><div>Attached =
a patch to fix this, which also includes test cases to reproduce.</div><div=
><br></div><div><br></div><div>Thanks,</div><div>Satya</div><div><br></div>=
<div><br></div></div>

--0000000000004f4fb506504e3a54--

--0000000000004f4fb606504e3a56
Content-Type: application/octet-stream;
	name="0001-Resolve-unknown-type-literals-in-GRAPH_TABLE-COLUMNS.patch"
Content-Disposition: attachment;
	filename="0001-Resolve-unknown-type-literals-in-GRAPH_TABLE-COLUMNS.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_moeraknj0>
X-Attachment-Id: f_moeraknj0

RnJvbSBlZmEwMDA5MDUzNDNmNmMyNTEyZjM2M2MwMDEzYzE5ZmJhZDViOGE1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYXR5YSBOYXJsYXB1cmFtIDxzYXR5YW5hcmxhcHVyYW1AZ21h
aWwuY29tPgpEYXRlOiBTYXQsIDI1IEFwciAyMDI2IDE3OjMwOjQzICswMDAwClN1YmplY3Q6IFtQ
QVRDSF0gUmVzb2x2ZSB1bmtub3duLXR5cGUgbGl0ZXJhbHMgaW4gR1JBUEhfVEFCTEUgQ09MVU1O
UwogZXhwcmVzc2lvbnMKCnRyYW5zZm9ybVJhbmdlR3JhcGhUYWJsZSgpIGNhbGxzIHRyYW5zZm9y
bUV4cHIoKSBhbmQKYXNzaWduX2xpc3RfY29sbGF0aW9ucygpIGZvciBDT0xVTU5TIGV4cHJlc3Np
b25zIGJ1dCBtaXNzZWQgY2FsbGluZwpyZXNvbHZlVGFyZ2V0TGlzdFVua25vd25zKCkuIEFzIGEg
cmVzdWx0LCBsaXRlcmFscyBzdWNoIGFzICdjb2wxJyAKaW4gYSBDT0xVTU5TIGNsYXVzZSByZXRh
aW5lZCB0eXBlICJ1bmtub3duIiwgY2F1c2luZyBmYWlsdXJlcyB3aXRoIApPUkRFUiBCWSwgVU5J
T04sIGFuZCBvdXRwdXQgY29udmVyc2lvbnMuCgpGaXggYnkgY2FsbGluZyByZXNvbHZlVGFyZ2V0
TGlzdFVua25vd25zKCkgb24gdGhlIGNvbHVtbnMgdGFyZ2V0Cmxpc3QgcmlnaHQgYWZ0ZXIgYXNz
aWduX2xpc3RfY29sbGF0aW9ucygpLCBzaW1pbGFyIHRvIFNFTEVDVCB0YXJnZXQgCmxpc3RzIGlu
IHRyYW5zZm9ybVNlbGVjdFN0bXQoKS4KLS0tCiBzcmMvYmFja2VuZC9wYXJzZXIvcGFyc2VfY2xh
dXNlLmMgICAgICAgICB8ICAzICsrCiBzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3Rh
YmxlLm91dCB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrCiBzcmMvdGVzdC9yZWdyZXNzL3Nx
bC9ncmFwaF90YWJsZS5zcWwgICAgICB8IDIxICsrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA3
OCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX2Ns
YXVzZS5jIGIvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX2NsYXVzZS5jCmluZGV4IGYzNzM2OTc5
Li43Nzk4MTg1MCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX2NsYXVzZS5j
CisrKyBiL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYwpAQCAtMTAxMCw2ICsxMDEw
LDkgQEAgdHJhbnNmb3JtUmFuZ2VHcmFwaFRhYmxlKFBhcnNlU3RhdGUgKnBzdGF0ZSwgUmFuZ2VH
cmFwaFRhYmxlICpyZ3QpCiAJICovCiAJYXNzaWduX2xpc3RfY29sbGF0aW9ucyhwc3RhdGUsIGNv
bHVtbnMpOwogCisJLyogUmVzb2x2ZSB1bmtub3duLXR5cGUgbGl0ZXJhbHMgdG8gdGV4dCAqLwor
CXJlc29sdmVUYXJnZXRMaXN0VW5rbm93bnMocHN0YXRlLCBjb2x1bW5zKTsKKwogCXRhYmxlX2Ns
b3NlKHJlbCwgTm9Mb2NrKTsKIAogCXBzdGF0ZS0+cF9ncmFwaF90YWJsZV9wc3RhdGUgPSBOVUxM
OwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ncmFwaF90YWJsZS5vdXQg
Yi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3RhYmxlLm91dAppbmRleCBkM2MyMDYx
MC4uMjEyZmEyOWYgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZ3JhcGhf
dGFibGUub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZ3JhcGhfdGFibGUub3V0
CkBAIC0xMTEwLDQgKzExMTAsNTggQEAgU0VMRUNUICogRlJPTSBHUkFQSF9UQUJMRSAoZzEgTUFU
Q0ggKGEgSVMgdmwxKSBDT0xVTU5TICh1cHBlcihhLnZuYW1lKSBBUyBuKSkgT1IKICBWMTMKICgz
IHJvd3MpCiAKKy0tIFN0cmluZyBhbmQgTlVMTCBsaXRlcmFscyBpbiBDT0xVTU5TIG11c3QgcmVz
b2x2ZSB0byBwcm9wZXIgdHlwZXMKKy0tIChub3QgcmVtYWluIGFzICJ1bmtub3duIikKK1NFTEVD
VCBwZ190eXBlb2YoYzEpLCBjMQorICBGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoYSBJUyB2
bDEpCisgICAgQ09MVU1OUyAoYS52bmFtZSBBUyBuLCAndmFsMScgQVMgYzEpKSBPUkRFUiBCWSBu
OworIHBnX3R5cGVvZiB8ICBjMSAgCistLS0tLS0tLS0tLSstLS0tLS0KKyB0ZXh0ICAgICAgfCB2
YWwxCisgdGV4dCAgICAgIHwgdmFsMQorIHRleHQgICAgICB8IHZhbDEKKygzIHJvd3MpCisKKy0t
IE9SREVSIEJZIG9uIGEgbGl0ZXJhbCBjb2x1bW4KK1NFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUg
KGcxIE1BVENIIChhIElTIHZsMSkKKyAgICBDT0xVTU5TIChhLnZuYW1lIEFTIG4sICd2YWwxJyBB
UyBjMSkpIE9SREVSIEJZIGMxLCBuOworICBuICB8ICBjMSAgCistLS0tLSstLS0tLS0KKyB2MTEg
fCB2YWwxCisgdjEyIHwgdmFsMQorIHYxMyB8IHZhbDEKKygzIHJvd3MpCisKKy0tIFVOSU9OIGJl
dHdlZW4gR1JBUEhfVEFCTEUgbGl0ZXJhbCBjb2x1bW4gYW5kIHBsYWluIHRleHQKK1NFTEVDVCAq
IEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChhIElTIHZsMSkKKyAgICBDT0xVTU5TIChhLnZu
YW1lIEFTIG4sICd2YWwxJyBBUyBjMSkpCisgIFVOSU9OIEFMTCBTRUxFQ1QgJ3ZhbDInLCAndmFs
Myc7CisgIG4gICB8ICBjMSAgCistLS0tLS0rLS0tLS0tCisgdjExICB8IHZhbDEKKyB2MTIgIHwg
dmFsMQorIHYxMyAgfCB2YWwxCisgdmFsMiB8IHZhbDMKKyg0IHJvd3MpCisKKy0tIE5VTEwgbGl0
ZXJhbCBtdXN0IG5vdCBjYXVzZSBmYWlsdXJlcworU0VMRUNUIG4sIHBnX3R5cGVvZihjMSkKKyAg
RlJPTSBHUkFQSF9UQUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKQorICAgIENPTFVNTlMgKGEudm5h
bWUgQVMgbiwgTlVMTCBBUyBjMSkpIE9SREVSIEJZIG47CisgIG4gIHwgcGdfdHlwZW9mIAorLS0t
LS0rLS0tLS0tLS0tLS0KKyB2MTEgfCB0ZXh0CisgdjEyIHwgdGV4dAorIHYxMyB8IHRleHQKKygz
IHJvd3MpCisKKy0tIGludGVnZXIgbGl0ZXJhbCB0eXBlIGlzIHByZXNlcnZlZAorU0VMRUNUIHBn
X3R5cGVvZihjMSkKKyAgRlJPTSBHUkFQSF9UQUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKQorICAg
IENPTFVNTlMgKDQyIEFTIGMxKSkgTElNSVQgMTsKKyBwZ190eXBlb2YgCistLS0tLS0tLS0tLQor
IGludGVnZXIKKygxIHJvdykKKwogLS0gbGVhdmUgdGhlIG9iamVjdHMgYmVoaW5kIGZvciBwZ191
cGdyYWRlL3BnX2R1bXAgdGVzdHMKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dy
YXBoX3RhYmxlLnNxbCBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbAppbmRl
eCAyNTIxYzRjYS4uM2Q3NGFiNGMgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dy
YXBoX3RhYmxlLnNxbAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9ncmFwaF90YWJsZS5zcWwK
QEAgLTYzNCw0ICs2MzQsMjUgQEAgU0VMRUNUIHNyYy52bmFtZSwgY291bnQoKikKIFNFTEVDVCAq
IEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChhIElTIHZsMSkgQ09MVU1OUyAoYS52bmFtZSB8
fCAnIScgQVMgbikpIE9SREVSIEJZIG47CiBTRUxFQ1QgKiBGUk9NIEdSQVBIX1RBQkxFIChnMSBN
QVRDSCAoYSBJUyB2bDEpIENPTFVNTlMgKHVwcGVyKGEudm5hbWUpIEFTIG4pKSBPUkRFUiBCWSBu
OwogCistLSBTdHJpbmcgYW5kIE5VTEwgbGl0ZXJhbHMgaW4gQ09MVU1OUyBtdXN0IHJlc29sdmUg
dG8gcHJvcGVyIHR5cGVzCistLSAobm90IHJlbWFpbiBhcyAidW5rbm93biIpCitTRUxFQ1QgcGdf
dHlwZW9mKGMxKSwgYzEKKyAgRlJPTSBHUkFQSF9UQUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKQor
ICAgIENPTFVNTlMgKGEudm5hbWUgQVMgbiwgJ3ZhbDEnIEFTIGMxKSkgT1JERVIgQlkgbjsKKy0t
IE9SREVSIEJZIG9uIGEgbGl0ZXJhbCBjb2x1bW4KK1NFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUg
KGcxIE1BVENIIChhIElTIHZsMSkKKyAgICBDT0xVTU5TIChhLnZuYW1lIEFTIG4sICd2YWwxJyBB
UyBjMSkpIE9SREVSIEJZIGMxLCBuOworLS0gVU5JT04gYmV0d2VlbiBHUkFQSF9UQUJMRSBsaXRl
cmFsIGNvbHVtbiBhbmQgcGxhaW4gdGV4dAorU0VMRUNUICogRlJPTSBHUkFQSF9UQUJMRSAoZzEg
TUFUQ0ggKGEgSVMgdmwxKQorICAgIENPTFVNTlMgKGEudm5hbWUgQVMgbiwgJ3ZhbDEnIEFTIGMx
KSkKKyAgVU5JT04gQUxMIFNFTEVDVCAndmFsMicsICd2YWwzJzsKKy0tIE5VTEwgbGl0ZXJhbCBt
dXN0IG5vdCBjYXVzZSBmYWlsdXJlcworU0VMRUNUIG4sIHBnX3R5cGVvZihjMSkKKyAgRlJPTSBH
UkFQSF9UQUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKQorICAgIENPTFVNTlMgKGEudm5hbWUgQVMg
biwgTlVMTCBBUyBjMSkpIE9SREVSIEJZIG47CistLSBpbnRlZ2VyIGxpdGVyYWwgdHlwZSBpcyBw
cmVzZXJ2ZWQKK1NFTEVDVCBwZ190eXBlb2YoYzEpCisgIEZST00gR1JBUEhfVEFCTEUgKGcxIE1B
VENIIChhIElTIHZsMSkKKyAgICBDT0xVTU5TICg0MiBBUyBjMSkpIExJTUlUIDE7CisKIC0tIGxl
YXZlIHRoZSBvYmplY3RzIGJlaGluZCBmb3IgcGdfdXBncmFkZS9wZ19kdW1wIHRlc3RzCi0tIAoy
LjQzLjAKCg==
--0000000000004f4fb606504e3a56--