MIME-Version: 1.0
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Wed, 22 Apr 2026 15:20:36 -0700
Message-ID: 
 <CAHg+QDd4mVPTT1P1E8o1k+2UzHkp55595v2GWpm9dENRwJCuYQ@mail.gmail.com>
Subject: Add null check on get_tablespace_name() return in
 pg_get_database_ddl_internal
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000098af99065013f114"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDd4mVPTT1P1E8o1k%2B2UzHkp55595v2GWpm9dENRwJCuYQ%40mail.gmail.com>
Precedence: bulk

--00000000000098af99065013f114
Content-Type: multipart/alternative; boundary="00000000000098af98065013f112"

--00000000000098af98065013f112
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

A concurrent tablespace drop could lead to null deref in
pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to
fix this to keep the code clean.

Thanks,
Satya

--00000000000098af98065013f112
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Hackers,<div><br></div><div>A concurrent tablespace dro=
p could lead to null deref in pg_get_database_ddl. I acknowledge=C2=A0this =
is a corner case. Adding a patch to fix this to keep the code clean.</div><=
div><br></div><div>Thanks,</div><div>Satya</div></div>

--00000000000098af98065013f112--

--00000000000098af99065013f114
Content-Type: application/octet-stream;
	name="0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patch"
Content-Disposition: attachment;
	filename="0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_moam8v480>
X-Attachment-Id: f_moam8v480

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9kZGx1dGlscy5jIGIvc3JjL2JhY2tl
bmQvdXRpbHMvYWR0L2RkbHV0aWxzLmMKaW5kZXggZDgzY2RhMzMuLmNjNzUxMWU4IDEwMDY0NAot
LS0gYS9zcmMvYmFja2VuZC91dGlscy9hZHQvZGRsdXRpbHMuYworKysgYi9zcmMvYmFja2VuZC91
dGlscy9hZHQvZGRsdXRpbHMuYwpAQCAtOTg2LDcgKzk4Niw4IEBAIHBnX2dldF9kYXRhYmFzZV9k
ZGxfaW50ZXJuYWwoT2lkIGRiaWQsIGJvb2wgcHJldHR5LAogCXsKIAkJY2hhcgkgICAqc3BjbmFt
ZSA9IGdldF90YWJsZXNwYWNlX25hbWUoZGJmb3JtLT5kYXR0YWJsZXNwYWNlKTsKIAotCQlpZiAo
cGdfc3RyY2FzZWNtcChzcGNuYW1lLCAicGdfZGVmYXVsdCIpICE9IDApCisJCWlmIChzcGNuYW1l
ICE9IE5VTEwgJiYKKwkJCXBnX3N0cmNhc2VjbXAoc3BjbmFtZSwgInBnX2RlZmF1bHQiKSAhPSAw
KQogCQkJYXBwZW5kX2RkbF9vcHRpb24oJmJ1ZiwgcHJldHR5LCA0LCAiVEFCTEVTUEFDRSA9ICVz
IiwKIAkJCQkJCQkgIHF1b3RlX2lkZW50aWZpZXIoc3BjbmFtZSkpOwogCX0K
--00000000000098af99065013f114--