MIME-Version: 1.0
References: 
 <CAHg+QDc_TwzSgb=B_QgNLt3mvZdmRK23rLb+RkanSQkDF40GjA@mail.gmail.com>
 <CAEZATCUyKUrL_4pDZ=pqL68BcWznoyuCqGS3-7sm-Lc_UxS9HQ@mail.gmail.com>
 <CAHg+QDe3e-KOseG0SfumkX=Suu06YFZhchnv4c-7V_uWzDdmHA@mail.gmail.com>
 <CAEZATCUr0hTb0v_Tz1b-j7=tU=TWHT=EqY9ms9qjFOukVFzKPg@mail.gmail.com>
In-Reply-To: 
 <CAEZATCUr0hTb0v_Tz1b-j7=tU=TWHT=EqY9ms9qjFOukVFzKPg@mail.gmail.com>
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Mon, 20 Apr 2026 01:03:18 -0700
Message-ID: 
 <CAHg+QDdEVUvAB96FjCWgLoOhUWLqe+p4x2JaXyyhb=iBUFMhtw@mail.gmail.com>
Subject: Re: [BUG]: WHERE CURRENT OF cursor fail on tables that have virtual
 generated columns
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000078c63064fdfbc91"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDdEVUvAB96FjCWgLoOhUWLqe%2Bp4x2JaXyyhb%3DiBUFMhtw%40mail.gmail.com>
Precedence: bulk

--000000000000078c63064fdfbc91
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

On Mon, Apr 20, 2026 at 12:56=E2=80=AFAM Dean Rasheed <dean.a.rasheed@gmail=
.com>
wrote:

> On Mon, 20 Apr 2026 at 01:33, SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> >
> > On Sun, Apr 19, 2026 at 3:42=E2=80=AFAM Dean Rasheed <dean.a.rasheed@gm=
ail.com>
> wrote:
> >>
> >> Hmm, it seems to me that a much simpler fix is to check for use of
> >> WHERE CURRENT OF on a view at parse time, and throw the error there.
> >
> > This patch looks simple and neat, is there any reason why it was done
> differently earlier?
> >
>
> I'm not sure, but possibly because it used to be possible to turn a
> table into a view by defining a SELECT rule on it, which could have
> rendered a parse-time check insufficient. That's no longer the case
> though, and we now have similar parse-time relkind tests elsewhere
> (e.g., for MERGE).
>
> > Updated the patch to include a test case to reject view update with
> WHERE CURRENT OF.
> >
>
> That's already tested in portals.sql, which seems like a better place
> for that test, since it's not related to virtual generated columns. I
> don't think another test is necessary -- admittedly portals.sql only
> tests DELETE, but the UPDATE code is the same, so I think the existing
> test is sufficient. We don't obsessively try to achieve 100% coverage
> in our tests.
>

Sounds good. Thanks for letting me know.

--000000000000078c63064fdfbc91
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi</div><div><br><div class=3D"gmail_quote gmail_quote_co=
ntainer"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 20, 2026 at 12:5=
6=E2=80=AFAM Dean Rasheed &lt;<a href=3D"mailto:dean.a.rasheed@gmail.com">d=
ean.a.rasheed@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex">On Mon, 20 Apr 2026 at 01:33, SATYANARAYANA NARLAPUR=
AM<br>
&lt;<a href=3D"mailto:satyanarlapuram@gmail.com" target=3D"_blank">satyanar=
lapuram@gmail.com</a>&gt; wrote:<br>
&gt;<br>
&gt; On Sun, Apr 19, 2026 at 3:42=E2=80=AFAM Dean Rasheed &lt;<a href=3D"ma=
ilto:dean.a.rasheed@gmail.com" target=3D"_blank">dean.a.rasheed@gmail.com</=
a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; Hmm, it seems to me that a much simpler fix is to check for use of=
<br>
&gt;&gt; WHERE CURRENT OF on a view at parse time, and throw the error ther=
e.<br>
&gt;<br>
&gt; This patch looks simple and neat, is there any reason why it was done =
differently earlier?<br>
&gt;<br>
<br>
I&#39;m not sure, but possibly because it used to be possible to turn a<br>
table into a view by defining a SELECT rule on it, which could have<br>
rendered a parse-time check insufficient. That&#39;s no longer the case<br>
though, and we now have similar parse-time relkind tests elsewhere<br>
(e.g., for MERGE).<br>
<br>
&gt; Updated the patch to include a test case to reject view update with WH=
ERE CURRENT OF.<br>
&gt;<br>
<br>
That&#39;s already tested in portals.sql, which seems like a better place<b=
r>
for that test, since it&#39;s not related to virtual generated columns. I<b=
r>
don&#39;t think another test is necessary -- admittedly portals.sql only<br=
>
tests DELETE, but the UPDATE code is the same, so I think the existing<br>
test is sufficient. We don&#39;t obsessively try to achieve 100% coverage<b=
r>
in our tests.<br>
</blockquote><div dir=3D"auto"><br></div><div dir=3D"auto">Sounds good. Tha=
nks for letting me know.</div></div></div>

--000000000000078c63064fdfbc91--