MIME-Version: 1.0
References: 
 <CAHg+QDexGTmCZzx=73gXkY2ZADS6LRhpnU+-8Y_QmrdTS6yUhA@mail.gmail.com>
 <CAMbWs4-SJ6B26ciFu_K_2M1ObDA=GirV87N1BKeAtSRmQGATUA@mail.gmail.com>
 <22B4A33A-99F3-46F5-BE0C-426A9E1D9ABA@gmail.com>
 <CAHg+QDf1Y=dZR8i+q3nnjEt2qeJpDG_pvrWtozXTrdu3J8H-FQ@mail.gmail.com>
 <CAMbWs4-_nPuNSKeaEnU81MQK8fKq5Lr5W0dYhzcL4DW61KLNHQ@mail.gmail.com>
In-Reply-To: 
 <CAMbWs4-_nPuNSKeaEnU81MQK8fKq5Lr5W0dYhzcL4DW61KLNHQ@mail.gmail.com>
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Mon, 13 Apr 2026 01:42:49 -0700
Message-ID: 
 <CAHg+QDda7fkd_z6ZXuhRVtVyRf2J=BCP9nRrHqL2_0=HWQnzSA@mail.gmail.com>
Subject: Re: Bug: Rule actions see wrong values for generated columns (NEW.gen
 reads OLD value)
To: Richard Guo <guofenglinux@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Peter Eisentraut <peter@eisentraut.org>
Content-Type: multipart/alternative; boundary="0000000000006ca68c064f537890"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDda7fkd_z6ZXuhRVtVyRf2J%3DBCP9nRrHqL2_0%3DHWQnzSA%40mail.gmail.com>
Precedence: bulk

--0000000000006ca68c064f537890
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Richard,

On Mon, Apr 13, 2026 at 1:30=E2=80=AFAM Richard Guo <guofenglinux@gmail.com=
> wrote:

> On Mon, Apr 13, 2026 at 4:27=E2=80=AFPM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> > On Mon, Apr 13, 2026 at 12:21=E2=80=AFAM Chao Li <li.evan.chao@gmail.co=
m> wrote:
> >> Do either of you plan to propose a patch for this? If so, please go
> ahead and I can review it. Otherwise, I can propose a patch in a couple o=
f
> days.
>
> > I have a patch with me, let me post it shortly.
>
> Please feel free to share your patches.  I've been looking into this
> as well, but I'd be happy to see independent takes on it.
>

I reviewed your patch, it looks good. I ran the tests you added and a few
additional tests and they are passing. Please continue with your patch.
Maybe a test like "WHERE NEW.b > threshold" to confirm the expansion
happens before qual evaluation would be good.

Thanks,
Satya

--0000000000006ca68c064f537890
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Richard,</div><br><div class=3D"gmail_=
quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, =
Apr 13, 2026 at 1:30=E2=80=AFAM Richard Guo &lt;<a href=3D"mailto:guofengli=
nux@gmail.com">guofenglinux@gmail.com</a>&gt; wrote:<br></div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex">On Mon, Apr 13, 2026 at 4:27=E2=80=AFP=
M SATYANARAYANA NARLAPURAM<br>
&lt;<a href=3D"mailto:satyanarlapuram@gmail.com" target=3D"_blank">satyanar=
lapuram@gmail.com</a>&gt; wrote:<br>
&gt; On Mon, Apr 13, 2026 at 12:21=E2=80=AFAM Chao Li &lt;<a href=3D"mailto=
:li.evan.chao@gmail.com" target=3D"_blank">li.evan.chao@gmail.com</a>&gt; w=
rote:<br>
&gt;&gt; Do either of you plan to propose a patch for this? If so, please g=
o ahead and I can review it. Otherwise, I can propose a patch in a couple o=
f days.<br>
<br>
&gt; I have a patch with me, let me post it shortly.<br>
<br>
Please feel free to share your patches.=C2=A0 I&#39;ve been looking into th=
is<br>
as well, but I&#39;d be happy to see independent takes on it.<br></blockquo=
te><div><br></div><div>I reviewed your patch, it looks good. I ran the test=
s you added and a few additional tests and they are passing. Please continu=
e with your patch.</div><div>Maybe a test like &quot;WHERE NEW.b &gt; thres=
hold&quot; to confirm the expansion happens before qual evaluation would be=
 good.</div><div>=C2=A0</div><div>Thanks,</div><div>Satya</div></div></div>

--0000000000006ca68c064f537890--