MIME-Version: 1.0
References: 
 <CAHg+QDcyKNWyzDoKMxiZNjv7C-wAxs8y0ZoNkOV137Y+nk3UXg@mail.gmail.com>
 <CAEG8a3KTP1sX+RbPFNST4kHdeRZQR5-dd6kEihV56=K5irrhyQ@mail.gmail.com>
In-Reply-To: 
 <CAEG8a3KTP1sX+RbPFNST4kHdeRZQR5-dd6kEihV56=K5irrhyQ@mail.gmail.com>
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Sun, 26 Apr 2026 23:04:32 -0700
Message-ID: 
 <CAHg+QDdzUMW4qQmywiPmVo2z3+HccFZL+mujdXbB+ghU21u7dA@mail.gmail.com>
Subject: Re: [PATCH] Resolve unknown-type literals in GRAPH_TABLE COLUMNS
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Content-Type: multipart/mixed; boundary="00000000000019af7206506ae422"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDdzUMW4qQmywiPmVo2z3%2BHccFZL%2BmujdXbB%2BghU21u7dA%40mail.gmail.com>
Precedence: bulk

--00000000000019af7206506ae422
Content-Type: multipart/alternative; boundary="00000000000019af7006506ae420"

--00000000000019af7006506ae420
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Apr 26, 2026 at 8:10=E2=80=AFAM Junwang Zhao <zhjwpku@gmail.com> wr=
ote:

> Hi SATYANARAYANA,
>
> On Sun, Apr 26, 2026 at 3:53=E2=80=AFAM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> >
> > Hi hackers,
> >
> > transformRangeGraphTable() calls transformExpr() and
> > assign_list_collations() for COLUMNS expressions but missed calling
> > resolveTargetListUnknowns(). As a result, literals such as 'val1'
> > in a COLUMNS clause retained type "unknown", causing failures with
> > ORDER BY, UNION, and output conversions.
> >
> > Fix by calling resolveTargetListUnknowns() on the columns target
> > list right after assign_list_collations(), similar to SELECT target
> lists in
> > transformSelectStmt().
> >
> > Attached a patch to fix this, which also includes test cases to
> reproduce.
>
> I can reproduce this and the patch fixes it.
>
> One question: why is resolveTargetListUnknowns called after
> assign_list_collations?
>
> I'm asking because in transformSelectStmt, resolveTargetListUnknowns
> is invoked before assign_query_collations. It might not matter, but keepi=
ng
> the order consistent would be good for readers.


Updated the patch. It should be before.


Thanks,
Satya

--00000000000019af7006506ae420
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,</div><br><div class=3D"gmail_quote gm=
ail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Apr 26, =
2026 at 8:10=E2=80=AFAM Junwang Zhao &lt;<a href=3D"mailto:zhjwpku@gmail.co=
m">zhjwpku@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex">Hi SATYANARAYANA,<br>
<br>
On Sun, Apr 26, 2026 at 3:53=E2=80=AFAM SATYANARAYANA NARLAPURAM<br>
&lt;<a href=3D"mailto:satyanarlapuram@gmail.com" target=3D"_blank">satyanar=
lapuram@gmail.com</a>&gt; wrote:<br>
&gt;<br>
&gt; Hi hackers,<br>
&gt;<br>
&gt; transformRangeGraphTable() calls transformExpr() and<br>
&gt; assign_list_collations() for COLUMNS expressions but missed calling<br=
>
&gt; resolveTargetListUnknowns(). As a result, literals such as &#39;val1&#=
39;<br>
&gt; in a COLUMNS clause retained type &quot;unknown&quot;, causing failure=
s with<br>
&gt; ORDER BY, UNION, and output conversions.<br>
&gt;<br>
&gt; Fix by calling resolveTargetListUnknowns() on the columns target<br>
&gt; list right after assign_list_collations(), similar to SELECT target li=
sts in<br>
&gt; transformSelectStmt().<br>
&gt;<br>
&gt; Attached a patch to fix this, which also includes test cases to reprod=
uce.<br>
<br>
I can reproduce this and the patch fixes it.<br>
<br>
One question: why is resolveTargetListUnknowns called after<br>
assign_list_collations?<br>
<br>
I&#39;m asking because in transformSelectStmt, resolveTargetListUnknowns<br=
>
is invoked before assign_query_collations. It might not matter, but keeping=
<br>
the order consistent would be good for readers.</blockquote><div><br></div>=
<div>Updated the patch. It should be before.</div><div><br></div><div><br><=
/div><div>Thanks,</div><div>Satya=C2=A0</div></div></div>

--00000000000019af7006506ae420--

--00000000000019af7206506ae422
Content-Type: application/octet-stream;
	name="v2-0001-Resolve-unknown-type-literals-in-GRAPH_TABLE-COLUMNS.patch"
Content-Disposition: attachment;
	filename="v2-0001-Resolve-unknown-type-literals-in-GRAPH_TABLE-COLUMNS.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mogslc4j0>
X-Attachment-Id: f_mogslc4j0

RnJvbTogU2F0eWEgTmFybGFwdXJhbSA8c2F0eWFuYXJsYXB1cmFtQGdtYWlsLmNvbT4KU3ViamVj
dDogW1BBVENIXSBSZXNvbHZlIHVua25vd24tdHlwZSBsaXRlcmFscyBpbiBHUkFQSF9UQUJMRSBD
T0xVTU5TIGV4cHJlc3Npb25zCgp0cmFuc2Zvcm1SYW5nZUdyYXBoVGFibGUoKSBjYWxscyB0cmFu
c2Zvcm1FeHByKCkgYW5kCmFzc2lnbl9saXN0X2NvbGxhdGlvbnMoKSBmb3IgQ09MVU1OUyBleHBy
ZXNzaW9ucyBidXQgbWlzc2VkIGNhbGxpbmcKcmVzb2x2ZVRhcmdldExpc3RVbmtub3ducygpLiBB
cyBhIHJlc3VsdCwgbGl0ZXJhbHMgc3VjaCBhcyAnY29sMScKaW4gYSBDT0xVTU5TIGNsYXVzZSBy
ZXRhaW5lZCB0eXBlICJ1bmtub3duIiwgY2F1c2luZyBmYWlsdXJlcyB3aXRoCk9SREVSIEJZLCBV
TklPTiwgYW5kIG91dHB1dCBjb252ZXJzaW9ucy4KCkZpeCBieSBjYWxsaW5nIHJlc29sdmVUYXJn
ZXRMaXN0VW5rbm93bnMoKSBvbiB0aGUgY29sdW1ucyB0YXJnZXQKbGlzdCByaWdodCBiZWZvcmUg
YXNzaWduX2xpc3RfY29sbGF0aW9ucygpLCBzaW1pbGFyIHRvIFNFTEVDVCB0YXJnZXQKbGlzdHMg
aW4gdHJhbnNmb3JtU2VsZWN0U3RtdCgpLgotLS0KZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3Bh
cnNlci9wYXJzZV9jbGF1c2UuYyBiL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYwpp
bmRleCBmMzczNjk3OS4uZjY3OWY1MTAgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9w
YXJzZV9jbGF1c2UuYworKysgYi9zcmMvYmFja2VuZC9wYXJzZXIvcGFyc2VfY2xhdXNlLmMKQEAg
LTEwMDQsNiArMTAwNCw5IEBAIHRyYW5zZm9ybVJhbmdlR3JhcGhUYWJsZShQYXJzZVN0YXRlICpw
c3RhdGUsIFJhbmdlR3JhcGhUYWJsZSAqcmd0KQogCQljb2x1bW5zID0gbGFwcGVuZChjb2x1bW5z
LCB0ZSk7CiAJfQogCisJLyogUmVzb2x2ZSB1bmtub3duLXR5cGUgbGl0ZXJhbHMgdG8gdGV4dCAq
LworCXJlc29sdmVUYXJnZXRMaXN0VW5rbm93bnMocHN0YXRlLCBjb2x1bW5zKTsKKwogCS8qCiAJ
ICogQXNzaWduIGNvbGxhdGlvbnMgdG8gY29sdW1uIGV4cHJlc3Npb25zIG5vdyBzaW5jZQogCSAq
IGFzc2lnbl9xdWVyeV9jb2xsYXRpb25zKCkgZG9lcyBub3QgcHJvY2VzcyByYW5nZXRhYmxlIGVu
dHJpZXMuCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3RhYmxl
Lm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZ3JhcGhfdGFibGUub3V0CmluZGV4IGQz
YzIwNjEwLi4yMTJmYTI5ZiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9n
cmFwaF90YWJsZS5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ncmFwaF90YWJs
ZS5vdXQKQEAgLTExMTAsNCArMTExMCw1OCBAQCBTRUxFQ1QgKiBGUk9NIEdSQVBIX1RBQkxFIChn
MSBNQVRDSCAoYSBJUyB2bDEpIENPTFVNTlMgKHVwcGVyKGEudm5hbWUpIEFTIG4pKSBPUgogIFYx
MwogKDMgcm93cykKIAorLS0gU3RyaW5nIGFuZCBOVUxMIGxpdGVyYWxzIGluIENPTFVNTlMgbXVz
dCByZXNvbHZlIHRvIHByb3BlciB0eXBlcworLS0gKG5vdCByZW1haW4gYXMgInVua25vd24iKQor
U0VMRUNUIHBnX3R5cGVvZihjMSksIGMxCisgIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChh
IElTIHZsMSkKKyAgICBDT0xVTU5TIChhLnZuYW1lIEFTIG4sICd2YWwxJyBBUyBjMSkpIE9SREVS
IEJZIG47CisgcGdfdHlwZW9mIHwgIGMxICAKKy0tLS0tLS0tLS0tKy0tLS0tLQorIHRleHQgICAg
ICB8IHZhbDEKKyB0ZXh0ICAgICAgfCB2YWwxCisgdGV4dCAgICAgIHwgdmFsMQorKDMgcm93cykK
KworLS0gT1JERVIgQlkgb24gYSBsaXRlcmFsIGNvbHVtbgorU0VMRUNUICogRlJPTSBHUkFQSF9U
QUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKQorICAgIENPTFVNTlMgKGEudm5hbWUgQVMgbiwgJ3Zh
bDEnIEFTIGMxKSkgT1JERVIgQlkgYzEsIG47CisgIG4gIHwgIGMxICAKKy0tLS0tKy0tLS0tLQor
IHYxMSB8IHZhbDEKKyB2MTIgfCB2YWwxCisgdjEzIHwgdmFsMQorKDMgcm93cykKKworLS0gVU5J
T04gYmV0d2VlbiBHUkFQSF9UQUJMRSBsaXRlcmFsIGNvbHVtbiBhbmQgcGxhaW4gdGV4dAorU0VM
RUNUICogRlJPTSBHUkFQSF9UQUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKQorICAgIENPTFVNTlMg
KGEudm5hbWUgQVMgbiwgJ3ZhbDEnIEFTIGMxKSkKKyAgVU5JT04gQUxMIFNFTEVDVCAndmFsMics
ICd2YWwzJzsKKyAgbiAgIHwgIGMxICAKKy0tLS0tLSstLS0tLS0KKyB2MTEgIHwgdmFsMQorIHYx
MiAgfCB2YWwxCisgdjEzICB8IHZhbDEKKyB2YWwyIHwgdmFsMworKDQgcm93cykKKworLS0gTlVM
TCBsaXRlcmFsIG11c3Qgbm90IGNhdXNlIGZhaWx1cmVzCitTRUxFQ1QgbiwgcGdfdHlwZW9mKGMx
KQorICBGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoYSBJUyB2bDEpCisgICAgQ09MVU1OUyAo
YS52bmFtZSBBUyBuLCBOVUxMIEFTIGMxKSkgT1JERVIgQlkgbjsKKyAgbiAgfCBwZ190eXBlb2Yg
CistLS0tLSstLS0tLS0tLS0tLQorIHYxMSB8IHRleHQKKyB2MTIgfCB0ZXh0CisgdjEzIHwgdGV4
dAorKDMgcm93cykKKworLS0gaW50ZWdlciBsaXRlcmFsIHR5cGUgaXMgcHJlc2VydmVkCitTRUxF
Q1QgcGdfdHlwZW9mKGMxKQorICBGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoYSBJUyB2bDEp
CisgICAgQ09MVU1OUyAoNDIgQVMgYzEpKSBMSU1JVCAxOworIHBnX3R5cGVvZiAKKy0tLS0tLS0t
LS0tCisgaW50ZWdlcgorKDEgcm93KQorCiAtLSBsZWF2ZSB0aGUgb2JqZWN0cyBiZWhpbmQgZm9y
IHBnX3VwZ3JhZGUvcGdfZHVtcCB0ZXN0cwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9z
cWwvZ3JhcGhfdGFibGUuc3FsIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3Fs
CmluZGV4IDI1MjFjNGNhLi4zZDc0YWI0YyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9z
cWwvZ3JhcGhfdGFibGUuc3FsCisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxl
LnNxbApAQCAtNjM0LDQgKzYzNCwyNSBAQCBTRUxFQ1Qgc3JjLnZuYW1lLCBjb3VudCgqKQogU0VM
RUNUICogRlJPTSBHUkFQSF9UQUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKSBDT0xVTU5TIChhLnZu
YW1lIHx8ICchJyBBUyBuKSkgT1JERVIgQlkgbjsKIFNFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUg
KGcxIE1BVENIIChhIElTIHZsMSkgQ09MVU1OUyAodXBwZXIoYS52bmFtZSkgQVMgbikpIE9SREVS
IEJZIG47CiAKKy0tIFN0cmluZyBhbmQgTlVMTCBsaXRlcmFscyBpbiBDT0xVTU5TIG11c3QgcmVz
b2x2ZSB0byBwcm9wZXIgdHlwZXMKKy0tIChub3QgcmVtYWluIGFzICJ1bmtub3duIikKK1NFTEVD
VCBwZ190eXBlb2YoYzEpLCBjMQorICBGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoYSBJUyB2
bDEpCisgICAgQ09MVU1OUyAoYS52bmFtZSBBUyBuLCAndmFsMScgQVMgYzEpKSBPUkRFUiBCWSBu
OworLS0gT1JERVIgQlkgb24gYSBsaXRlcmFsIGNvbHVtbgorU0VMRUNUICogRlJPTSBHUkFQSF9U
QUJMRSAoZzEgTUFUQ0ggKGEgSVMgdmwxKQorICAgIENPTFVNTlMgKGEudm5hbWUgQVMgbiwgJ3Zh
bDEnIEFTIGMxKSkgT1JERVIgQlkgYzEsIG47CistLSBVTklPTiBiZXR3ZWVuIEdSQVBIX1RBQkxF
IGxpdGVyYWwgY29sdW1uIGFuZCBwbGFpbiB0ZXh0CitTRUxFQ1QgKiBGUk9NIEdSQVBIX1RBQkxF
IChnMSBNQVRDSCAoYSBJUyB2bDEpCisgICAgQ09MVU1OUyAoYS52bmFtZSBBUyBuLCAndmFsMScg
QVMgYzEpKQorICBVTklPTiBBTEwgU0VMRUNUICd2YWwyJywgJ3ZhbDMnOworLS0gTlVMTCBsaXRl
cmFsIG11c3Qgbm90IGNhdXNlIGZhaWx1cmVzCitTRUxFQ1QgbiwgcGdfdHlwZW9mKGMxKQorICBG
Uk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoYSBJUyB2bDEpCisgICAgQ09MVU1OUyAoYS52bmFt
ZSBBUyBuLCBOVUxMIEFTIGMxKSkgT1JERVIgQlkgbjsKKy0tIGludGVnZXIgbGl0ZXJhbCB0eXBl
IGlzIHByZXNlcnZlZAorU0VMRUNUIHBnX3R5cGVvZihjMSkKKyAgRlJPTSBHUkFQSF9UQUJMRSAo
ZzEgTUFUQ0ggKGEgSVMgdmwxKQorICAgIENPTFVNTlMgKDQyIEFTIGMxKSkgTElNSVQgMTsKKwog
LS0gbGVhdmUgdGhlIG9iamVjdHMgYmVoaW5kIGZvciBwZ191cGdyYWRlL3BnX2R1bXAgdGVzdHMK
--00000000000019af7206506ae422--