MIME-Version: 1.0
References: 
 <CAHg+QDeteXPbPFsThTGTL=qp4dgiP1AH1kKktifcksDbiaRROw@mail.gmail.com>
 <afjYnSJeXoa2LFaU@alvherre.pgsql>
In-Reply-To: <afjYnSJeXoa2LFaU@alvherre.pgsql>
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Mon, 4 May 2026 11:08:06 -0700
Message-ID: 
 <CAHg+QDegHnVEFdmp8e_k6b4DhC4R0MpCv26SEhz6gYSeZt-nVw@mail.gmail.com>
Subject: Re: [Bug]Vacuum full silently NULL out fast default columns
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Antonin Houska <ah@cybertec.at>
Content-Type: multipart/alternative; boundary="000000000000c8ce97065101d088"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDegHnVEFdmp8e_k6b4DhC4R0MpCv26SEhz6gYSeZt-nVw%40mail.gmail.com>
Precedence: bulk

--000000000000c8ce97065101d088
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, May 4, 2026 at 10:41=E2=80=AFAM =C3=81lvaro Herrera <alvherre@kuril=
emu.de> wrote:

> On 2026-May-04, SATYANARAYANA NARLAPURAM wrote:
>
> > On Mon, May 4, 2026 at 6:40=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wro=
te:
>
> > > A quick bisect run agrees that it broke here:
> > >
> > > 28d534e2ae0ac888b5460f977a10cd9bb017ef98 is the first bad commit
> > > commit 28d534e2ae0ac888b5460f977a10cd9bb017ef98 (HEAD)
> > > Author: =C3=81lvaro Herrera <alvherre@kurilemu.de>
> > > Date:   Mon Apr 6 21:55:08 2026 +0200
> > >
> > >     Add CONCURRENTLY option to REPACK
>
> Right.
>
> > Thanks for reviewing! Attached v2 patch. Agreed, tried to optimize LOC =
in
> > V1. Before the change loop was not breaking early, I fixed that as
> > well in V2.
>
> Yeah, this seems a good approach to me.  I propose some more comment
> updates though, and I also thought it'd be a good idea to add a test for
> REPACK CONCURRENTLY while at it.
>

This patch LGTM. It applied cleanly and all the tests passed.

Thanks,
Satya

--000000000000c8ce97065101d088
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,</div><br><div class=3D"gmail_quote gm=
ail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, May 4, 2=
026 at 10:41=E2=80=AFAM =C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherre@=
kurilemu.de">alvherre@kurilemu.de</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">On 2026-May-04, SATYANARAYANA NARLAPURAM w=
rote:<br>
<br>
&gt; On Mon, May 4, 2026 at 6:40=E2=80=AFAM Tom Lane &lt;<a href=3D"mailto:=
tgl@sss.pgh.pa.us" target=3D"_blank">tgl@sss.pgh.pa.us</a>&gt; wrote:<br>
<br>
&gt; &gt; A quick bisect run agrees that it broke here:<br>
&gt; &gt;<br>
&gt; &gt; 28d534e2ae0ac888b5460f977a10cd9bb017ef98 is the first bad commit<=
br>
&gt; &gt; commit 28d534e2ae0ac888b5460f977a10cd9bb017ef98 (HEAD)<br>
&gt; &gt; Author: =C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherre@kurile=
mu.de" target=3D"_blank">alvherre@kurilemu.de</a>&gt;<br>
&gt; &gt; Date:=C2=A0 =C2=A0Mon Apr 6 21:55:08 2026 +0200<br>
&gt; &gt;<br>
&gt; &gt;=C2=A0 =C2=A0 =C2=A0Add CONCURRENTLY option to REPACK<br>
<br>
Right.<br>
<br>
&gt; Thanks for reviewing! Attached v2 patch. Agreed, tried to optimize LOC=
 in<br>
&gt; V1. Before the change loop was not breaking early, I fixed that as<br>
&gt; well in V2.<br>
<br>
Yeah, this seems a good approach to me.=C2=A0 I propose some more comment<b=
r>
updates though, and I also thought it&#39;d be a good idea to add a test fo=
r<br>
REPACK CONCURRENTLY while at it.<br></blockquote><div><br></div><div>This p=
atch LGTM. It applied cleanly and all the tests passed.</div><div><br></div=
><div>Thanks,</div><div>Satya=C2=A0</div></div></div>

--000000000000c8ce97065101d088--