MIME-Version: 1.0
References: <d8f8e11f06d692fff89e6be0f22732d30cf695a0.camel@j-davis.com>
 <CANWCAZZOSBuypxdGA-VJ9p5deDqAH1F48aXe58ABaP7cjsZyQg@mail.gmail.com>
 <CAHgHdKsciwDvZkyUi+=i-tjK3CdD3DCccLgA2wT5AEzXdM0aHg@mail.gmail.com>
 <e23318a34c7ad2408dd9604ce441ba96110d557d.camel@j-davis.com>
In-Reply-To: <e23318a34c7ad2408dd9604ce441ba96110d557d.camel@j-davis.com>
From: Mark Dilger <mark.dilger@enterprisedb.com>
Date: Thu, 23 Apr 2026 16:41:13 -0700
Message-ID: 
 <CAHgHdKs7XL5mPOVtc4JU300Ku-9FHX9Lbgy_G=P+-0D2Nu0PTw@mail.gmail.com>
Subject: Re: GUC parameter ACLs and physical walsender
To: Jeff Davis <pgsql@j-davis.com>
Cc: John Naylor <johncnaylorls@gmail.com>, pgsql-hackers@postgresql.org,
	Andrey Borodin <x4mmm@yandex-team.ru>
Content-Type: multipart/alternative; boundary="0000000000008b593d0650292ff2"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHgHdKs7XL5mPOVtc4JU300Ku-9FHX9Lbgy_G%3DP%2B-0D2Nu0PTw%40mail.gmail.com>
Precedence: bulk

--0000000000008b593d0650292ff2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 23, 2026 at 2:06=E2=80=AFPM Jeff Davis <pgsql@j-davis.com> wrot=
e:

> On Thu, 2026-04-23 at 10:57 -0700, Mark Dilger wrote:
> > John is right that the hardcoded BKI_ROWTYPE_OID(2173) makes this
> > non-backportable as-is.
>
> Right, but that leaves the questions:
>
> (a) Is this the right fix for master?
>

Yes.  This approach has no problem in master that I can see.


> (b) Is there anything we can do in the back branches, or we just leave
> it as fix going forward only?
>

I don't see a solution.  We could try to replace the error message with
something better, but even that seems hard to phrase.  Replacing
"cannot read pg_class without having selected a database" with, say,
"permission denied" would also be confusing for a role which does have
the privilege but just can't verify it.

--=20

*Mark Dilger*

--0000000000008b593d0650292ff2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Apr 23,=
 2026 at 2:06=E2=80=AFPM Jeff Davis &lt;<a href=3D"mailto:pgsql@j-davis.com=
">pgsql@j-davis.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">On Thu, 2026-04-23 at 10:57 -0700, Mark Dilger wrote:<br=
>
&gt; John is right that the hardcoded BKI_ROWTYPE_OID(2173) makes this<br>
&gt; non-backportable as-is.<br>
<br>
Right, but that leaves the questions:<br>
<br>
(a) Is this the right fix for master?<br></blockquote><div><br></div><div>Y=
es.=C2=A0 This approach has no problem in master that I can see.</div><div>=
=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
(b) Is there anything we can do in the back branches, or we just leave<br>
it as fix going forward only?<br></blockquote><div><br></div><div>I don&#39=
;t see a solution.=C2=A0 We could try to replace the error message with</di=
v><div>something better, but even that seems hard to phrase.=C2=A0 Replacin=
g</div><div>&quot;cannot read pg_class without having selected a database&q=
uot; with, say,<br></div><div>&quot;permission denied&quot; would also be c=
onfusing for a role which=C2=A0does have</div><div>the privilege but just c=
an&#39;t verify it.</div></div><div><br></div><span class=3D"gmail_signatur=
e_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=
=3D"ltr"><img src=3D"https://lh7-us.googleusercontent.com/80Q0n8A18y4ur9BMm=
N9zDAoEOCSfqCbmGOQ2lI1IqwUyarDBFhlxOOMrLytOC5x5Zo8-TD9NOpLXzn1w2srXBDsTderY=
Uy9-mH4Gb1KBetRMWRtZ2Tlsbk7YUDupvd1b1zTB3hZ2AQdJ5rZJ_AKjBPs" width=3D"220" =
height=3D"47.07423580786026" style=3D"color: rgb(0, 0, 0); margin-left: 0px=
;"><br style=3D"color:rgb(0,0,0);font-family:Helvetica;font-size:18px"><div=
><font size=3D"4" face=3D"garamond, times new roman, serif"><b>Mark Dilger<=
/b></font></div></div></div></div>

--0000000000008b593d0650292ff2--