MIME-Version: 1.0
References: <94ECEF6E-681B-40DF-8F6B-4CABE4CDB96A@gmail.com>
 <202512031432.cpvnk5irwygr@alvherre.pgsql>
In-Reply-To: <202512031432.cpvnk5irwygr@alvherre.pgsql>
From: Peter Smith <smithpb2250@gmail.com>
Date: Thu, 4 Dec 2025 08:00:51 +1100
Message-ID: 
 <CAHut+PsP+5ov_=zhsd+yGunCCfTSM0qXe-a0VHwGyzQOe-SYxQ@mail.gmail.com>
Subject: Re: Cleanup shadows variable warnings, round 1
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>, Peter Eisentraut <peter@eisentraut.org>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPsP%2B5ov_%3Dzhsd%2ByGunCCfTSM0qXe-a0VHwGyzQOe-SYxQ%40mail.gmail.com>
Precedence: bulk

On Thu, Dec 4, 2025 at 1:36=E2=80=AFAM =C3=81lvaro Herrera <alvherre@kurile=
mu.de> wrote:
>
> On 2025-Dec-03, Chao Li wrote:
>
> > Unfortunately that doesn=E2=80=99t work for my compiler (clang on MacOS=
),
> > that=E2=80=99s why I renamed =E2=80=9CI" to =E2=80=9Cu=E2=80=9D.
>
> I think you're missing his point.  He's suggesting to change not only
> this variable, but also the other uses of "i" in this function.
>

Exactly. I should have posted the larger diff, as you did. Thanks for
clarifying.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia