MIME-Version: 1.0
References: 
 <CALDaNm2RYQRLjexRJOpiZOFkspp8PRgoh6S7d2y003TJ_TSSZA@mail.gmail.com>
 <CAHut+PtGOeXr69qQRgq_DW=BEEix_6bDsgmR8Vk4_qbNy5BvAA@mail.gmail.com>
 <CALDaNm05u0UvteGQf_9wKbUFujO0JvJk=GnTeZyxsdB0bmPtcg@mail.gmail.com>
 <CAHut+PsKCgwTP-6TxdwcNT5FT3dTyJiVfEKMPJR1K3df0EbOqQ@mail.gmail.com>
 <CAE9k0PmZKp_zSNRm7KoLzOjaxnxUjLmA-W02fhg11fqEjB50Vw@mail.gmail.com>
In-Reply-To: 
 <CAE9k0PmZKp_zSNRm7KoLzOjaxnxUjLmA-W02fhg11fqEjB50Vw@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Thu, 25 Jun 2026 17:57:46 +1200
Message-ID: 
 <CAHut+PsTUJLhPyUq84KfEnMwjmFz0813_LAOk57F+TFmBqwF6g@mail.gmail.com>
Subject: Re: Include sequences in publications created by pg_createsubscriber
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPsTUJLhPyUq84KfEnMwjmFz0813_LAOk57F%2BTFmBqwF6g%40mail.gmail.com>
Precedence: bulk

On Thu, Jun 25, 2026 at 5:35=E2=80=AFPM Ashutosh Sharma <ashu.coek88@gmail.=
com> wrote:
>
> Hi,
>
> On Thu, Jun 25, 2026 at 6:29=E2=80=AFAM Peter Smith <smithpb2250@gmail.co=
m> wrote:
> >
> > 3.
> >       <para>
> >        Enable the subscription for each specified database on the targe=
t server.
> >        The subscription starts applying transactions from the replicati=
on start
> > -      point.
> > +      point. The subscription is configured to include sequences.
> >       </para>
> >
> > This implies there was some special subscription "configuration" for
> > getting sequences, but it just gets sequences because sequences were
> > published. Maybe you don't need to say anything here. Or, maybe reword
> > to just say "The subscription will include sequences".
> >
>
> What if the subscription uses an existing publication that doesn't
> include sequences? In that case, would it be correct to say that the
> subscription will include sequences?
>

Oops. Fair point. Looks like the original patch text suffered similar issue=
s.

A more descriptive explanation seems needed for this to talk about the
differences of internal publications versus user-supplied ones....
e.g. a user-publication may even be only FOR ALL SEQUENCES and not
even have tables in them... then what?

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia.