MIME-Version: 1.0
References: 
 <CAHut+PvikGr4AtoFSs=jq=hmTybVF2NCMEZ57-sjwbGudfuqsQ@mail.gmail.com>
 <9FE5AA84-F1A1-4E1C-8EF8-3AFD6C46B318@gmail.com>
In-Reply-To: <9FE5AA84-F1A1-4E1C-8EF8-3AFD6C46B318@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Thu, 9 Apr 2026 13:24:59 +1000
Message-ID: 
 <CAHut+PsUQfddBnjE9m1x4aoWAgRMEnsVFeg2cZJt9BCC_nbwfg@mail.gmail.com>
Subject: Re: Add missing period to HINT messages
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPsUQfddBnjE9m1x4aoWAgRMEnsVFeg2cZJt9BCC_nbwfg%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 9, 2026 at 12:09=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:
>
>
>
> > On Apr 9, 2026, at 07:30, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi,
> >
> > According to the error message style guide [1], "Detail and hint
> > messages: Use complete sentences, and end each with a period."
> >
> > I found there is a small group of HINT messages not following that peri=
od rule.
> >
> > PSA a patch that fixes the missing period. In passing, also fixed a
> > typo in a hint message /msut/must/.
> >
> > ~~~
> >
> > On further inspection, lots of these affected messages don't even seem
> > grammatically correct to me.
> >
> > I did not modify them, but here are examples of what I mean.
> >
> > e.g.
> > "ALTER TABLE ... MERGE PARTITIONS can only merge partitions don't have
> > sub-partitions."
> > /don't have/that don't have/
> >
> > e.g.
> > "ALTER TABLE ... SPLIT PARTITION can only split partitions don't have
> > sub-partitions."
> > /don't have/that don't have/
> >
> > e.g.
> > "To split DEFAULT partition one of the new partition must be DEFAULT."
> > missing word? -- "To split the DEFAULT partition"
> > should be plural? -- "one of the new partitions"
> >
> > e.g.
> > "%s require combined bounds of new partitions must exactly match the
> > bound of the split partition."
> > /require/requires/ ?
> > /match the bound/match the bounds/
> >
> > =3D=3D=3D=3D=3D=3D
> > [1] https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-=
STYLE-GUIDE-GRAMMAR-PUNCTUATION
> >
> > Kind Regards,
> > Peter Smith.
> > Fujitsu Australia
> > <v1-0001-Add-missing-period-to-HINT-messages.patch>
>
> LGTM.
>
> BTW, errdetail should follow the same style, and I see some detail messag=
es miss periods, maybe this patch can include those as well.
>

Yep. It is already under way. I will post the equivalent errdetail
patch shortly. (as soon as it passes running make- check-world).

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia