Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wRPsp-002KJI-1n for pgsql-hackers@arkaria.postgresql.org; Mon, 25 May 2026 07:37:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wRPsm-000W7P-0U for pgsql-hackers@arkaria.postgresql.org; Mon, 25 May 2026 07:37:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wRPsl-000W7H-2m for pgsql-hackers@lists.postgresql.org; Mon, 25 May 2026 07:37:52 +0000 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wRPsl-00000000fT7-03eq for pgsql-hackers@lists.postgresql.org; Mon, 25 May 2026 07:37:51 +0000 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-5165195c8b0so103838091cf.0 for ; Mon, 25 May 2026 00:37:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779694670; cv=none; d=google.com; s=arc-20240605; b=BR2Or2qmUpLuLaLvBsSQG0p4jatKNWeB98xC2yntyz+Wf0c5OgR1B3xJVn5VbDJM6w qwt5irUUstB8wzwMnnj/bPsPaxZClNwGqnBtoGXS860Jihy7dPvczO1bi+fsu68muBCS rz/CZRV9ibH5dHTFsu6kzEfMyg9p8MuLA9Xuuz0VOfL4NIitiwAepAIe+4c+fpgC8AdV +iAWuqkD6J485JTftq0OHMa7LSHtohD7b8NNhn7QV99DZguNW0ddcN+AJsfJStXWN2GV LYDxvGpi6EWpTZiQWypN79myCJuXcRgiZqHSAB6g7PSM0sWRHfbER6eo4AhGK4QCMC+j GUSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lNLgNn6TXAE4o1IByilCebkDOqkANPd8LEcVMNf4pzs=; fh=cMhrMYBZexO/emJsI2MhDar9PkoFeEoGXVZ8u/YCZx0=; b=Dus514+PrR/BXse5evmF9tuW55tUvHh5GOJINMe8pfdXBIIq8uz/ya7lKCnOMnPZzi yYO8Nrc78waWtRHRe38iejtCbZ2GmYOXPNBDZgzlT551B6sqDzxa3A+/17Rj1SCAKA7G pnG+/WP7uZnXwWO0EpA3ptFYqzrC9VnyqAmjnzG0cY+Cu77kL21lfXxmfD6CmXfCrE2n u0lHuvWacr88YZaP3T3uTiNLAEYHzEsEvznDIHA+wCjw1lbHVTRdVnWp/fdXDfIrqDUd ghJ6TmZmEAjYv3pO5SKXKItHgU11Tgx5Vd1Vt7xf4zHawbUbeEiQ1jyMcCvQMmXaOZkW VdSA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779694670; x=1780299470; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lNLgNn6TXAE4o1IByilCebkDOqkANPd8LEcVMNf4pzs=; b=ICBDPiwcuVThh/Ml0+9Y1VfFGUlRsuKhlIVdtVkHQauPiTpfCRPpn0MuVrsmFQ3QMN eSq3JapO8+KwMYFmvDlzhda4ptIvehaKfZETsKGsj6M3UCoSXJh1cayedPQPEQwCi0Eu hTM153O/tQFeUjVgphtgGFHWgJY9J7T4ofBBEnnZfmHXwBIyf9iNsZOeySc8KBCcY1QB Ax7upxrfbfjB1qk+H1w9WmZEVhaKcSnT++D+++BoPIZCh+DgT5ZyGsnCRQaFji365Ook KkPeAiOS+GWve9cjyY+0FGNtK/HX3+qml19P381suz4p/Q1qZoHDaUBwfEjNuyx7az3E 0JUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779694670; x=1780299470; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lNLgNn6TXAE4o1IByilCebkDOqkANPd8LEcVMNf4pzs=; b=gHHl3j+qjENZjHjIMQ315z//m0Ul6oP0RIDaeAYSXSkKGgnOl6Po1ZvUZINti3g8/m a29kqregV2lwC7xshJ/gOjUtLplSCO8R9UdtHAzL4Vg/yW1YQjQsQPQNQzqWynQOobHB 1SG6vDT6Iu8Rp+HJLiAJNBFnfiV+ybqibiR56Z6vd95Iw9Tnb3G9KTGs9ndAm5J5G1Xe sPhfZU2OcUZUAJ9QJ4kpxtYzBgs3XEXI8J5Vy8XiTQaVXsySg7ru9K5fvFh0mUrUzJ0L Ne3fIQK5HT4GJA2/TuYjp0Dh/akj1T+srNTMN7XSTLHAyNV0eVkEvcySDCBMeKHputM1 sS3Q== X-Forwarded-Encrypted: i=1; AFNElJ9NsDrdG0hULGWee983/AWRPFnP9NBXy8RY/XanwBDO0cWSVXpkGWgocjkZ7yCKmVxjt3q3acg7Fh7LGeZ1@lists.postgresql.org X-Gm-Message-State: AOJu0YwMC2IjxVtUSGqKD/E2TXK7iizs2I2g1lZ9uHKAmsChJfTzSZgt GYSz8P0HtXEPbtBLXBnBQFIpkEgTKLjNbhzYKM5FSP1Kb0LmayYrRs3mA55tv35VhqVgSy2a2IU kSD2+DBqm/FJgrpHs8/JaBY+o3gIsnjI= X-Gm-Gg: Acq92OEVAhe0hRJCA1a3NM9vO4R7Y1elE9bky55vos3RgJTXPEZnDgBhebch+8namNc jyoYDv1GvS+et1+AYMSyiuFcb6Xuza+uDaff4M9fxQ0JtpTBx9NXuXy1+6aGhXh7yXjxOCv7bGl 9Pc4yMfkaFMzqJw0mbSGwS1Uk4g8gV1aI/4as9kQ1ZVwL216JxiudpRDjnzRpA2LHwzSlyixLAb SJRALvWI98cBN3+jHZWXBDHac5LGujLFOsamx0Vc4I/F4zunvSoaFSldcTI1P7BqsHal/oMrXoS DKWMiMzv8we0N49whQ== X-Received: by 2002:a05:622a:1c10:b0:516:e033:f5a8 with SMTP id d75a77b69052e-516e033f8a8mr123661951cf.59.1779694670174; Mon, 25 May 2026 00:37:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Mon, 25 May 2026 17:37:22 +1000 X-Gm-Features: AVHnY4JIsFXePKnHgzlIkXBx9te9I_dw1MVMuEOdhUbOZAqxElB00X4LsSupS3Y Message-ID: Subject: Re: Support EXCEPT for ALL SEQUENCES publications To: Shlok Kyal Cc: shveta malik , vignesh C , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Shlok - I wonder if it might be worth reconsidering the split between patches 0001 and 0002. My understanding is that the only reason for splitting is to make review easier, but it had the opposite effect for me. The difficulty is that 0001 contains renaming of functions and variables whose purpose only becomes clear in 0002. Without any context, the changes in 0001 are hard to evaluate on their own merits =E2=80=94 anybody reading patch 0001 is left guessing what is coming rather than seeing the full picture. It also won't be saving much overall patch size, since AFAICT most of the same locations are touched again in 0002 anyway. There is also the matter of identifier renames (patch 0001) being separated from their associated comment updates (0002). Keeping those together would reduce the risk of anything being inadvertently missed. I think a combined 0001/0002 patch would be easier to follow, since reviewers could see each change alongside its reason. =3D=3D=3D=3D=3D=3D Kind Regards Peter Smith. Fujitsu Australia