Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1whdhK-000L80-1U for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2026 01:37:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1whdhH-00AJwQ-2y for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2026 01:37:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1whdhH-00AJwI-24 for pgsql-hackers@lists.postgresql.org; Thu, 09 Jul 2026 01:37:04 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1whdhF-00000000Njd-2uc1 for pgsql-hackers@lists.postgresql.org; Thu, 09 Jul 2026 01:37:04 +0000 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-92e5c9211d2so103748585a.1 for ; Wed, 08 Jul 2026 18:37:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783561020; cv=none; d=google.com; s=arc-20260327; b=RsRIpw95ye2OctC4CeCXZC0bEv/ntl7cdZeucqbznNNx2598MCg/9rqR7nYSGlxH3X vs91xQccAaxyuBfZFCEIpmg12wHSoX/Ssz/sgUGOtphcc1g1ul3u8vV+baFoxDbO8o8k JZTG55GESRt4CiYgRTS5/JVGrAZSjgnRwXvK3R6B6WYFRBdIKML6HUaiVhmpoiZ75y+M rD048CF8iT7kESiptVeeGW6LbNRiuSZWf1OkQWlY8tKiXmxPFINczSacNzUNHS1xZgf0 pGgeKAcAqOqOVsmmCSIinYIQrSEzyb+wbscnZOWLWQXV9kPH7cSc7wlTNJ0NRSygEBgh /10g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=5bUldy1nHu30l96E88iQ2Xyz/IKPXIGxrYY+YIBmRjQ=; fh=VUE7EY6rlmGl7CxmBI4kjPmZ8U4WctPgQtYAgr5cmZs=; b=HnRz54wSqm0kc/0s3l2E30PxpVvhdvfnWSyeb56+NwcXCZJf/ZVDY0t2e46Utd5JBe kwj1Tb8XhtS5iRXY6quHusgAKSakkazVYQHXz05FQrb1FG3rnbx8hr6xqb0yF+BAD1kK vIf2rk4i6S/dJbur3i0dygydpplIy7KXBB5bmU/KOHv1Esozjxl3YN6wBdlZxQP9ikW4 ifHwQx/+iF/Fnbj00VdAc0zEpZyz3sm3rILJAGZBd55Eyr4mB4n3O7ZxYeT03id1gBFX wNmseV9VshV5vxI/Ra4pjr79lceGvn7G+35/Kjx3wAA1GWIG5Cs12SUlNqL0xAqwBffE 9wCw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783561020; x=1784165820; darn=lists.postgresql.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5bUldy1nHu30l96E88iQ2Xyz/IKPXIGxrYY+YIBmRjQ=; b=WyWT0k6Ty81qui7R1mD8SjiswAtboAZrCKgzo0LXwPEwAF8obeCGvps1LUZmVBnvy0 UUlxY11J2uemBYUjID5F3SMMT/TUAZVpCdjuQ80bBgwLzZxvGh1qCQbABNctiyINlFl1 nCKOYbYL5hU5+GyHNwAxWD7nlDIzMhqk/qYeqrEqtdpVPGX8xv9WKJYyYH9tf8aHux3/ PEFiQxBcdBNxrOhGhf5uvWcQj1yoIJu4713JO+4VLx8/jBKpn05LCkgFdHuBaXsWDUa8 fmnhNuXmqAkjafJKbmAoMl9x/E3cZgfE2xtxTam5Z+o5abCWZUqIGLsDtXDmpl0ceMPc kRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783561020; x=1784165820; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=5bUldy1nHu30l96E88iQ2Xyz/IKPXIGxrYY+YIBmRjQ=; b=f/MBnZ7gRdxBwUin3gB5bsk/jFxnh+4YNqq3EVsCjXjk+9TbX+gq5ypyJ3+AH2yVFg u0z51/DlhDCNYIcX4g31ZrgaMschaGi5nIXVTejxCXsQmDMnXJSZmWIBvULydSilG3iO yGeq27Yodcp/T1IeEoIa/u94SnTsx0BUFR6B5rcFM8BK2BzoLIoyKSuKWn7uGMTo8eiX KnB5c6ilWSFZdeOh45/Z2+VROgx/CGfpiPbUcSdWW5cqnSEquv1IGXmNZVn99TqOzW46 egAhXVKaH2Kb29RHxZwdC+H2oWOH2DnBBcKSlyM8QzVVfkOGtjTBSw4s/qsnzwOK1PMw 05Cg== X-Forwarded-Encrypted: i=1; AHgh+RrHsgMd8/nAqsquLWuWm9ZzN440ea/JfkYanfVZuyt5lOASRKxJbhLOPtfcN+BCTK5Bp1nV5gQM8nnz152s@lists.postgresql.org X-Gm-Message-State: AOJu0YzbprbrBBK7kEd5YyPLkcGF2b5hni+2CqQAS0a6OmSMvTT1BuJB d+nuBo5dxP+vUxfXfXp2GUL5cAdYVisRAjpbL3mYrmYGngB/bEZhNbRu1qMO8Mws4zFU/oSdEon wQ8Xu6ZbtG/x/zyn94i2lc2XzMK2jOE4= X-Gm-Gg: AfdE7clh4WLybhOA2npsUBMzVjrvZC/7zWlUPy36JF2E29sdpnCu3QgGxuGsedC9wGy K0Y/hlQ9Ec9t94uUvtia+HHK/XJ/0u93okWHmVu18998jmIt/eX9sxOE3w8Z0E4dPHndZEBseRG IFUxPqw5BNGBPDZpJIkmbx4TJPVpR1j5oEDJBZUBTBS8zkKXSzEeMs3cltw3wHr+7Tb5jP/Favn ii/on/SrV1FfdpmU6V70Gj6eAhv6y0eG8pji0FVEEvHhWjD6lwexGN4n706mwkSu0jJYvFok+Tq 6fjqpy5Ek99BcGppDWmPGkIGwZ48QSLlerb3SACf7zLFiYq9GgTqTw== X-Received: by 2002:a05:620a:3725:b0:925:4309:dd18 with SMTP id af79cd13be357-92ecf6291d1mr567143185a.1.1783561020438; Wed, 08 Jul 2026 18:37:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Thu, 9 Jul 2026 11:36:34 +1000 X-Gm-Features: AVVi8CctP_VutLtcveAWZAayRg8ObHlOUVA4jpMgszCi9v3_OmgDwDu2OOKx51Q Message-ID: Subject: Re: Include sequences in publications created by pg_createsubscriber To: vignesh C Cc: Shlok Kyal , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Some review comments for v8 ====== doc/src/sgml/ref/pg_createsubscriber.sgml 1. + which ensures each table is brought up to a synchronized state. When using + internally generated publications, the publications automatically include + all sequences in the database; however, sequence values are not + automatically synchronized. Maybe "automatically" 2x in the same sentence is a bit much. The rest can also be simpler. SUGGESTION Internally generated publications include all sequences in the database, but their values are not automatically synchronized. ~~~ 2. + objects defined by that publication. Otherwise, + pg_createsubscriber creates a publication + using + FOR ALL TABLES and ALL + SEQUENCES. These generated publications has the + following name pattern: 2a. The space before the last tag here is probably not deliberate. ~ 2b. typo: /has the/have the/ ====== Kind Regards, Peter Smith. Fujitsu Australia