MIME-Version: 1.0
References: 
 <CAHut+Pti83yGaV5-DZU=AvJHxFDuoKW8_pjSedRham8SgZxLYA@mail.gmail.com>
 <CALDaNm0nLdBKJVHVvvOnY_5mkVg20=OL18fdjA5+KZ3GhPB=TQ@mail.gmail.com>
 <CAHut+Pv+a-7-NRrZv4v6RfaaUo5b21RXe0tGOu8CfKrxPjE=tw@mail.gmail.com>
 <CAJpy0uAHe88hL5MX3q9tyGyx_gCKKHcWnmETXvXM2CqnE8jrmA@mail.gmail.com>
 <CAHut+PtfHzxHFkHJWYoxOFpgpSH5HNAGmP5sSrwh1d+R0Ab-BQ@mail.gmail.com>
In-Reply-To: 
 <CAHut+PtfHzxHFkHJWYoxOFpgpSH5HNAGmP5sSrwh1d+R0Ab-BQ@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Wed, 8 Apr 2026 16:27:49 +1000
Message-ID: 
 <CAHut+PsjrPOcs=ePWm+N-q=rdmhDeM-FE05gPgDoN647Jb3RaQ@mail.gmail.com>
Subject: Re: Logical Replication - revisit `is_table_publication` function
 implementation
To: shveta malik <shveta.malik@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000053dc49064eed013f"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPsjrPOcs%3DePWm%2BN-q%3DrdmhDeM-FE05gPgDoN647Jb3RaQ%40mail.gmail.com>
Precedence: bulk

--00000000000053dc49064eed013f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 8, 2026 at 4:04=E2=80=AFPM Peter Smith <smithpb2250@gmail.com> =
wrote:
>
> On Wed, Apr 8, 2026 at 3:25=E2=80=AFPM shveta malik <shveta.malik@gmail.c=
om> wrote:
> >
> > On Wed, Apr 8, 2026 at 10:24=E2=80=AFAM Peter Smith <smithpb2250@gmail.=
com> wrote:
> > >
> > > On Wed, Apr 8, 2026 at 1:45=E2=80=AFPM vignesh C <vignesh21@gmail.com=
> wrote:
> > > >
...
> > > > And also why just check for puballtables why not to check for pubal=
lsequences
> > >
> > > I think function is_schema_publication() is unrelated to 'puballseque=
nces'.
> > >
> > > e.g. all the following will still need to check
> > > pg_publication_namespace, regardless of the 'puballsequences' value.
> > >
> > > ex1. CREATE PUBLICATION ... FOR ALL SEQUENCES;
> > > ex2. CREATE PUBLICATION ... FOR ALL SEQUENCES, FOR TABLES IN SCHEMA s=
1;
> > > ex3. CREATE PUBLICATION ... FOR TABLES IN SCHEMA s1;
> > >
> >
> > IIUC, we don't support mix of ALL SEQUENCES and TABLES IN SCHEMA s1.
> > So I could not understand your point, why FOR ALL SEQ still need to
> > check pg_publication_namespace?
> >
>
> Oh! You are right.
>
> (Sorry, Vignesh, I did not recognise that combination as unsupported).
>
> I'll post a patch update to handle it.
>

PSA patch v2.

Same as before, but now also doing a quick return false from both
functions if `puballsequences` is true.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia

--00000000000053dc49064eed013f
Content-Type: application/octet-stream;
	name="v2-0001-rewrite-is_table_publication.patch"
Content-Disposition: attachment;
	filename="v2-0001-rewrite-is_table_publication.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnpo0vh30>
X-Attachment-Id: f_mnpo0vh30

RnJvbSBmMDllYmFlMTkwNzE2ZTQ0MGE2Y2U3ZGQxMzUwNTZhNjM0M2NkOWQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBTbWl0aCA8cGV0ZXIuYi5zbWl0aEBmdWppdHN1LmNv
bT4KRGF0ZTogV2VkLCA4IEFwciAyMDI2IDE2OjIyOjM3ICsxMDAwClN1YmplY3Q6IFtQQVRDSCB2
Ml0gcmV3cml0ZSBpc190YWJsZV9wdWJsaWNhdGlvbgoKLS0tCiBzcmMvYmFja2VuZC9jYXRhbG9n
L3BnX3B1YmxpY2F0aW9uLmMgICB8IDQ0ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCiBzcmMv
YmFja2VuZC9jb21tYW5kcy9wdWJsaWNhdGlvbmNtZHMuYyB8ICA3ICsrLS0KIHNyYy9pbmNsdWRl
L2NhdGFsb2cvcGdfcHVibGljYXRpb24uaCAgIHwgIDQgKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDI4
IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5k
L2NhdGFsb2cvcGdfcHVibGljYXRpb24uYyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvcGdfcHVibGlj
YXRpb24uYwppbmRleCBhNDNkMzg1YzYwNS4uZTIwMDNjZDkyMDMgMTAwNjQ0Ci0tLSBhL3NyYy9i
YWNrZW5kL2NhdGFsb2cvcGdfcHVibGljYXRpb24uYworKysgYi9zcmMvYmFja2VuZC9jYXRhbG9n
L3BnX3B1YmxpY2F0aW9uLmMKQEAgLTI3NSwxOSArMjc1LDI2IEBAIGZpbHRlcl9wYXJ0aXRpb25z
KExpc3QgKnRhYmxlX2luZm9zKQogICogc2NoZW1hIGlzIGFzc29jaWF0ZWQgd2l0aCB0aGUgcHVi
bGljYXRpb24uCiAgKi8KIGJvb2wKLWlzX3NjaGVtYV9wdWJsaWNhdGlvbihPaWQgcHViaWQpCitp
c19zY2hlbWFfcHVibGljYXRpb24oRm9ybV9wZ19wdWJsaWNhdGlvbiBwdWJmb3JtKQogewogCVJl
bGF0aW9uCXB1YnNjaHNyZWw7CiAJU2NhbktleURhdGEgc2NhbmtleTsKIAlTeXNTY2FuRGVzYyBz
Y2FuOwogCUhlYXBUdXBsZQl0dXA7Ci0JYm9vbAkJcmVzdWx0ID0gZmFsc2U7CisJYm9vbAkJcmVz
dWx0OworCisJLyoKKwkgKiAgRk9SIFRBQkxFUyBJTiBTQ0hFTUEgY2Fubm90IGNvZXhpc3Qgd2l0
aCBGT1IgQUxMIFRBQkxFUy4KKwkgKiAgRk9SIFRBQkxFUyBJTiBTQ0hFTUEgY2Fubm90IGNvZXhp
c3Qgd2l0aCBGT1IgQUxMIFNFUVVFTkNFUy4KKwkgKi8KKwlpZiAocHViZm9ybS0+cHViYWxsdGFi
bGVzIHx8IHB1YmZvcm0tPnB1YmFsbHNlcXVlbmNlcykKKwkJcmV0dXJuIGZhbHNlOwogCiAJcHVi
c2Noc3JlbCA9IHRhYmxlX29wZW4oUHVibGljYXRpb25OYW1lc3BhY2VSZWxhdGlvbklkLCBBY2Nl
c3NTaGFyZUxvY2spOwogCVNjYW5LZXlJbml0KCZzY2Fua2V5LAogCQkJCUFudW1fcGdfcHVibGlj
YXRpb25fbmFtZXNwYWNlX3BucHViaWQsCiAJCQkJQlRFcXVhbFN0cmF0ZWd5TnVtYmVyLCBGX09J
REVRLAotCQkJCU9iamVjdElkR2V0RGF0dW0ocHViaWQpKTsKKwkJCQlPYmplY3RJZEdldERhdHVt
KHB1YmZvcm0tPm9pZCkpOwogCiAJc2NhbiA9IHN5c3RhYmxlX2JlZ2luc2NhbihwdWJzY2hzcmVs
LAogCQkJCQkJCSAgUHVibGljYXRpb25OYW1lc3BhY2VQbm5zcGlkUG5wdWJpZEluZGV4SWQsCkBA
IC0zMDIsNDEgKzMwOSwzNiBAQCBpc19zY2hlbWFfcHVibGljYXRpb24oT2lkIHB1YmlkKQogfQog
CiAvKgotICogUmV0dXJucyB0cnVlIGlmIHRoZSBwdWJsaWNhdGlvbiBoYXMgZXhwbGljaXRseSBp
bmNsdWRlZCByZWxhdGlvbiAoaS5lLiwKLSAqIG5vdCBtYXJrZWQgYXMgRVhDRVBUKS4KKyAqIFJl
dHVybnMgdHJ1ZSBpZiB0aGUgcHVibGljYXRpb24gaGFzIGV4cGxpY2l0bHkgaW5jbHVkZWQgcmVs
YXRpb25zIChlLmcuLAorICogRk9SIFRBQkxFKS4KICAqLwogYm9vbAotaXNfdGFibGVfcHVibGlj
YXRpb24oT2lkIHB1YmlkKQoraXNfdGFibGVfcHVibGljYXRpb24oRm9ybV9wZ19wdWJsaWNhdGlv
biBwdWJmb3JtKQogewogCVJlbGF0aW9uCXB1YnJlbHNyZWw7CiAJU2NhbktleURhdGEgc2Nhbmtl
eTsKIAlTeXNTY2FuRGVzYyBzY2FuOwogCUhlYXBUdXBsZQl0dXA7Ci0JYm9vbAkJcmVzdWx0ID0g
ZmFsc2U7CisJYm9vbAkJcmVzdWx0OworCisJLyoKKwkgKiAgRk9SIFRBQkxFIGNhbm5vdCBjb2V4
aXN0IHdpdGggRk9SIEFMTCBUQUJMRVMuCisJICogIEZPUiBUQUJMRSBjYW5ub3QgY29leGlzdCB3
aXRoIEZPUiBBTEwgU0VRVUVOQ0VTLgorCSAqLworCWlmIChwdWJmb3JtLT5wdWJhbGx0YWJsZXMg
fHwgcHViZm9ybS0+cHViYWxsc2VxdWVuY2VzKQorCQlyZXR1cm4gZmFsc2U7CiAKIAlwdWJyZWxz
cmVsID0gdGFibGVfb3BlbihQdWJsaWNhdGlvblJlbFJlbGF0aW9uSWQsIEFjY2Vzc1NoYXJlTG9j
ayk7CiAJU2NhbktleUluaXQoJnNjYW5rZXksCiAJCQkJQW51bV9wZ19wdWJsaWNhdGlvbl9yZWxf
cHJwdWJpZCwKIAkJCQlCVEVxdWFsU3RyYXRlZ3lOdW1iZXIsIEZfT0lERVEsCi0JCQkJT2JqZWN0
SWRHZXREYXR1bShwdWJpZCkpOworCQkJCU9iamVjdElkR2V0RGF0dW0ocHViZm9ybS0+b2lkKSk7
CiAKIAlzY2FuID0gc3lzdGFibGVfYmVnaW5zY2FuKHB1YnJlbHNyZWwsCiAJCQkJCQkJICBQdWJs
aWNhdGlvblJlbFBycHViaWRJbmRleElkLAogCQkJCQkJCSAgdHJ1ZSwgTlVMTCwgMSwgJnNjYW5r
ZXkpOwogCXR1cCA9IHN5c3RhYmxlX2dldG5leHQoc2Nhbik7Ci0JaWYgKEhlYXBUdXBsZUlzVmFs
aWQodHVwKSkKLQl7Ci0JCUZvcm1fcGdfcHVibGljYXRpb25fcmVsIHB1YnJlbDsKLQotCQlwdWJy
ZWwgPSAoRm9ybV9wZ19wdWJsaWNhdGlvbl9yZWwpIEdFVFNUUlVDVCh0dXApOwotCi0JCS8qCi0J
CSAqIEZvciBhbnkgcHVibGljYXRpb24sIHBnX3B1YmxpY2F0aW9uX3JlbCBjb250YWlucyBlaXRo
ZXIgb25seSBFWENFUFQKLQkJICogZW50cmllcyBvciBvbmx5IGV4cGxpY2l0bHkgaW5jbHVkZWQg
dGFibGVzLiBUaGVyZWZvcmUsIGV4YW1pbmluZwotCQkgKiB0aGUgZmlyc3QgdHVwbGUgaXMgc3Vm
ZmljaWVudCB0byBkZXRlcm1pbmUgdGFibGUgaW5jbHVzaW9uLgotCQkgKi8KLQkJcmVzdWx0ID0g
IXB1YnJlbC0+cHJleGNlcHQ7Ci0JfQorCXJlc3VsdCA9IEhlYXBUdXBsZUlzVmFsaWQodHVwKTsK
IAogCXN5c3RhYmxlX2VuZHNjYW4oc2Nhbik7CiAJdGFibGVfY2xvc2UocHVicmVsc3JlbCwgQWNj
ZXNzU2hhcmVMb2NrKTsKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3B1YmxpY2F0
aW9uY21kcy5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvcHVibGljYXRpb25jbWRzLmMKaW5kZXgg
NDQwYWRiMzU2YWQuLjM2ODVjNzExYzQ5IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5k
cy9wdWJsaWNhdGlvbmNtZHMuYworKysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9wdWJsaWNhdGlv
bmNtZHMuYwpAQCAtMTI2MSw3ICsxMjYxLDcgQEAgQWx0ZXJQdWJsaWNhdGlvblRhYmxlcyhBbHRl
clB1YmxpY2F0aW9uU3RtdCAqc3RtdCwgSGVhcFR1cGxlIHR1cCwKIAl7CiAJCVRyYW5zZm9ybVB1
YldoZXJlQ2xhdXNlcyhyZWxzLCBxdWVyeVN0cmluZywgcHViZm9ybS0+cHVidmlhcm9vdCk7CiAK
LQkJcHVibGlzaF9zY2hlbWEgfD0gaXNfc2NoZW1hX3B1YmxpY2F0aW9uKHB1YmlkKTsKKwkJcHVi
bGlzaF9zY2hlbWEgfD0gaXNfc2NoZW1hX3B1YmxpY2F0aW9uKHB1YmZvcm0pOwogCiAJCUNoZWNr
UHViUmVsYXRpb25Db2x1bW5MaXN0KHN0bXQtPnB1Ym5hbWUsIHJlbHMsIHB1Ymxpc2hfc2NoZW1h
LAogCQkJCQkJCQkgICBwdWJmb3JtLT5wdWJ2aWFyb290KTsKQEAgLTE1ODUsOCArMTU4NSw3IEBA
IENoZWNrQWx0ZXJQdWJsaWNhdGlvbihBbHRlclB1YmxpY2F0aW9uU3RtdCAqc3RtdCwgSGVhcFR1
cGxlIHR1cCwKIAkJICogSWYgdGhlIHB1YmxpY2F0aW9uIGFscmVhZHkgY29udGFpbnMgc3BlY2lm
aWMgdGFibGVzIG9yIHNjaGVtYXMsIHdlCiAJCSAqIHByZXZlbnQgc3dpdGNoaW5nIHRvIGEgQUxM
IHN0YXRlLgogCQkgKi8KLQkJaWYgKGlzX3RhYmxlX3B1YmxpY2F0aW9uKHB1YmZvcm0tPm9pZCkg
fHwKLQkJCWlzX3NjaGVtYV9wdWJsaWNhdGlvbihwdWJmb3JtLT5vaWQpKQorCQlpZiAoaXNfdGFi
bGVfcHVibGljYXRpb24ocHViZm9ybSkgfHwgaXNfc2NoZW1hX3B1YmxpY2F0aW9uKHB1YmZvcm0p
KQogCQl7CiAJCQllcmVwb3J0KEVSUk9SLAogCQkJCQllcnJjb2RlKEVSUkNPREVfT0JKRUNUX05P
VF9JTl9QUkVSRVFVSVNJVEVfU1RBVEUpLApAQCAtMjIwMiw3ICsyMjAxLDcgQEAgQWx0ZXJQdWJs
aWNhdGlvbk93bmVyX2ludGVybmFsKFJlbGF0aW9uIHJlbCwgSGVhcFR1cGxlIHR1cCwgT2lkIG5l
d093bmVySWQpCiAJCWlmICghc3VwZXJ1c2VyX2FyZyhuZXdPd25lcklkKSkKIAkJewogCQkJaWYg
KGZvcm0tPnB1YmFsbHRhYmxlcyB8fCBmb3JtLT5wdWJhbGxzZXF1ZW5jZXMgfHwKLQkJCQlpc19z
Y2hlbWFfcHVibGljYXRpb24oZm9ybS0+b2lkKSkKKwkJCQlpc19zY2hlbWFfcHVibGljYXRpb24o
Zm9ybSkpCiAJCQkJZXJlcG9ydChFUlJPUiwKIAkJCQkJCWVycmNvZGUoRVJSQ09ERV9JTlNVRkZJ
Q0lFTlRfUFJJVklMRUdFKSwKIAkJCQkJCWVycm1zZygicGVybWlzc2lvbiBkZW5pZWQgdG8gY2hh
bmdlIG93bmVyIG9mIHB1YmxpY2F0aW9uIFwiJXNcIiIsCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVk
ZS9jYXRhbG9nL3BnX3B1YmxpY2F0aW9uLmggYi9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3B1Ymxp
Y2F0aW9uLmgKaW5kZXggODliNGJiMTRmNjIuLjQ0ODM3MzM2M2ZjIDEwMDY0NAotLS0gYS9zcmMv
aW5jbHVkZS9jYXRhbG9nL3BnX3B1YmxpY2F0aW9uLmgKKysrIGIvc3JjL2luY2x1ZGUvY2F0YWxv
Zy9wZ19wdWJsaWNhdGlvbi5oCkBAIC0xOTQsOCArMTk0LDggQEAgZXh0ZXJuIE9pZAlHZXRUb3BN
b3N0QW5jZXN0b3JJblB1YmxpY2F0aW9uKE9pZCBwdWJvaWQsIExpc3QgKmFuY2VzdG9ycywKIAkJ
CQkJCQkJCQkJaW50ICphbmNlc3Rvcl9sZXZlbCk7CiAKIGV4dGVybiBib29sIGlzX3B1Ymxpc2hh
YmxlX3JlbGF0aW9uKFJlbGF0aW9uIHJlbCk7Ci1leHRlcm4gYm9vbCBpc19zY2hlbWFfcHVibGlj
YXRpb24oT2lkIHB1YmlkKTsKLWV4dGVybiBib29sIGlzX3RhYmxlX3B1YmxpY2F0aW9uKE9pZCBw
dWJpZCk7CitleHRlcm4gYm9vbCBpc19zY2hlbWFfcHVibGljYXRpb24oRm9ybV9wZ19wdWJsaWNh
dGlvbiBwdWJmb3JtKTsKK2V4dGVybiBib29sIGlzX3RhYmxlX3B1YmxpY2F0aW9uKEZvcm1fcGdf
cHVibGljYXRpb24gcHViZm9ybSk7CiBleHRlcm4gYm9vbCBjaGVja19hbmRfZmV0Y2hfY29sdW1u
X2xpc3QoUHVibGljYXRpb24gKnB1YiwgT2lkIHJlbGlkLAogCQkJCQkJCQkJCU1lbW9yeUNvbnRl
eHQgbWN4dCwgQml0bWFwc2V0ICoqY29scyk7CiBleHRlcm4gT2JqZWN0QWRkcmVzcyBwdWJsaWNh
dGlvbl9hZGRfcmVsYXRpb24oT2lkIHB1YmlkLCBQdWJsaWNhdGlvblJlbEluZm8gKnByaSwKLS0g
CjIuNDcuMwoK
--00000000000053dc49064eed013f--