MIME-Version: 1.0
References: 
 <CAApHDvoFSu5zLFvx96aZ5wvL7tcB9aR2hBPCaMPs8D_f0Z7eSw@mail.gmail.com>
 <CAHut+PvGk6H=B72_3YmyyZp8ZW=aYoSsoGrtiBEuMNUHHXXFmQ@mail.gmail.com>
 <883015.1776821474@sss.pgh.pa.us>
In-Reply-To: <883015.1776821474@sss.pgh.pa.us>
From: Peter Smith <smithpb2250@gmail.com>
Date: Wed, 22 Apr 2026 12:20:08 +1000
Message-ID: 
 <CAHut+PsonSOOmpWa+p5pWWf_wks8V7=w9OhHeTP1jA0=oukCjA@mail.gmail.com>
Subject: Re: Get rid of translation strings that only contain punctuation
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
 Amit Kapila <amit.kapila16@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPsonSOOmpWa%2Bp5pWWf_wks8V7%3Dw9OhHeTP1jA0%3DoukCjA%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 22, 2026 at 11:31=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote=
:
>
> Peter Smith <smithpb2250@gmail.com> writes:
> > On Wed, Apr 22, 2026 at 10:30=E2=80=AFAM David Rowley <dgrowleyml@gmail=
.com> wrote:
> >> Should we get rid of these?
>
> > This question overlaps with another thread of mine [1].
> > There, I was told that a punctuation double-quote (")  *should* be tran=
slated.
>
> It should be, but it *has to be translated as part of a coherent
> message*.  As the examples in [1] show, several languages translate
> opening and closing double-quotes differently.  So if you write _("\"")
> there is zero hope of that being usefully translatable.
>
> This all goes back to the translatability guideline about not
> constructing messages out of parts [2].  If you've got a single
> punctuation mark as a separate string, you are violating both the
> letter and the spirit of that guideline, and that has consequences
> for translatability.
>
>                         regards, tom lane
>
> [1] https://www.postgresql.org/message-id/CAHut%2BPui7RaQ8OfJEVn2ry-ykjnG=
c%2B3ujsFmcHDFw9FsXw_tRw%40mail.gmail.com
> [2] https://www.postgresql.org/docs/devel/nls-programmer.html#NLS-GUIDELI=
NES

To my knowledge, we aren't violating that guideline because our
substituted parts aren't words of a sentence; they are quoted names in
a list

e.g.

Case#1: publication "XXX" has a problem

Case#2: the following publications have a problem: "XXX", "YYY", "ZZZ"

~~~

Case#1 is easy. "publication \"%s\" has a problem"
The quotes are part of the message, so they get translated as normal.

Case#2 is more fiddly. "the following publications have a problem: %s"
The substituted quoted-name list is constructed at runtime, but still,
we require those quotes to be translated so that quoted-names in cases
#1 and #2 look the same.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia