Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUJlH-0014wD-03 for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jun 2026 07:42:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wUJlF-00DPeO-3A for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jun 2026 07:42:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUJlF-00DPeF-26 for pgsql-hackers@lists.postgresql.org; Tue, 02 Jun 2026 07:42:05 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wUJlD-00000000oYX-1aOi for pgsql-hackers@lists.postgresql.org; Tue, 02 Jun 2026 07:42:05 +0000 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-91550eceb4cso211531985a.1 for ; Tue, 02 Jun 2026 00:42:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780386121; cv=none; d=google.com; s=arc-20240605; b=kfJje3oyZIzHYEOKES/T3TBIsJNQSRW+YdBh8rAkLBobW0j9d/Kjy7Y8yZP750KUV2 AP+zkz7SyjRTJ3t2bVdd8yQ3SiSCXm7uDg2lv3GhB4B4eHWXHrt/NvptXXGV4VJ6CRXi tZ8zX1YsVpv48nYAno7C75ooIxQ3hFsYs/IBz6VxToz2THkIlJPNlNzMLWFfrmOBVOZq 5UyqwAp8ypCZap2liZpznKg7bnGrcmX3EToTVLfJx5+ZjY2bI0nuCAMt9wLrpeIdzdS6 mWXnHi4XjjXxlSgewPWdX40cU04iVkLPFfaJtfo9OqWQabeZtO0a7tCso9N05hn7+s0X 9HQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=P78lXxxlbDuj7/RyAxXXWuQJBUnfB4e4jEdxssp/I2s=; fh=dNfUl6o4PFQSeLO1SmSOMFQGsNdvXg1FcZldRsZN+QE=; b=WOcWAf3HPEdCxC1+UOrMvbkjohzii0xu4pkaY/DnrfKuVZVcw5G7Qh7n9Tlp+EZDux DZocCpdig4qRm9Sk+Le1AFXLbwzKIFL0SdOveOKlOo6VgYL/7XCDSooxWAS2/EiMaV87 hmhY3kv3mdm0Sm6t5EuxiK5jP4dxfK8ARseH3pmCA6SWUaqIFrsD1HC7YbisHaxQH9QP NsGO28ELyYaSMW2oTHuGIwtEW9rG77xLSJSQT/0/J/E9mFRKM4enYLJrFbVCJnr3ZvC+ qzZLQnmT7lpPYKTVEBZXhExJloZxoRq9VEqXnr7EYqonFuzOd0vDAgzQONA7IxbJqwDB o/vA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780386121; x=1780990921; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P78lXxxlbDuj7/RyAxXXWuQJBUnfB4e4jEdxssp/I2s=; b=jTgXBGqnRxDUWQUQrspKpYZOi5Y7klp5kkQgI4yT8cVhgi2fY4jnHwxAaBhAzq/9JL PZGYkMn8DHa2S3UxNmDHpNkV/peHlywuZs3MmnL/LJeXfFsWykdb0p05j9BmbspOY4Ny 6uaWshULLaJm9S9mv05iv043RayaUnPIR2xVc5ryXjNxvAeHrwJk029e4rycGJ6Yh00h xTGwZTjy1IFLFXw1oUExuYH7TFB2/He1bQwo8LGFotLWokQyMPs8yb5El6SBQUCsENvR 6ScugvfO/mKaemc9rWzViocsjOoHWuhlYte/+bZWsVsuwYqCYa5z5T0eReQ6R5NwWOlg 5WXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780386121; x=1780990921; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P78lXxxlbDuj7/RyAxXXWuQJBUnfB4e4jEdxssp/I2s=; b=JdjMg8iHONwgDPONfP3f09sARdTO5y/B9D8OU2a1YLFOlqxAEmCprVlfsRBaHekDgA NkCIS5jdiQUaGPQDhNGBp6uFxjHp9O1MeDMTj1c8YeLCLvJsCTNDy9qy1IK9v5kIHSZJ 00CyQkVc7suV6qpxg/vUD0q5fkgWLOJ+wUzrmKB50uWzG4ChWfVvOI7cI/xgUM98I4T3 xpFbX7zqidq053FDbtRrWSX047Ztg3uC5qZeqIW10zaKKBur+0sg0vBYish4cRMq3K7G Dp65oottAYu/A9hzscDldH+LUz/avbp+aR7JTEYBuit7yl95t0Mo1j5gs57f0hr/SGkQ 96YA== X-Forwarded-Encrypted: i=1; AFNElJ/8Or6t5O2qNbOpn2yRf/0y1Ut6pI4Wrvuq+9E3c55loXKvvb/59Ia/bGehMpk+hqTsy/9iUHKYLFDJ4rnb@lists.postgresql.org X-Gm-Message-State: AOJu0YxDcsg9HLA17UvuhhNj2nvGoSF0Bs2RoBFUXdC88Ag0P9DL6hT3 Xdswl3Y7uj/5Mw9HpXzFwEn+BGxVEdJbR2Xxvwze8QH/aZAJ+BNIp9rM26tqR+FXXC/AcViCGkS GoH4qw/UMtHp7B6KviSv2C9ro9h0rJk8= X-Gm-Gg: Acq92OFw7ILSlwPivNkgHJfalHaa29wi2hgXYXXMmePxqQUvStySu4+OyqA1a9jxXV+ 7jSu7aHUoTLBeCF6OESYNvPnoKTDIxj5doHQueGSXFkGqheZ4QrBj8fBGuuZdi+UnsxeddjMWSe VtQaTE7iwH/TwVxi5TK9bri0P9LQofigmjg8gpn5qQJABshRWuiH9sv7eKNww6IWXcXeryoxrL7 1aI9fTq2GuoiXbCC4rSsOZ9b6SWeJ3N35izQlKAdWKjHaqqAJ5oek05rjyiRB/+WJqfBxZs9yH1 2LTfJzbwgLFF65Q7hg== X-Received: by 2002:a05:620a:4405:b0:915:3520:2077 with SMTP id af79cd13be357-9153db5a396mr2381099685a.50.1780386121327; Tue, 02 Jun 2026 00:42:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Tue, 2 Jun 2026 17:41:33 +1000 X-Gm-Features: AVHnY4LvDIITrqhKkLy4BX8ZdEKaFsspblujCnX6qcucq_D4M4AyGAM2beQlsVE Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: Nisha Moond , Amit Kapila , vignesh C , shveta malik , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers , shveta malik Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Dilip. I've been thinking more about this new option: conflict_log_destination (enum) = 'log' or 'table' or 'all'. I think it behaves more like a bitmap than an enum. Also, having 'all' as an enum value seems odd to me. IMO, this new option is actually more similar to the 'publish' option from CREATE PUBLICATION. I suggest it might be better to implement this as a *string* option: conflict_log_destination (string), and has allowed values of 'log' and 'table'. e.g. conflict_log_destination = 'log' conflict_log_destination = 'table' conflict_log_destination = 'log, table' Apart from being more intuitive and readable, this way is also future-proof in case some 3rd/4th/etc way of logging is invented -- e.g. the user can define whatever combinations they want instead of being stuck with only "all". Thoughts? ====== Kind Regards, Peter Smith. Fujitsu Australia