MIME-Version: 1.0
References: 
 <CAHut+Pu7LWQB+m9HTf4nf3BQu8bC_-N5c=kuOf=EHHZE_Ctj9Q@mail.gmail.com>
 <airjxKXx7aTG8kfE@alvherre.pgsql>
In-Reply-To: <airjxKXx7aTG8kfE@alvherre.pgsql>
From: Peter Smith <smithpb2250@gmail.com>
Date: Fri, 12 Jun 2026 08:57:33 +1000
Message-ID: 
 <CAHut+Pt2L5jAS2qXDENa2-+0dX2gH+kFWQbfkE3uzCoSRrjGFA@mail.gmail.com>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPt2L5jAS2qXDENa2-%2B0dX2gH%2BkFWQbfkE3uzCoSRrjGFA%40mail.gmail.com>
Precedence: bulk

On Fri, Jun 12, 2026 at 2:44=E2=80=AFAM =C3=81lvaro Herrera <alvherre@kuril=
emu.de> wrote:
>
> On 2026-Apr-24, Peter Smith wrote:
>
> > OK. Including the comma within a larger translated string seems like a
> > better idea.
> [...]
> > Also, why did you choose to implement `last` versus `first` logic?
> > e.g. How about this?
>
> In the end I decided to go with the flow and changed to use "first"
> logic rather than "last".  I also figured that we should change the
> other two places you pointed out at the start of the thread to use the
> same coding style.  Since this is mostly cosmetic, I don't feel
> compelled to back-patch it, and pushed only to master.
>

Thanks for pushing!

> Another place I noticed while looking this over is psql's
> describeOneTableDetails(), per the attached patch.  It's essentially
> more of the same, but arguably different enough that I judged it
> warranted posting before pushing.
>

This additional patch LGTM.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia