public inbox for [email protected]  
help / color / mirror / Atom feed
From: Peter Smith <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
Date: Fri, 10 Apr 2026 17:13:15 +1000
Message-ID: <CAHut+Pt3t_tCYwDStkj5fG4Z=YXrHvPBA7iGdh745QipC5zKeg@mail.gmail.com> (raw)

Hi.

While experimenting with "CREATE PUBLICATION ... FOR ALL TABLES EXCEPT
(TABLE...)" I noticed a small "case" inconsistency.

Background: The \d and \dRp+ command were enhanced in commit fd36606
[1][2] to say what tables are excluded from what publications.

e.g.

# -- describe the publications
# \dRp+ pub1
                                                     Publication pub1
Owner   | All tables | All sequences | Inserts | Updates | Deletes |
Truncates | Generated columns | Via root | Description
----------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+-------------
postgres | t          | f             | t       | t      | t       | t
        | none              | f        |

Except tables:
  "public.t1"
  "public.t2"

# \dRp+ pub2
                                                     Publication pub2
Owner   | All tables | All sequences | Inserts | Updates | Deletes |
Truncates | Generated columns | Via root | Description
----------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+-------------
postgres | f          | f             | t       | t      | t       | t
        | none              | f        |
Tables:
  "public.t2"
  "public.t3"

# -- describe the tables
# \d t1
                Table "public.t1"
Column | Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
a      | integer |           |          |
Except Publications:
  "pub1"

# \d t2
                Table "public.t2"
Column | Type   | Collation | Nullable | Default
--------+---------+-----------+----------+---------
a      | integer |           |          |

Publications:
  "pub2"
Except Publications:
  "pub1"

~~~

Notice that that the describe publication says:
"Tables:" and "Except tables:" (Lowercase "tables")

Notice that the describe table says:
"Publications:" and "Except Publications:"  (Uppercase "Publications")

I think they should use a consistent case:
eg1. (both lowercase) Except tables; Except publications, OR
eg2. (bother uppercase) Except Tables; Except Publications

~~~

I did not yet provide a patch because I was not sure which way
(uppercase/lowercase) is best, so wanted to hear some opinions about
that first.

(I'm expecting that some DOCS examples and/or TESTS for "describe"
will also be impacted).

Thoughts?

======
[1] https://github.com/postgres/postgres/commit/fd366065e06ae953c4f2d973d5c5f0474f3b87b6#diff-cdb325f899...
[2] https://github.com/postgres/postgres/commit/fd366065e06ae953c4f2d973d5c5f0474f3b87b6#diff-cdb325f899...

Kind Regards,
Peter Smith.
Fujitsu Australia





view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
  In-Reply-To: <CAHut+Pt3t_tCYwDStkj5fG4Z=YXrHvPBA7iGdh745QipC5zKeg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox