Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vNeJV-009vB8-1O for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Nov 2025 21:41:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vNeJU-004eqJ-05 for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Nov 2025 21:41:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vNeJT-004eqB-20 for pgsql-hackers@lists.postgresql.org; Mon, 24 Nov 2025 21:41:36 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vNeJR-001GyK-1Q for pgsql-hackers@lists.postgresql.org; Mon, 24 Nov 2025 21:41:35 +0000 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-8b2d6df99c5so640574885a.1 for ; Mon, 24 Nov 2025 13:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764020492; x=1764625292; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=n8EEim+XXWGohJfEouvTXaJlCJnpbXj1A8DY0iUXelk=; b=UzIb4fAPquMmo6eiOOEoixslbcN8PDAhmT7WGaWnpvihW8XTQtPMsWCCrlaVFTJknz yR0exFPzEkGE3FSKecKjlwV1ES8KTQEPXRtLu05SiBrDFOhTS5Gql7D9mF3xsgk7+Wlo Dm0rPtagAAjJJMl1ZcIc5s1jvyxIuYGHqaulDDsd0AnkRZG67zXz5nJsmumClahd1X1i 7fMERlnABpRw5e/b2bkQXEOUpVSkzS0oGmafKCihZ6v2r7GLJsyA4ARQ7yCcRZziHkf/ B6I1fDGO6mD8+Fd6biOHv7pWQ5wBP9sktmw8vqeLi5+/EANSmBqLedYzBYvPFwteL6ue MaYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764020492; x=1764625292; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n8EEim+XXWGohJfEouvTXaJlCJnpbXj1A8DY0iUXelk=; b=C8XMgN/LIaZJnYXZvXcpvA72I2385fDJjVD7FI5/IugeDYd1/fa1K5sWoDYrNBe4qk USs6V8V5ms3h+KDKZ4WgLLMk8v1izcVCv1cX52Ptx0Aowt3Y8tdF7O8l5xLcnyyzd0I7 3bRslJk9vNTW2uBqZbjNG+At1YOYOIO9ZuXZ3n4Kl5nIePqMWhA6P2S/QIFdIoTnVh0W d3+fF3LYLEso7jOIUjqbvUcEPfRWdULT84lbj9riszTl0bpq308Zo2UvOqtUC3V5q5BP OtyPXo+5cKvilJ2SKv92G4qY4kQs7aGIt4ODGKf4uA42VwLUjEUYgWZz2ah4KzdMiFt/ yLtw== X-Forwarded-Encrypted: i=1; AJvYcCUWU28TYxI3Mw3rvEQGIz+/tbk18c4FfiCZst/oHjY1p98kdPPr/DyiuGHTlhfcLK+aVl43Gq1xIoh6zuOc@lists.postgresql.org X-Gm-Message-State: AOJu0YyGfRbGBdswf73kr+rpxkoEmXCEMgpDH5fXDI5UqNNA8IaFeD/C 3zfBaG1tBzu7w/mwz3cM2cd0vhL8VP05JPp1ayfEe8nuv/RUAbnPc7tyPmPECz4p/AVZ/0aVJBf sBA6IisfKKIls1lY+T3WDITEGYhqo2mg= X-Gm-Gg: ASbGncv8z/WNKD2JHHPffqGgsZONE+NwSZJbQTsf7ruEx1t+1pUdNsfHbkp5xtA1XMT Zz7yhCV7v14jnjc4pJ0oVwJxjCl5jBNmxOBbd8Kw3Dawh+pfUMVLe5Q6ynTa3oqyUK9RXasAzuK MA8o8dIDbsgfTMrvkvxYetyHhC30SAI+4BlAkWjc/xICjjT9RQXX1Q5UB5uDrid+QZPq5orZgqr sFI7PB55HtimV5dmPPMaKb1WJKtRFT59swmx6MAvFAEHVV6+gZBsPLWhjTn3VZYkBh+AmdCPaRm HM5fhqxr4XayeshJZy+TvQD5wtglqQ== X-Google-Smtp-Source: AGHT+IG09Ibce4j9fhVwXFRj89YMPDz2EJ9ek8iRpGooApwi33wLrglYVX+DvsQ7b9jm+bjSzU+qCcqrONrLxVQoM5M= X-Received: by 2002:a05:622a:181b:b0:4ed:b4f3:56e1 with SMTP id d75a77b69052e-4ee58872a3amr165665781cf.34.1764020491888; Mon, 24 Nov 2025 13:41:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Tue, 25 Nov 2025 08:41:05 +1100 X-Gm-Features: AWmQ_bl-36er5NCd4mmPnKfrZjx9VEnLMo4_oMGvnRMoWBn274y4Am-htRS1dR0 Message-ID: Subject: Re: Skipping schema changes in publication To: Shlok Kyal Cc: vignesh C , Amit Kapila , "Zhijie Hou (Fujitsu)" , YeXiu <1518981153@qq.com>, Ian Lawrence Barwick , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Shlok. I checked the latest v28-0004 "EXCEPT (col-list)" patch. I have no code review comments, but I do have one syntax question. ====== The result of the current patch proposed syntax is like: CREATE PUBLICATION pubname FOR TABLE tabname EXCEPT (col1, col2, col3) ALTER PUBLICATION pubname ADD TABLE tabname EXCEPT (col1, col2, col3) ~~ In the previous patch v28-0003 (FOR ALL TABLES EXCEPT [TABLE]), I thought the optional noise-word TABLE did not have any user benefit because TABLE was already obvious. OTOH, here in patch v28-0004, it might be helpful to have an *optional* [COLUMN] part. e.g., I felt "EXCEPT [COLUMN]" would improve the readability of these commands. Compare: CREATE PUBLICATION pubname FOR TABLE tabname EXCEPT (col1, col2, col3) CREATE PUBLICATION pubname FOR TABLE tabname EXCEPT COLUMN (col1, col2, col3) Compare: ALTER PUBLICATION pubname ADD TABLE tabname EXCEPT (col1, col2, col3) ALTER PUBLICATION pubname ADD TABLE tabname EXCEPT COLUMN (col1, col2, col3) This is similar to the optional "[COLUMN]" keyword used here [1]. Thoughts? ====== [1] https://www.postgresql.org/docs/devel/sql-altertable.html Kind Regards, Peter Smith. Fujitsu Australia