MIME-Version: 1.0
References: <CAHut+Pu1puO00C-OhgLnAcECzww8MB3Q8DCsvx0cZWHRfs4gBQ@mail.gmail.com>
 <CAHut+PuZ-SPA87FqhyW9zXnwVu4pPo8pT073qBZAhcFTetWYfg@mail.gmail.com>
 <785CF596-5626-4ECB-AC3D-13FB266D69D0@gmail.com> <CAHut+PurJVXBJdzTQvq1YWcSQjsgjQcpdK43SOERyfYkpibjNQ@mail.gmail.com>
 <8048C321-FECA-4ECD-B022-54D842151B42@gmail.com>
In-Reply-To: <8048C321-FECA-4ECD-B022-54D842151B42@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Thu, 22 Jan 2026 08:08:31 +1100
Message-ID: <CAHut+PtSGPwNgUJYA94WC7Osw4us9Dou=7T_RmxZuS1s4LsGDw@mail.gmail.com>
Subject: Re: Fix how some lists are displayed by psql \d+
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHut%2BPtSGPwNgUJYA94WC7Osw4us9Dou%3D7T_RmxZuS1s4LsGDw%40mail.gmail.com>
Precedence: bulk

On Wed, Jan 21, 2026 at 7:30=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:
>
>
>
> > On Jan 21, 2026, at 16:22, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > On Wed, Jan 21, 2026 at 7:05=E2=80=AFPM Chao Li <li.evan.chao@gmail.com=
> wrote:
> >>
> >>
> >>
> >>> On Jan 21, 2026, at 10:58, Peter Smith <smithpb2250@gmail.com> wrote:
> >>>
> >>> A rebase was needed for some more test expected output changes.
> >>>
> >>> PSA v2.
> >>>
> >>> =3D=3D=3D=3D=3D=3D
> >>> Kind Regards,
> >>> Peter Smith.
> >>> Fujitsu Australia
> >>> <v2-0002-Fix-to-make-psql-d-lists-of-inherits-look-same-as.patch><v2-=
0001-Fix-to-make-psql-d-lists-of-partitions-look-same-.patch>
> >>
> >> I still see some difference:
> >> ```
> >> evantest=3D# \d+ p_test;
> >>                                     Partitioned table "public.p_test"
> >>  Column  |  Type   | Collation | Nullable | Default | Storage  | Compr=
ession | Stats target | Description
> >> ----------+---------+-----------+----------+---------+----------+-----=
--------+--------------+-------------
> >> id       | integer |           |          |         | plain    |      =
       |              |
> >> username | text    |           |          |         | extended |      =
       |              |
> >> category | text    |           |          |         | extended |      =
       |              |
> >> Partition key: LIST (category)
> >> Indexes:
> >>    "idx_p_test_id" btree (id)
> >> Partitions:
> >>    p_test_v1 FOR VALUES IN ('A')
> >>    p_test_v2 FOR VALUES IN ('B')
> >> ```
> >>
> >> The index name is quoted, but the partition names are not.
> >>
> >
> > AFAICT
> > Indexes are quoted
> > Constraints are quoted
> > Publications are also quoted
> >
> > Partitions are NOT quoted
> > Inherits are NOT quoted
> >
> > ~
> >
> > Please confirm --- So, you are expecting that Partitions and Child
> > tables should also be quoted, so that everything looks the same?
> >
> > This is scope creep from the original intent of this thread, so I will
> > look at doing this in a separate patch 0003.
> >
> > =3D=3D=3D=3D=3D=3D
> > Kind Regards
> > Peter Smith.
> > Fujitsu Australia
>
> Actually I don=E2=80=99t know the rule, which should be quoted and which =
should not. Is the inconstancy a blocker?
>
> So, I was just pointing out the inconsistency, and I want to hear a clari=
fication from someone.
>

OK. I feel that the "Partitions" and "Child tables" + "Interits" might
be the odd ones out here, just as those were the odd ones out re the
list indentation logic.

But I will hold off on adding quotes for them until I hear some
committer advice that it would be a worthwhile change.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia