MIME-Version: 1.0
References: 
 <OS7PR01MB119648846BA926C096CE016B6EAE3A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAHut+Pt4Tn1bQYCsYeUt_gtcSB-KOTtRB70SLghkpsjfKGsm7w@mail.gmail.com>
 <OS7PR01MB119642CFE4F4DCF7FBBD040BBEAE0A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAHut+Pu-nxNice547eGEW2O3hdRcFbPYWF4HiqktZO19X3Ah-g@mail.gmail.com>
 <OS7PR01MB11964628A74081DFCA442CBADEAE1A@OS7PR01MB11964.jpnprd01.prod.outlook.com>
 <CAHut+PuuOKKW2oDT0Z8q+UXsiteS67j6G6075FC3aAxeR0cxHQ@mail.gmail.com>
 <OSCPR01MB14966FC50CFB457938763AE09F5EEA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <OSCPR01MB14966B98E5119EBB261024ED2F5EEA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <aOctHMnSZcREh0BR@paquier.xyz>
 <OSCPR01MB1496614832F8014EC16FB78D2F5EEA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <aOc7_JGErxvqBLMP@paquier.xyz>
 <OSCPR01MB14966EC12277712131EB8EDF1F5EEA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <OS7PR01MB11964C8FE9CDCC0F4C9110988EAEEA@OS7PR01MB11964.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <OS7PR01MB11964C8FE9CDCC0F4C9110988EAEEA@OS7PR01MB11964.jpnprd01.prod.outlook.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Fri, 10 Oct 2025 09:56:53 +1100
Message-ID: 
 <CAHut+Pu+SMWCCpbwJqq8bqjmD=oA30vnzL1Ey07cik_14KuhDg@mail.gmail.com>
Subject: Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP
 DATABASE
To: "Aya Iwata (Fujitsu)" <iwata.aya@fujitsu.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000380f770640c1b914"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPu%2BSMWCCpbwJqq8bqjmD%3DoA30vnzL1Ey07cik_14KuhDg%40mail.gmail.com>
Precedence: bulk

--000000000000380f770640c1b914
Content-Type: text/plain; charset="UTF-8"

Hi Iwata-San,

Some v5 comments.

======
doc/src/sgml/bgworker.sgml

1.
+    <varlistentry>
+     <term><literal>BGWORKER_EXIT_AT_DATABASE_CHANGE</literal></term>
+     <listitem>
+      <para>
+       <indexterm><primary>BGWORKER_EXIT_AT_DATABASE_CHANGE</primary></indexterm>
+       Requests termination of the background worker when the database it is
+       connected to undergoes significant changes. The postmaster will send a
+       termination signal to the background worker when any of the following
+       commands are executed: <command>DROP DATABASE</command>,
+       <command>ALTER DATABASE RENAME TO</command>, or
+       <command>ALTER DATABASE SET TABLESPACE</command>.
+       When <command>CREATE DATABASE TEMPLATE</command> command is executed,
+       background workers which connected to target template database
are terminated.
+       If <literal>BGWORKER_SHMEM_ACCESS</literal> and
+       <literal>BGWORKER_BACKEND_DATABASE_CONNECTION</literal> are not using,
+       nothing happens.
+      </para>
+     </listitem>
+    </varlistentry>
+

1a.
The newly added part in v5 needs some brush-up.

SUGGESTION:

<para>
 <indexterm><primary>BGWORKER_EXIT_AT_DATABASE_CHANGE</primary></indexterm>
 Requests termination of the background worker when its connected database
 undergoes significant changes. The postmaster sends a termination signal
 when any of these commands affect the worker's database:
 <command>DROP DATABASE</command>,
 <command>ALTER DATABASE RENAME TO</command>,
 <command>ALTER DATABASE SET TABLESPACE</command>, or
 <command>CREATE DATABASE</command> (when the worker is connected to the
 template database).
 This flag requires both <literal>BGWORKER_SHMEM_ACCESS</literal> and
 <literal>BGWORKER_BACKEND_DATABASE_CONNECTION</literal>.
</para>

~

1b.
Elsewhere on this docs page, there are detailed discussions about
process termination (e.g. search "terminate"), as well as referring to
the function TerminateBackgroundWorker().

You only documented the new flag, but do we also need to make changes
in the rest of this page to mention the new way for process
termination?

======
src/backend/postmaster/bgworker.c

TerminateBackgroundWorkersByOid:

2.
+/*
+ * Cancel background workers.
+ */
+void
+TerminateBackgroundWorkersByOid(Oid databaseId)

Let's also remove that word "Cancel" from the function comment and add
some more details.

SUGGESTION:
Terminate all background workers connected to the given database, if
they had requested it.

~~~

3.
+ /*
+ * Iterate through slots, looking for workers
+ * who connects to the given database.
+ */

"workers who connects" (??)

SUGGESTION
Iterate through slots, looking for workers connected to the given database.

======
src/backend/storage/ipc/procarray.c

4.
+ /*
+ * Terminate all background workers for this database, if
+ * they had requested it (BGWORKER_EXIT_AT_DATABASE_DROP)
+ */
+ TerminateBackgroundWorkersByOid(databaseId);
+

The comment is out-of-date now, because the flag name was changed to
BGWORKER_EXIT_AT_DATABASE_CHANGE.

======
src/include/postmaster/bgworker.h

5.
+/* Cancel background workers. */
+extern void TerminateBackgroundWorkersByOid(Oid databaseId);

There is already a commented extern for the
TerminateBackgroundWorker() function. IMO, just put this extern
alongside that one. You don't need a new comment.

~~~

6. The header comment in this file refers to the
TerminateBackgroundWorker() function. Probably, you need to check that
carefully to see if this new function should also be mentioned there.

======

FYI, I attached a v5 top-up diff for (some of) my above review
comments in case it helps.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

--000000000000380f770640c1b914
Content-Type: application/octet-stream; name="PS_v5_topup.diff"
Content-Disposition: attachment; filename="PS_v5_topup.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_mgk0inib0>
X-Attachment-Id: f_mgk0inib0

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9iZ3dvcmtlci5zZ21sIGIvZG9jL3NyYy9zZ21sL2Jn
d29ya2VyLnNnbWwKaW5kZXggMDFjZWIzOC4uZDZlMzdiNSAxMDA2NDQKLS0tIGEvZG9jL3NyYy9z
Z21sL2Jnd29ya2VyLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2Jnd29ya2VyLnNnbWwKQEAgLTEx
MywxNyArMTEzLDE2IEBAIHR5cGVkZWYgc3RydWN0IEJhY2tncm91bmRXb3JrZXIKICAgICAgPGxp
c3RpdGVtPgogICAgICAgPHBhcmE+CiAgICAgICAgPGluZGV4dGVybT48cHJpbWFyeT5CR1dPUktF
Ul9FWElUX0FUX0RBVEFCQVNFX0NIQU5HRTwvcHJpbWFyeT48L2luZGV4dGVybT4KLSAgICAgICBS
ZXF1ZXN0cyB0ZXJtaW5hdGlvbiBvZiB0aGUgYmFja2dyb3VuZCB3b3JrZXIgd2hlbiB0aGUgZGF0
YWJhc2UgaXQgaXMKLSAgICAgICBjb25uZWN0ZWQgdG8gdW5kZXJnb2VzIHNpZ25pZmljYW50IGNo
YW5nZXMuIFRoZSBwb3N0bWFzdGVyIHdpbGwgc2VuZCBhCi0gICAgICAgdGVybWluYXRpb24gc2ln
bmFsIHRvIHRoZSBiYWNrZ3JvdW5kIHdvcmtlciB3aGVuIGFueSBvZiB0aGUgZm9sbG93aW5nCi0g
ICAgICAgY29tbWFuZHMgYXJlIGV4ZWN1dGVkOiA8Y29tbWFuZD5EUk9QIERBVEFCQVNFPC9jb21t
YW5kPiwKLSAgICAgICA8Y29tbWFuZD5BTFRFUiBEQVRBQkFTRSBSRU5BTUUgVE88L2NvbW1hbmQ+
LCBvcgotICAgICAgIDxjb21tYW5kPkFMVEVSIERBVEFCQVNFIFNFVCBUQUJMRVNQQUNFPC9jb21t
YW5kPi4KLSAgICAgICBXaGVuIDxjb21tYW5kPkNSRUFURSBEQVRBQkFTRSBURU1QTEFURTwvY29t
bWFuZD4gY29tbWFuZCBpcyBleGVjdXRlZCwKLSAgICAgICBiYWNrZ3JvdW5kIHdvcmtlcnMgd2hp
Y2ggY29ubmVjdGVkIHRvIHRhcmdldCB0ZW1wbGF0ZSBkYXRhYmFzZSBhcmUgdGVybWluYXRlZC4K
LSAgICAgICBJZiA8bGl0ZXJhbD5CR1dPUktFUl9TSE1FTV9BQ0NFU1M8L2xpdGVyYWw+IGFuZAot
ICAgICAgIDxsaXRlcmFsPkJHV09SS0VSX0JBQ0tFTkRfREFUQUJBU0VfQ09OTkVDVElPTjwvbGl0
ZXJhbD4gYXJlIG5vdCB1c2luZywKLSAgICAgICBub3RoaW5nIGhhcHBlbnMuCisgICAgICAgUmVx
dWVzdHMgdGVybWluYXRpb24gb2YgdGhlIGJhY2tncm91bmQgd29ya2VyIHdoZW4gaXRzIGNvbm5l
Y3RlZCBkYXRhYmFzZQorICAgICAgIHVuZGVyZ29lcyBzaWduaWZpY2FudCBjaGFuZ2VzLiBUaGUg
cG9zdG1hc3RlciBzZW5kcyBhIHRlcm1pbmF0aW9uIHNpZ25hbAorICAgICAgIHdoZW4gYW55IG9m
IHRoZXNlIGNvbW1hbmRzIGFmZmVjdCB0aGUgd29ya2VyJ3MgZGF0YWJhc2U6CisgICAgICAgPGNv
bW1hbmQ+RFJPUCBEQVRBQkFTRTwvY29tbWFuZD4sCisgICAgICAgPGNvbW1hbmQ+QUxURVIgREFU
QUJBU0UgUkVOQU1FIFRPPC9jb21tYW5kPiwKKyAgICAgICA8Y29tbWFuZD5BTFRFUiBEQVRBQkFT
RSBTRVQgVEFCTEVTUEFDRTwvY29tbWFuZD4sIG9yCisgICAgICAgPGNvbW1hbmQ+Q1JFQVRFIERB
VEFCQVNFPC9jb21tYW5kPiAod2hlbiB0aGUgd29ya2VyIGlzIGNvbm5lY3RlZCB0byB0aGUKKyAg
ICAgICB0ZW1wbGF0ZSBkYXRhYmFzZSkuCisgICAgICAgVGhpcyBmbGFnIHJlcXVpcmVzIGJvdGgg
PGxpdGVyYWw+QkdXT1JLRVJfU0hNRU1fQUNDRVNTPC9saXRlcmFsPiBhbmQKKyAgICAgICA8bGl0
ZXJhbD5CR1dPUktFUl9CQUNLRU5EX0RBVEFCQVNFX0NPTk5FQ1RJT048L2xpdGVyYWw+LgogICAg
ICAgPC9wYXJhPgogICAgICA8L2xpc3RpdGVtPgogICAgIDwvdmFybGlzdGVudHJ5PgpkaWZmIC0t
Z2l0IGEvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9iZ3dvcmtlci5jIGIvc3JjL2JhY2tlbmQvcG9z
dG1hc3Rlci9iZ3dvcmtlci5jCmluZGV4IDdhYjQ4YzIuLmUwY2ZkYmYgMTAwNjQ0Ci0tLSBhL3Ny
Yy9iYWNrZW5kL3Bvc3RtYXN0ZXIvYmd3b3JrZXIuYworKysgYi9zcmMvYmFja2VuZC9wb3N0bWFz
dGVyL2Jnd29ya2VyLmMKQEAgLTE0MDAsNyArMTQwMCw4IEBAIEdldEJhY2tncm91bmRXb3JrZXJU
eXBlQnlQaWQocGlkX3QgcGlkKQogCiAKIC8qCi0gKiBDYW5jZWwgYmFja2dyb3VuZCB3b3JrZXJz
LgorICogVGVybWluYXRlIGFsbCBiYWNrZ3JvdW5kIHdvcmtlcnMgY29ubmVjdGVkIHRvIHRoZSBn
aXZlbiBkYXRhYmFzZSwgaWYgdGhleQorICogaGFkIHJlcXVlc3RlZCBpdC4KICAqLwogdm9pZAog
VGVybWluYXRlQmFja2dyb3VuZFdvcmtlcnNCeU9pZChPaWQgZGF0YWJhc2VJZCkKQEAgLTE0MTAs
OCArMTQxMSw4IEBAIFRlcm1pbmF0ZUJhY2tncm91bmRXb3JrZXJzQnlPaWQoT2lkIGRhdGFiYXNl
SWQpCiAJTFdMb2NrQWNxdWlyZShCYWNrZ3JvdW5kV29ya2VyTG9jaywgTFdfRVhDTFVTSVZFKTsK
IAogCS8qCi0JICogSXRlcmF0ZSB0aHJvdWdoIHNsb3RzLCBsb29raW5nIGZvciB3b3JrZXJzCi0J
ICogd2hvIGNvbm5lY3RzIHRvIHRoZSBnaXZlbiBkYXRhYmFzZS4KKwkgKiBJdGVyYXRlIHRocm91
Z2ggc2xvdHMsIGxvb2tpbmcgZm9yIHdvcmtlcnMgY29ubmVjdGVkIHRvIHRoZSBnaXZlbgorCSAq
IGRhdGFiYXNlLgogCSAqLwogCWZvciAoaW50IHNsb3RubyA9IDA7IHNsb3RubyA8IEJhY2tncm91
bmRXb3JrZXJEYXRhLT50b3RhbF9zbG90czsgKytzbG90bm8pCiAJewpkaWZmIC0tZ2l0IGEvc3Jj
L2JhY2tlbmQvc3RvcmFnZS9pcGMvcHJvY2FycmF5LmMgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2lw
Yy9wcm9jYXJyYXkuYwppbmRleCBmNjEyZTc3Li4xZWQ2NDFkIDEwMDY0NAotLS0gYS9zcmMvYmFj
a2VuZC9zdG9yYWdlL2lwYy9wcm9jYXJyYXkuYworKysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2lw
Yy9wcm9jYXJyYXkuYwpAQCAtMzc3MSw3ICszNzcxLDcgQEAgQ291bnRPdGhlckRCQmFja2VuZHMo
T2lkIGRhdGFiYXNlSWQsIGludCAqbmJhY2tlbmRzLCBpbnQgKm5wcmVwYXJlZCkKIAogCQkvKgog
CQkgKiBUZXJtaW5hdGUgYWxsIGJhY2tncm91bmQgd29ya2VycyBmb3IgdGhpcyBkYXRhYmFzZSwg
aWYKLQkJICogdGhleSBoYWQgcmVxdWVzdGVkIGl0IChCR1dPUktFUl9FWElUX0FUX0RBVEFCQVNF
X0RST1ApCisJCSAqIHRoZXkgaGFkIHJlcXVlc3RlZCBpdCAoQkdXT1JLRVJfRVhJVF9BVF9EQVRB
QkFTRV9DSEFOR0UpCiAJCSAqLwogCQlUZXJtaW5hdGVCYWNrZ3JvdW5kV29ya2Vyc0J5T2lkKGRh
dGFiYXNlSWQpOwogCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9wb3N0bWFzdGVyL2Jnd29ya2Vy
LmggYi9zcmMvaW5jbHVkZS9wb3N0bWFzdGVyL2Jnd29ya2VyLmgKaW5kZXggNTc3NDFkNy4uM2Ey
ZmMzNSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvcG9zdG1hc3Rlci9iZ3dvcmtlci5oCisrKyBi
L3NyYy9pbmNsdWRlL3Bvc3RtYXN0ZXIvYmd3b3JrZXIuaApAQCAtMTM0LDYgKzEzNCw3IEBAIGV4
dGVybiBjb25zdCBjaGFyICpHZXRCYWNrZ3JvdW5kV29ya2VyVHlwZUJ5UGlkKHBpZF90IHBpZCk7
CiAKIC8qIFRlcm1pbmF0ZSBhIGJnd29ya2VyICovCiBleHRlcm4gdm9pZCBUZXJtaW5hdGVCYWNr
Z3JvdW5kV29ya2VyKEJhY2tncm91bmRXb3JrZXJIYW5kbGUgKmhhbmRsZSk7CitleHRlcm4gdm9p
ZCBUZXJtaW5hdGVCYWNrZ3JvdW5kV29ya2Vyc0J5T2lkKE9pZCBkYXRhYmFzZUlkKTsKIAogLyog
VGhpcyBpcyB2YWxpZCBpbiBhIHJ1bm5pbmcgd29ya2VyICovCiBleHRlcm4gUEdETExJTVBPUlQg
QmFja2dyb3VuZFdvcmtlciAqTXlCZ3dvcmtlckVudHJ5OwpAQCAtMTY3LDcgKzE2OCw0IEBAIGV4
dGVybiB2b2lkIEJhY2tncm91bmRXb3JrZXJJbml0aWFsaXplQ29ubmVjdGlvbkJ5T2lkKE9pZCBk
Ym9pZCwgT2lkIHVzZXJvaWQsIHVpCiBleHRlcm4gdm9pZCBCYWNrZ3JvdW5kV29ya2VyQmxvY2tT
aWduYWxzKHZvaWQpOwogZXh0ZXJuIHZvaWQgQmFja2dyb3VuZFdvcmtlclVuYmxvY2tTaWduYWxz
KHZvaWQpOwogCi0vKiBDYW5jZWwgYmFja2dyb3VuZCB3b3JrZXJzLiAqLwotZXh0ZXJuIHZvaWQg
VGVybWluYXRlQmFja2dyb3VuZFdvcmtlcnNCeU9pZChPaWQgZGF0YWJhc2VJZCk7Ci0KICNlbmRp
ZgkJCQkJCQkvKiBCR1dPUktFUl9IICovCg==
--000000000000380f770640c1b914--