MIME-Version: 1.0
References: 
 <CAHut+PuD2pGMEKmk2dFA+guzxBEOas5+=LAm5E+SM2LU35KOnQ@mail.gmail.com>
 <aeniYoOwCQmtWtQW@alvherre.pgsql>
In-Reply-To: <aeniYoOwCQmtWtQW@alvherre.pgsql>
From: Peter Smith <smithpb2250@gmail.com>
Date: Fri, 24 Apr 2026 13:10:03 +1000
Message-ID: 
 <CAHut+Pu7LWQB+m9HTf4nf3BQu8bC_-N5c=kuOf=EHHZE_Ctj9Q@mail.gmail.com>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000007ec96306502c1b58"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPu7LWQB%2Bm9HTf4nf3BQu8bC_-N5c%3DkuOf%3DEHHZE_Ctj9Q%40mail.gmail.com>
Precedence: bulk

--0000000000007ec96306502c1b58
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 23, 2026 at 7:25=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kuril=
emu.de> wrote:
>
> On 2026-Apr-23, Peter Smith wrote:
>
> > v2 removes translation of the comma separator, due to the discussion
> > over at [1].
>
> Hmm, at least Japanese uses a different character for commas, and
> apparently French likes to add a space, so I think this is a bad move.
> I think we could handle these things by including the comma together
> with the literal in each element of the list being constructed, as in
> the attached.
>

OK. Including the comma within a larger translated string seems like a
better idea.

Since you now have the list `length`, I wondered why not simplify
further to use list_nth indexing? Then you can remove
`foreach_current_index` and `lc`.

PSA.

~~~~

Also, why did you choose to implement `last` versus `first` logic?
e.g. How about this?

------
GetPublicationsStr(List *publications, StringInfo dest, bool quote_literal)
{
    ListCell   *lc;
    bool        first =3D true;

    Assert(publications !=3D NIL);

    foreach(lc, publications)
    {
        char       *pubname =3D strVal(lfirst(lc));

        if (quote_literal)
        {
            if (!first)
                appendStringInfoString(dest, ", ");
            appendStringInfoString(dest, quote_literal_cstr(pubname));
        }
        else
        {
            if (first)
                appendStringInfo(dest, _("\"%s\""), pubname);
            else
                appendStringInfo(dest, _(", \"%s\""), pubname);
        }

        first =3D false;
    }
}
------

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia

--0000000000007ec96306502c1b58
Content-Type: application/octet-stream;
	name="0001-change-translation-markers-in-GetPublicationStr-PS.diff"
Content-Disposition: attachment;
	filename="0001-change-translation-markers-in-GetPublicationStr-PS.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_mocbzp4l0>
X-Attachment-Id: f_mocbzp4l0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvcGdfc3Vic2NyaXB0aW9uLmMgYi9zcmMv
YmFja2VuZC9jYXRhbG9nL3BnX3N1YnNjcmlwdGlvbi5jCmluZGV4IDVhNzMzNTg1NDkwLi43NzQ5
ZWMzODBkZSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9wZ19zdWJzY3JpcHRpb24u
YworKysgYi9zcmMvYmFja2VuZC9jYXRhbG9nL3BnX3N1YnNjcmlwdGlvbi5jCkBAIC00MSwzMSAr
NDEsMzUgQEAgc3RhdGljIExpc3QgKnRleHRhcnJheV90b19zdHJpbmdsaXN0KEFycmF5VHlwZSAq
dGV4dGFycmF5KTsKIAogLyoKICAqIEFkZCBhIGNvbW1hLXNlcGFyYXRlZCBsaXN0IG9mIHB1Ymxp
Y2F0aW9uIG5hbWVzIHRvIHRoZSAnZGVzdCcgc3RyaW5nLgorICoKKyAqIElmIHF1b3RlX2xpdGVy
YWwgaXMgdHJ1ZSwgdGhlIHJldHVybmVkIGxpc3QgY2FuIGJlIHVzZWQgdG8gY29uc3RydWN0IGFu
IFNRTAorICogY29tbWFuZCwgdGh1cyBubyB0cmFuc2xhdGlvbiBpcyBhcHBsaWVkLiAgT3RoZXJ3
aXNlLCB0aGUgc3RyaW5nIGNhbiBiZSB1c2VkCisgKiB0byBjcmVhdGUgYSB1c2VyLWZhY2luZyBt
ZXNzYWdlLCBzbyB0cmFuc2xhdGFibGUgcXVvdGUgbWFya3MgYXJlIGFkZGVkLgogICovCiB2b2lk
CiBHZXRQdWJsaWNhdGlvbnNTdHIoTGlzdCAqcHVibGljYXRpb25zLCBTdHJpbmdJbmZvIGRlc3Qs
IGJvb2wgcXVvdGVfbGl0ZXJhbCkKIHsKLQlMaXN0Q2VsbCAgICpsYzsKLQlib29sCQlmaXJzdCA9
IHRydWU7CisJaW50CQkJbGVuZ3RoID0gbGlzdF9sZW5ndGgocHVibGljYXRpb25zKTsKIAogCUFz
c2VydChwdWJsaWNhdGlvbnMgIT0gTklMKTsKIAotCWZvcmVhY2gobGMsIHB1YmxpY2F0aW9ucykK
Kwlmb3IgKGludCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKQogCXsKLQkJY2hhcgkgICAqcHVibmFt
ZSA9IHN0clZhbChsZmlyc3QobGMpKTsKLQotCQlpZiAoZmlyc3QpCi0JCQlmaXJzdCA9IGZhbHNl
OwotCQllbHNlCi0JCQlhcHBlbmRTdHJpbmdJbmZvU3RyaW5nKGRlc3QsICIsICIpOworCQljaGFy
CSAgICpwdWJuYW1lID0gc3RyVmFsKGxpc3RfbnRoKHB1YmxpY2F0aW9ucywgaSkpOworCQlib29s
CQlsYXN0ID0gaSA+PSBsZW5ndGggLSAxOwogCiAJCWlmIChxdW90ZV9saXRlcmFsKQorCQl7CiAJ
CQlhcHBlbmRTdHJpbmdJbmZvU3RyaW5nKGRlc3QsIHF1b3RlX2xpdGVyYWxfY3N0cihwdWJuYW1l
KSk7CisJCQlpZiAoIWxhc3QpCisJCQkJYXBwZW5kU3RyaW5nSW5mb1N0cmluZyhkZXN0LCAiLCAi
KTsKKwkJfQogCQllbHNlCiAJCXsKLQkJCWFwcGVuZFN0cmluZ0luZm9DaGFyKGRlc3QsICciJyk7
Ci0JCQlhcHBlbmRTdHJpbmdJbmZvU3RyaW5nKGRlc3QsIHB1Ym5hbWUpOwotCQkJYXBwZW5kU3Ry
aW5nSW5mb0NoYXIoZGVzdCwgJyInKTsKKwkJCWlmIChsYXN0KQorCQkJCWFwcGVuZFN0cmluZ0lu
Zm8oZGVzdCwgXygiXCIlc1wiIiksIHB1Ym5hbWUpOworCQkJZWxzZQorCQkJCWFwcGVuZFN0cmlu
Z0luZm8oZGVzdCwgXygiXCIlc1wiLCAiKSwgcHVibmFtZSk7CiAJCX0KIAl9CiB9Cg==
--0000000000007ec96306502c1b58--