MIME-Version: 1.0
References: 
 <CANhcyEVSXyQkvmrsOWPdQqnm2J3GMyQQrKhyCJiBQzqs6AvSow@mail.gmail.com>
 <CALDaNm125dv88fUDgBPBM-N-hXbF0NLqKe-ymEpMRNymUYRQAA@mail.gmail.com>
 <CANhcyEUxgzaNJNNO_-12wYwGLihpuKmsMH2g4TFnRPx5AQVZmg@mail.gmail.com>
 <CAJpy0uBB4N8KOrHchdgprVi2Ws1+gTcEr+bC2A_ziAHOcZcTqA@mail.gmail.com>
 <CAJpy0uCAJQvBjD7qNWWGnZP_LDwS8AiUJC7YMict9UcYqH=XeQ@mail.gmail.com>
 <CANhcyEU_Yq9ZJ2n5Sqa7RoHze0TD0RGxLQQgV1F6Jm2AROEh8g@mail.gmail.com>
 <CANhcyEWj-ECj=WC+HD_kv27Dn6FkTngFQCVJVTVZfJnjCTKMBQ@mail.gmail.com>
 <CANhcyEW03XO5tLb7opt1yQGHWJ7Ew=L65EWcdrKH=F0mUpuR3A@mail.gmail.com>
 <CAHut+Ptu0Bkwnr5eetdmFhJC7SsEtKjNe_cTwOg5wF65fjyV8w@mail.gmail.com>
 <CANhcyEU+4Z6NXMEk6OmctFv=_pY8K5AiazkfVmn7zxhwQO6CEQ@mail.gmail.com>
 <CAHut+PvOWjKJfNorGO8whnaAtqZb-4zN8u6aOajCw3hn-tMwyA@mail.gmail.com>
 <CANhcyEV_Sv+xQzsjo6hbowDbGV5J7RhFWuQQxWeUWPNPd0k1=w@mail.gmail.com>
 <CAHut+Pt6O3YD8h61RCtzMrRwgvS=RDRNf4KuXAUn1WYnoFU_uQ@mail.gmail.com>
 <CANhcyEU=Vi2oNRWTSph3x2884J7aTt5BTb4AzwmmY0uQAsEMMg@mail.gmail.com>
 <CAHut+Pv9ru8tNLz1LaPjuG-1X5dsLd36cFbb11e=bhYrHz60CQ@mail.gmail.com>
 <CANhcyEVDStqoR3qDSgsv5VEuBMzMX4YpdEfW-7VPX3c5Vf1YJA@mail.gmail.com>
 <CAHut+PsFNboBR8E+NRY_3hMqdpbj3y3jX1+vQTow2khgj4t=qw@mail.gmail.com>
 <CANhcyEW+aJ1rAAodQZDvCd-WpQ+b8r5wBs8H+mNdQS8URmkODg@mail.gmail.com>
 <CAHut+PvXpsFrNn2NOhepVOS7Zf_OvX-m71Wu+m-o_q9odYFXnA@mail.gmail.com>
 <CANhcyEWfzDRCiny6A_swAD7WUgdb37-TA4xTAUQ3JJXK9UPBZQ@mail.gmail.com>
 <CAJpy0uCLhrwK_s3VbEjO+qD7amdxuYgNxi8OX4VLdb5pZkorwQ@mail.gmail.com>
 <CANhcyEVzkYgMu0ah7kUmPgk6n14xsFZL8XvhiJXNsCW9oRjdGg@mail.gmail.com>
 <CAHut+PsgCQa2hcT8TNqejV3y4U5ouj=ZCOLMxgVGvBrUEkLaKg@mail.gmail.com>
 <CAJpy0uCV-L8DP+AfZq2Rj1xEjyzwZW-ugfmmXMPpotiyNTHG_A@mail.gmail.com>
 <CANhcyEW_4=OECRiHStsCJUJ_Ng-V=EJ+Oaeji4uk3s4yazqUBg@mail.gmail.com>
 <CAHut+PtVyhHpMWCMrgO--dnHza00nBY3wZagfycWTDhSJ6sGFA@mail.gmail.com>
 <CANhcyEV201=vsz8aoOpSgYWEbG4WuxtL1P=a8X9N+48ZBtBfNQ@mail.gmail.com>
 <CAE9k0PnBrRaqOAqGVKmcaCKKKoZEx_sEf6p=hQRn_ZW2+04afw@mail.gmail.com>
 <CANhcyEWtAUnHF-3MKTSmH+j-A9sQSfuTdcCA9K285bL1ALmnyw@mail.gmail.com>
In-Reply-To: 
 <CANhcyEWtAUnHF-3MKTSmH+j-A9sQSfuTdcCA9K285bL1ALmnyw@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Thu, 2 Jul 2026 11:22:32 +1200
Message-ID: 
 <CAHut+PuC7qCdBUcCL1DeQEuRJsp-PU-n7_Jd4Hs-REn9M5ZO4g@mail.gmail.com>
Subject: Re: Support EXCEPT for ALL SEQUENCES publications
To: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>,
 shveta malik <shveta.malik@gmail.com>,
	vignesh C <vignesh21@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPuC7qCdBUcCL1DeQEuRJsp-PU-n7_Jd4Hs-REn9M5ZO4g%40mail.gmail.com>
Precedence: bulk

Only trivial comments for v16*

//////
v16-0001
//////

======
src/bin/pg_dump/pg_dump.c

getPublictions:

1.
  /*
- * Get the list of tables for publications specified in the EXCEPT
- * TABLE clause.
+ * Get the list of tables and sequences for publications specified in
+ * the EXCEPT clause.
  *

Perhaps this comment should say that EXCEPT (TABLE ...) is introduced
in PG19, and EXCEPT (SEQUENCE ...) is introduced in PG20. That way
there are no surprises about the different version checks that follow.

======
src/test/subscription/t/037_except.pl

2.
+# Check the initial data on subscriber
+$result = $node_subscriber->safe_psql('postgres',
+ "SELECT last_value, is_called FROM seq_excluded_in_pub1");
+is($result, '1|f', 'sequences in EXCEPT list is excluded');

typo: plural. Should be "sequences in the EXCEPT list are excluded"

//////
v16-0002
//////

======
src/test/subscription/t/037_except.pl

1.
+is($result, '1|f', 'sequences in EXCEPT list is excluded');

typo: plural. Should be "sequences in the EXCEPT list are excluded"

======
Kind Regards,
Peter Smith.
Fujitsu Australia