MIME-Version: 1.0
References: 
 <CAHut+Pvp7jYcaiZ3pXedXgLcWZWDBLXFUK05JtZpGv3Mj=UOjw@mail.gmail.com>
 <202604011144.jeo56tazdx6z@alvherre.pgsql>
 <CAHut+Pui7RaQ8OfJEVn2ry-ykjnGc+3ujsFmcHDFw9FsXw_tRw@mail.gmail.com>
In-Reply-To: 
 <CAHut+Pui7RaQ8OfJEVn2ry-ykjnGc+3ujsFmcHDFw9FsXw_tRw@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Thu, 23 Apr 2026 17:24:49 +1000
Message-ID: 
 <CAHut+PuD2pGMEKmk2dFA+guzxBEOas5+=LAm5E+SM2LU35KOnQ@mail.gmail.com>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000d3093406501b8c94"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPuD2pGMEKmk2dFA%2BguzxBEOas5%2B%3DLAm5E%2BSM2LU35KOnQ%40mail.gmail.com>
Precedence: bulk

--000000000000d3093406501b8c94
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 7, 2026 at 3:05=E2=80=AFPM Peter Smith <smithpb2250@gmail.com> =
wrote:
>
> On Wed, Apr 1, 2026 at 10:52=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kur=
ilemu.de> wrote:
> >
> > On 2026-Apr-01, Peter Smith wrote:
> >
> > > Hi.
> > >
> > > As originally reported [1] in the EXCEPT (TABLE ...) thread, I felt
> > > the _() gettext macro is mis-used when it contains nothing but a
> > > quoted format string.
> >
> > No, you feel wrong -- this is necessary so that the translator has
> > control over the quoting style of a list of items.  Not all translation=
s
> > use double quoting.  Some examples from different language files:
> >
> > msgstr "unbekannte Komprimierungsoption: =C2=BB%s=C2=AB"
> > msgstr "opci=C3=B3n de compresi=C3=B3n no reconocida: =C2=AB%s=C2=BB"
> > msgstr "option de compression inconnue : =C2=AB %s =C2=BB"
> > msgstr "tidak dapat menentukan encoding untuk lokal =C2=AB %s =C2=BB : =
codesetnya adalah =C2=AB %s =C2=BB"
> >
>
> The explanation [1] that even the comma separators and the quotes are
> translatable parts of the message reminded me to revisit the
> `GetPublicationsStr` function.
>
> This function builds a comma-separated list of publication names.
>
> It is called in 2 scenarios:
> 1. to construct a pubname list to be included in some SQL (here,
> parameter quote_literal=3Dtrue)
> 2. to construct a pubname list to be included in some error message
> (here, parameter quote_literal=3Dfalse).
>
> In hindsight, it looks like this function has been broken since it was
> originally implemented 4 yrs ago (8f2e2bb), because it does not allow
> translation of commas and quotes when the result is being used for
> error messages.
>
> PSA a patch to fix that.
>
> =3D=3D=3D=3D=3D=3D
> [1] https://www.postgresql.org/message-id/202604011144.jeo56tazdx6z%40alv=
herre.pgsql
>

PSA patch v2.

v2 removes translation of the comma separator, due to the discussion
over at [1].

=3D=3D=3D=3D=3D=3D
[1] https://www.postgresql.org/message-id/CAApHDvoFSu5zLFvx96aZ5wvL7tcB9aR2=
hBPCaMPs8D_f0Z7eSw%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

--000000000000d3093406501b8c94
Content-Type: application/octet-stream;
	name="v2-0001-GetPublicationsStr-i18n-support-for-quotes.patch"
Content-Disposition: attachment;
	filename="v2-0001-GetPublicationsStr-i18n-support-for-quotes.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mob5ovk10>
X-Attachment-Id: f_mob5ovk10

RnJvbSBmOWE1MDM0Y2Q0ZDBmNmViOTMwOTI2ZGUwM2U0ZTY4OGMxNTBlYWMzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBTbWl0aCA8cGV0ZXIuYi5zbWl0aEBmdWppdHN1LmNv
bT4KRGF0ZTogVGh1LCAyMyBBcHIgMjAyNiAxNzoxODowMyArMTAwMApTdWJqZWN0OiBbUEFUQ0gg
djJdIEdldFB1YmxpY2F0aW9uc1N0ciBpMThuIHN1cHBvcnQgZm9yIHF1b3RlcwoKLS0tCiBzcmMv
YmFja2VuZC9jYXRhbG9nL3BnX3N1YnNjcmlwdGlvbi5jIHwgNiArLS0tLS0KIDEgZmlsZSBjaGFu
Z2VkLCAxIGluc2VydGlvbigrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFj
a2VuZC9jYXRhbG9nL3BnX3N1YnNjcmlwdGlvbi5jIGIvc3JjL2JhY2tlbmQvY2F0YWxvZy9wZ19z
dWJzY3JpcHRpb24uYwppbmRleCA1YTczMzU4NTQ5MC4uYTkxZDdhNGEwZWYgMTAwNjQ0Ci0tLSBh
L3NyYy9iYWNrZW5kL2NhdGFsb2cvcGdfc3Vic2NyaXB0aW9uLmMKKysrIGIvc3JjL2JhY2tlbmQv
Y2F0YWxvZy9wZ19zdWJzY3JpcHRpb24uYwpAQCAtNjIsMTEgKzYyLDcgQEAgR2V0UHVibGljYXRp
b25zU3RyKExpc3QgKnB1YmxpY2F0aW9ucywgU3RyaW5nSW5mbyBkZXN0LCBib29sIHF1b3RlX2xp
dGVyYWwpCiAJCWlmIChxdW90ZV9saXRlcmFsKQogCQkJYXBwZW5kU3RyaW5nSW5mb1N0cmluZyhk
ZXN0LCBxdW90ZV9saXRlcmFsX2NzdHIocHVibmFtZSkpOwogCQllbHNlCi0JCXsKLQkJCWFwcGVu
ZFN0cmluZ0luZm9DaGFyKGRlc3QsICciJyk7Ci0JCQlhcHBlbmRTdHJpbmdJbmZvU3RyaW5nKGRl
c3QsIHB1Ym5hbWUpOwotCQkJYXBwZW5kU3RyaW5nSW5mb0NoYXIoZGVzdCwgJyInKTsKLQkJfQor
CQkJYXBwZW5kU3RyaW5nSW5mbyhkZXN0LCBfKCJcIiVzXCIiKSwgcHVibmFtZSk7CiAJfQogfQog
Ci0tIAoyLjQ3LjMKCg==
--000000000000d3093406501b8c94--