Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCn7C-002JQS-0J for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Apr 2026 23:24:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wCn7A-00DRgJ-1E for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Apr 2026 23:24:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCn7A-00DRgB-0J for pgsql-hackers@lists.postgresql.org; Tue, 14 Apr 2026 23:24:17 +0000 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wCn78-0000000170r-3A2X for pgsql-hackers@lists.postgresql.org; Tue, 14 Apr 2026 23:24:16 +0000 Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-8d560ede296so725751585a.0 for ; Tue, 14 Apr 2026 16:24:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776209053; cv=none; d=google.com; s=arc-20240605; b=EPE79JyggrLiyG0CZAPJ9xzJqa0Uy+dYQnxkXcKwO5TL2QYWxONYT4osclOPIoLFKG 5ErpH1QSvLs1GabKHKcOA5nqhHWEgtYiaUgPqaAxFbQM32JsdVXunMMngpLGgF2hFC6/ LWXDQ+Zfuv0CXSmz39kaiotUwRxR8CVMwjPzrbAsPR+U1RAYG6lyp8/+Kmxg0TNSkKbA 5VvSFP8R2Sj+Fz0biDPnTmcqy/IP/YLBOOxpsgrQ6bp+nakLCR4SRFEe4umdywYtTtSZ AggdLUum5oESfGffWnqlU+iKRAisC9Ta3Bul+nCkTuAW8REuY7GdulTGu2DmaCcZE65k V/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=c3daA+jqn/8LN0CQH9CJ2VD1gSq5qhrmhnchPjvOOWc=; fh=S4tPfgnijOO+deECZOmcfqIdEao0vNR869cn08/sS2g=; b=Bvsf0EpWMF3XFx9iPdU8KfC3wFhyHVDL8HeK+5G9YGQkNrCda/NPSyu3PxdPkC1HGZ wDMGdivc3PdVY59SxRv76TTTx1GJLq8njsZjHYZYI2qwAklPEem2EC5wIyMw9+80Z2sD gB7K/UAE7/Fp2CL5+zvAxh6Ml0/KZ++ncLlg40mhLBaKbVqWbQfAoBOAXjwo/RwJhfra p9s0FTypVS5tYyrSccEvsrN3nzRp4obtN0bX2LgepVvKgYA2MUl7tl1XTRwbwqYQRWF7 8t1jBTBKsmMBjTFMRsHpw4ZsZdMefCvsHlKT9z10qct21LUEQRCTYjoRbPX0Mh3TT5ea s52g==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776209053; x=1776813853; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c3daA+jqn/8LN0CQH9CJ2VD1gSq5qhrmhnchPjvOOWc=; b=Y3uORhiZnUXLFUGbeP1uPFj6KOuNSOMCr37KdQLbLKJzDZNFjcdCIky37D61zpXAnb X1ug133ggAqX5FJ6lREwrl/69ObDtQVzAIz07e17nJMP0NWjQ60X+z9nEONFK/07/mmB HxH1WZHkGuQf9Y72VeATMuJCpplFXr6Ss4Fi9e2um71tsthH+HxYLiOdu8OhDH9QKLi5 eYcHJT3LtICs/0TxNWasMFN/RjxEW3LH8VuvISK9tjVuQXebcgiMzrxhqlZ2PtlpJ16B zbWHAJN6/lHmBh4hUhscnhxR7xa4zxRQEy/0fOAJhDKiiXvxzr/nJ0a+kWxZjuHzjLoS l3gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776209053; x=1776813853; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c3daA+jqn/8LN0CQH9CJ2VD1gSq5qhrmhnchPjvOOWc=; b=MqRwEOahJjqZ9qGkJUtsOO9nPmoixf64vAWPzX8modnOOilqIrVB3UBzIpyIdQcILu B7CQgai/P6xey7J0i8sfWEdWPZa4I/cFPn1Zz93ZwPA6BpzJbH2dDl6YKMF6VRqC2gR3 /XQm3z9Ag7m4QqjerAeAlt1S3Xqx7+eEHQL4NQuf2WmRPQoWdLAf7hREC8M9MswaF+EG ql+sp6HsTLOD8f5txpjbXJ8nrybTcTM8002J6y+I9vW3DTet63OM509rYqCFxQ0zP7hS Zfvce4nxFYHPdURBACSH/kBTEqYk/reAiPWh9d5hha138LLGZXReLXMXEHN+Lotytq6x wd4Q== X-Forwarded-Encrypted: i=1; AFNElJ9+HLB3qh4HxYM28hXJm8uZwzd//IDiI8xuo+QLkzvKmORZVDW+OHbjNKScUOkcZACDgOCa381aCyF9jFL5@lists.postgresql.org X-Gm-Message-State: AOJu0YyL+IQXtwbae5bpGldHxyVpTgzzStX0gfALpnT0iXMeM6JhtEBh mxNIn1ZrtBVqyxPui8JLlYfnNmsD1yeYMPnNXSWZiu1gNn7qYAMJBnFqXGRxiiG3IVbCUUHh50k PPLXMAb8fh3JD2IJVT1mAClu+a/5LqW8= X-Gm-Gg: AeBDievf2SlV3LQcfzUCnSWcgGHPCj+d7QvQMAtYq8BvlhGUr6zsIbAN9vptXLH9hki 56PiuRpJ0m6W2IrvVmISqcXoTmJg8ZznvgF/zAkAOJKJq0EpREvPLDpX7Klo6wrsgQcceSm7VHd LEhpB6MoAyPzPzxVKPO71MRbKgZFqq1XKlgCT8YWZB49vacvunMXkmZWjXwXzLBih87K2y6SdaG aUsmSadJy57YBqwdmnU85fjN03y9Xap8bQzxb75ADXtn3orF+0fgGsIoK/53Z108sF3ILvA/jFL vs+dg24mU8jYB+iKzQ== X-Received: by 2002:a05:622a:4ccb:b0:50d:6d66:7271 with SMTP id d75a77b69052e-50dd5750ba8mr309715581cf.0.1776209052815; Tue, 14 Apr 2026 16:24:12 -0700 (PDT) MIME-Version: 1.0 References: <9FE5AA84-F1A1-4E1C-8EF8-3AFD6C46B318@gmail.com> <0B7E46E8-EA1B-48AA-A1A5-BC39B5073D40@gmail.com> In-Reply-To: From: Peter Smith Date: Wed, 15 Apr 2026 09:23:45 +1000 X-Gm-Features: AQROBzBPdBONf_ksnM7mbFGnv0VUfNAlZBFV7PnDvobm5Grmgkh5VYYf-nYZj7I Message-ID: Subject: Re: Add missing period to HINT messages To: Amit Kapila Cc: Robert Treat , Chao Li , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Apr 13, 2026 at 9:28=E2=80=AFPM Amit Kapila wrote: > > On Mon, Apr 13, 2026 at 6:32=E2=80=AFAM Peter Smith wrote: > > > > On Fri, Apr 10, 2026 at 11:10=E2=80=AFPM Robert Treat = wrote: > > > > > > On Thu, Apr 9, 2026 at 9:05=E2=80=AFPM Peter Smith wrote: > > > > On Thu, Apr 9, 2026 at 1:34=E2=80=AFPM Chao Li wrote: > > > > > > > > > ... > > > > > > > > > > I am not sure if your scope includes contrib/, if yes, I am sure = you will find some occurrences there. > > > > > > > > > > > > > Updated one more message found in contrib. > > > > > > > > PSA v2. > > > > > > > > > > +1 to the general idea here, although at the risk of looking at > > > patches before the morning coffee has settled in, ISTM you might have > > > missed some entries? And/or this patch isn't against HEAD? For > > > example, you seem to be catching the line here > > > https://github.com/postgres/postgres/blame/009ea1b08d7b8843435bd0f113= 7fa3df09aac79f/src/test/regress/expected/partition_split.out#L60, > > > but not the one on line 52, maybe because it looks like a comment (bu= t > > > istm we should clean these all up. no?) > > > > > > > Thanks for your review! > > > > Yes, the patch applies to HEAD. It looks like I was a bit slack in > > updating some test comments. Hopefully, I have found them all now. > > > > BTW, I find such a code cleanup exercise can be done even after > feature freeze. If so, shall we do it as a HEAD-only patch or do it in > bank branches as well? > Thanks for pushing. =3D=3D=3D=3D=3D=3D Kind Regards, Peter Smith. Fujitsu Australia.