Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSU5o-00FRsW-2i for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Dec 2025 05:47:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vSU5n-00EwXM-1F for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Dec 2025 05:47:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSU5n-00EwXD-07 for pgsql-hackers@lists.postgresql.org; Mon, 08 Dec 2025 05:47:27 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vSU5l-003nAQ-0n for pgsql-hackers@lists.postgresql.org; Mon, 08 Dec 2025 05:47:26 +0000 Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-4ee05b2b1beso38048291cf.2 for ; Sun, 07 Dec 2025 21:47:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765172843; x=1765777643; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=X1/ITYPzyFKRiVXc02SLOdnIr+jO521yp3CkoAwDZC0=; b=TYYRpaRMqEGyTnj6/8hrgsHk+b99jpVVHSFN/fIkqUHBUQqnxBc9gtnw+AfKyQlcNC 9xMlKF92dzC3iOOQ3xOiLUiMcndV0hA21dopqMrsnEixJyQLqPX/YxI/tmSdee3B1S/6 oTCsJBL3H0GCO3Bi6APUdOcmgSQ0yK3uQSPSZO9CnqmQvH4APst5ZdiHtYSaq+ES+Rs1 ji3xRGLJL8VdA7po2m+5ArkVH/kfeGlRWe9HbwvVpQFvNLvsvXbHd8+vjOGwZpu+s7E2 0VYmAd+1GolH+dwgDIMINnQ5S61+ihVLXbI+VVlte07rblsJ4i1EKgZksDj4WfnpnTbm cgAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765172843; x=1765777643; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X1/ITYPzyFKRiVXc02SLOdnIr+jO521yp3CkoAwDZC0=; b=Ykhc0gfSYGmfSsWYzNlqBg/ThQex7nu+C8hY7bSSwyq73+gXwYEhOXaKTyZb4iMwCZ l4UegdeOjrDwvoIYEbz7FNWzdxWsqOzEMzPDikaLz2IIQRnJNbbsoUEI7xwoLQkj29pa +F9wTXoSsYOmfcUBhxuNUHnLD5czcNGXObAqrU8Et8yIWfcKUyIaQXXHezTDnfjVnyp3 h48+7utpCXQepNgD+ngS1F5oGvR9F/PSFIzM50vXMaSlBXtILlM7wip1ZyZDk+ZgqAP9 J0KR50klf7/By2743hiOVJ1I5K6lSvEBtcrhhe09Q+3H4N4TRxRwLa4p0TFZpTV4blBV j/qQ== X-Forwarded-Encrypted: i=1; AJvYcCXFdxXKSd0zlHMP0ipDNYv/I+wYz4yl1lDZ2ZC+TkCfDlGORe+K5C4HMVaVUE1jNr3fuDWPWZ/YxBROCpOm@lists.postgresql.org X-Gm-Message-State: AOJu0YxS49GPi5tk4DcKEzBMQk7e4BgcH5QzqUqcdkPl9JsB2LObJsyL vlt5r7vB7VE8F80NcYtJmn/ul4HalcYmgiYeg12QtxFu0W2fCYrC8aWdalZxjHasj0e24QoS5am 5LYISTsggop3ANNj+m6vNAoxuFX8Kuk0= X-Gm-Gg: ASbGncvwK7dpNxjLs/gaTZXfN1A0Tuz7222UBch4vWuJEGszPiw8S01LnXZRdf34lr1 CenqE71pb8ncu4UttX0GdN0ER//f6WwQCUKfM2qV7k2+ukkmUvRmOsPY0PE8t1tsTVOJYJ2M2zr v0ibAtm2zSEMYElicfIzZ21OFPQ1ZjPruIDEgRAaJ0gc1+L7pyoGwvh4bNMQ+uTiW6oNg8LZbFI wtitZW/dxZDNpN4xvDVvW3fK2gkfCf5UdaxF8hcVYDDAjQYtLr41oR8hVxSdRsEcysaKWccdOZf 5i7d580j0Kxd8uOWqy8180PBNXspnQ== X-Google-Smtp-Source: AGHT+IGjK3vuqh8n0OZ2hsYGzz3LsRry0nKwjeaFLnmBEFTC4+7u5PU+aJ6tPGe5Ix5Op/bFT3L2hjUGy+KISHJS8Rs= X-Received: by 2002:a05:622a:5e11:b0:4ee:1dd0:5a45 with SMTP id d75a77b69052e-4f03fd4c8f1mr111626911cf.5.1765172843009; Sun, 07 Dec 2025 21:47:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Mon, 8 Dec 2025 16:46:56 +1100 X-Gm-Features: AQt7F2qmVwWMK0pxnPH7ykPnA2jVcQwmiXx8p6e1Sg0Kd8NKdKZcoPCoBT8lWN0 Message-ID: Subject: Re: Skipping schema changes in publication To: Shlok Kyal Cc: vignesh C , Amit Kapila , "Zhijie Hou (Fujitsu)" , YeXiu <1518981153@qq.com>, Ian Lawrence Barwick , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Shlok. Some review comments for v29-0001 (ALTER PUBLICATION RESET) ====== doc/src/sgml/ref/alter_publication.sgml Description: 1. The command ALTER PUBLICATION can change the attributes - of a publication. - + of a publication. There are several subforms described below. IMO, you don't need to say that sentence "There are several subforms described below," because it is obvious from the context. (I guess you copied it from ALTER TABLE, but that doesn't change my opinion) ~~~ 2. The new description list entries all say: "This form adds..." "This form replaces..." "This for removes..." etc. IMO, the words "This form" are all unnecessary here. Instead, just say "Adds...", "Replaces...", "Removes...", etc. (I guess you copied it from ALTER TABLE, but that doesn't change my opinion) ~~~ DROP: 3. + + DROP publication_object [, ...] + The replacement name here should be "publication_drop_object". ~~~ SET: 4. + + This form can change all of the publication properties specified in + . Properties not mentioned in the + command retain their previous settings. It is not applicable to + sequences. + For "can change all of"; maybe that should be "can change any of". Also, for "It is not applicable." -- saying "it" seemed awkward. IMO the current master text (shown below) seemed OK as-is; At least I thought it was better than the patch replacement text: This clause alters publication parameters originally set by CREATE PUBLICATION. See there for more information. This clause is not applicable to sequences. ~~~ 5. + + This problem can be avoided by refraining from modifying partition leaf + tables after the ALTER PUBLICATION ... SET until the + ALTER SUBSCRIPTION ... REFRESH PUBLICATION + is executed and by only refreshing using the copy_data = off + option. + This link would be better if it referenced the actual REFRESH PUBLICATION. Currently, it just goes to the top of the ALTER SUBSCRIPTION page. ~~~ 6. You must own the publication to use ALTER PUBLICATION. Adding a table to a publication additionally requires owning that table. - The ADD TABLES IN SCHEMA and - SET TABLES IN SCHEMA to a publication requires the - invoking user to be a superuser. - To alter the owner, you must be able to SET ROLE to the - new owning role, and that role must have CREATE - privilege on the database. + The ADD TABLES IN SCHEMA, + SET TABLES IN SCHEMA to a publication and + RESET of publication requires the invoking user to be a + superuser. To alter the owner, you must be able to + SET ROLE to the new owning role, and that role must have + CREATE privilege on the database. Also, the new owner of a FOR TABLES IN SCHEMA or FOR ALL TABLES I felt that those sentences: "To alter the owner, you must ...", and "Also, the new owner of a ..." really belonged in the ALTER OWNER TO description part. src/test/regress/sql/publication.sql ====== 7. +ALTER PUBLICATION testpub_reset SET (publish_via_partition_root = 'true'); It's a bit strange to say 'true' in quotes. Indeed, you shouldn't need to give any value here -- just say "SET (publish_via_partition_root)" ====== Kind Regards, Peter Smith. Fujitsu Australia