public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Smith <[email protected]>
To: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: DOCS - CREATE PUBLICATION ... EXCEPT missing details on ONLY
Date: Mon, 20 Apr 2026 10:14:17 +1000
Message-ID: <CAHut+PuUdhCMqKiCs1Rpp9YP07djN4BWwXQ8E5kS5xYYg+-nzQ@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1LRAGjUg5+HsLNR2Y=iCF=WxNes_d8z8Aa_fvdZrmgdHQ@mail.gmail.com>
References: <CAHut+PuVZsm4-Xq4ufDDzJiXbCsSuwO4cJd5Fia3Uc9VBUk5Xw@mail.gmail.com>
	<CAA4eK1LRAGjUg5+HsLNR2Y=iCF=WxNes_d8z8Aa_fvdZrmgdHQ@mail.gmail.com>

On Fri, Apr 17, 2026 at 8:44 PM Amit Kapila <[email protected]> wrote:
>
> On Fri, Apr 17, 2026 at 5:26 AM Peter Smith <[email protected]> wrote:
> >
> > Currently, the EXCEPT (TABLE ...) part mentions how 'ONLY' and '*'
> > work for inheritance tables, but how they have no effect for
> > partitioned tables [1].
> >
> > It seems we accidentally missed saying that these also have no effect
> > for *regular* tables.
> >
>
> The sentence you quoted speaks about partitioned tables specifically,
> so not mentioning regular tables there seems reasonable to me.
>

I think you missed my point.

The EXCEPT clause syntax allows any of the following:

... EXCEPT (TABLE ONLY parent_table);
... EXCEPT (TABLE parent_table *);

... EXCEPT (TABLE ONLY partitioned_root_table);
... EXCEPT (TABLE partitioned_root_table *);

... EXCEPT (TABLE ONLY regular_table);
... EXCEPT (TABLE regular_table *);

~~

Where:

1. Using ONLY/* for parent_table has a meaning.
2. Using ONLY/* for partitioned_root_table has no meaning but it is
allowed/ignored.
3. Using ONLY/* for regular_table has no meaning but it is allowed/ignored.

The EXCEPT clause documentation already described cases 1 and 2, but
it said nothing about case 3.

I could have left the original 'partitioned tables' paragraph alone,
and then written separately about the regular tables. e.g:
------
For partitioned tables, only the root partitioned table may be
specified in EXCEPT. Doing so excludes the root table and all of its
partitions from replication. The optional ONLY and * has no effect for
partitioned tables.

The optional ONLY and * have no effect for regular tables.
------

But it seemed unnecessarily repetitive, so the patch seperates that
common behaviour to say:
------
For partitioned tables, only the root partitioned table may be
specified in EXCEPT. Doing so excludes the root table and all of its
partitions from replication.

The optional ONLY and * have no effect for regular or partitioned tables.
------

======
Kind Regards,
Peter Smith.
Fujitsu Australia.

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: DOCS - CREATE PUBLICATION ... EXCEPT missing details on ONLY
  In-Reply-To: <CAHut+PuUdhCMqKiCs1Rpp9YP07djN4BWwXQ8E5kS5xYYg+-nzQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox