MIME-Version: 1.0
References: 
 <CAHut+Pvp7jYcaiZ3pXedXgLcWZWDBLXFUK05JtZpGv3Mj=UOjw@mail.gmail.com>
 <202604011144.jeo56tazdx6z@alvherre.pgsql>
In-Reply-To: <202604011144.jeo56tazdx6z@alvherre.pgsql>
From: Peter Smith <smithpb2250@gmail.com>
Date: Tue, 7 Apr 2026 15:05:51 +1000
Message-ID: 
 <CAHut+Pui7RaQ8OfJEVn2ry-ykjnGc+3ujsFmcHDFw9FsXw_tRw@mail.gmail.com>
Subject: Re: Redundant/mis-use of _(x) gettext macro?
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000047366a064ed7beef"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPui7RaQ8OfJEVn2ry-ykjnGc%2B3ujsFmcHDFw9FsXw_tRw%40mail.gmail.com>
Precedence: bulk

--00000000000047366a064ed7beef
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 1, 2026 at 10:52=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kuril=
emu.de> wrote:
>
> On 2026-Apr-01, Peter Smith wrote:
>
> > Hi.
> >
> > As originally reported [1] in the EXCEPT (TABLE ...) thread, I felt
> > the _() gettext macro is mis-used when it contains nothing but a
> > quoted format string.
>
> No, you feel wrong -- this is necessary so that the translator has
> control over the quoting style of a list of items.  Not all translations
> use double quoting.  Some examples from different language files:
>
> msgstr "unbekannte Komprimierungsoption: =C2=BB%s=C2=AB"
> msgstr "opci=C3=B3n de compresi=C3=B3n no reconocida: =C2=AB%s=C2=BB"
> msgstr "option de compression inconnue : =C2=AB %s =C2=BB"
> msgstr "tidak dapat menentukan encoding untuk lokal =C2=AB %s =C2=BB : co=
desetnya adalah =C2=AB %s =C2=BB"
>

The explanation [1] that even the comma separators and the quotes are
translatable parts of the message reminded me to revisit the
`GetPublicationsStr` function.

This function builds a comma-separated list of publication names.

It is called in 2 scenarios:
1. to construct a pubname list to be included in some SQL (here,
parameter quote_literal=3Dtrue)
2. to construct a pubname list to be included in some error message
(here, parameter quote_literal=3Dfalse).

In hindsight, it looks like this function has been broken since it was
originally implemented 4 yrs ago (8f2e2bb), because it does not allow
translation of commas and quotes when the result is being used for
error messages.

PSA a patch to fix that.

=3D=3D=3D=3D=3D=3D
[1] https://www.postgresql.org/message-id/202604011144.jeo56tazdx6z%40alvhe=
rre.pgsql

Kind Regards,
Peter Smith.
Fujitsu Australia

--00000000000047366a064ed7beef
Content-Type: application/octet-stream;
	name="v1-0001-GetPublicationsStr-i18n-support.patch"
Content-Disposition: attachment;
	filename="v1-0001-GetPublicationsStr-i18n-support.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mno5ne2m0>
X-Attachment-Id: f_mno5ne2m0

RnJvbSBjZDA5YWU3ZTRjMThiZmNiMWI2NTIyZWMxYWExNmNmYTNiNWY1MDJlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBTbWl0aCA8cGV0ZXIuYi5zbWl0aEBmdWppdHN1LmNv
bT4KRGF0ZTogVHVlLCA3IEFwciAyMDI2IDE0OjQ1OjExICsxMDAwClN1YmplY3Q6IFtQQVRDSCB2
MV0gR2V0UHVibGljYXRpb25zU3RyIGkxOG4gc3VwcG9ydAoKLS0tCiBzcmMvYmFja2VuZC9jYXRh
bG9nL3BnX3N1YnNjcmlwdGlvbi5jIHwgMTkgKysrKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNo
YW5nZWQsIDExIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj
L2JhY2tlbmQvY2F0YWxvZy9wZ19zdWJzY3JpcHRpb24uYyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cv
cGdfc3Vic2NyaXB0aW9uLmMKaW5kZXggNWE3MzM1ODU0OTAuLjhiMzFjNDg3ZGJhIDEwMDY0NAot
LS0gYS9zcmMvYmFja2VuZC9jYXRhbG9nL3BnX3N1YnNjcmlwdGlvbi5jCisrKyBiL3NyYy9iYWNr
ZW5kL2NhdGFsb2cvcGdfc3Vic2NyaXB0aW9uLmMKQEAgLTU0LDE5ICs1NCwyMiBAQCBHZXRQdWJs
aWNhdGlvbnNTdHIoTGlzdCAqcHVibGljYXRpb25zLCBTdHJpbmdJbmZvIGRlc3QsIGJvb2wgcXVv
dGVfbGl0ZXJhbCkKIAl7CiAJCWNoYXIJICAgKnB1Ym5hbWUgPSBzdHJWYWwobGZpcnN0KGxjKSk7
CiAKLQkJaWYgKGZpcnN0KQotCQkJZmlyc3QgPSBmYWxzZTsKLQkJZWxzZQotCQkJYXBwZW5kU3Ry
aW5nSW5mb1N0cmluZyhkZXN0LCAiLCAiKTsKLQogCQlpZiAocXVvdGVfbGl0ZXJhbCkKKwkJewor
CQkJaWYgKCFmaXJzdCkKKwkJCQlhcHBlbmRTdHJpbmdJbmZvU3RyaW5nKGRlc3QsICIsICIpOwor
CiAJCQlhcHBlbmRTdHJpbmdJbmZvU3RyaW5nKGRlc3QsIHF1b3RlX2xpdGVyYWxfY3N0cihwdWJu
YW1lKSk7CisJCX0KIAkJZWxzZQogCQl7Ci0JCQlhcHBlbmRTdHJpbmdJbmZvQ2hhcihkZXN0LCAn
IicpOwotCQkJYXBwZW5kU3RyaW5nSW5mb1N0cmluZyhkZXN0LCBwdWJuYW1lKTsKLQkJCWFwcGVu
ZFN0cmluZ0luZm9DaGFyKGRlc3QsICciJyk7CisJCQlpZiAoIWZpcnN0KQorCQkJCWFwcGVuZFN0
cmluZ0luZm9TdHJpbmcoZGVzdCwgXygiLCAiKSk7CisKKwkJCWFwcGVuZFN0cmluZ0luZm8oZGVz
dCwgXygiXCIlc1wiIiksIHB1Ym5hbWUpOwogCQl9CisKKwkJZmlyc3QgPSBmYWxzZTsKIAl9CiB9
CiAKLS0gCjIuNDcuMwoK
--00000000000047366a064ed7beef--