Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wZ0TE-000hJ4-0R for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Jun 2026 06:06:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wZ0TB-009y1r-2C for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Jun 2026 06:06:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wZ0TB-009y1j-0v for pgsql-hackers@lists.postgresql.org; Mon, 15 Jun 2026 06:06:49 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wZ0T9-00000000Swp-16h8 for pgsql-hackers@lists.postgresql.org; Mon, 15 Jun 2026 06:06:49 +0000 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-915671abde5so354167285a.3 for ; Sun, 14 Jun 2026 23:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781503605; cv=none; d=google.com; s=arc-20240605; b=BZFv8vHnskZY2d1JtRM5e3oKH8DmZl13jebvGbE4BpAEiveEWXOIQQHQ6e7j1rkVac IeuPF8QDWYAyGADFg1qmongSqNbPCUZC9AN3+Ss7feoiOsoJAHI3tJLcNux4c9kKpZlf Kv8a7/lATHpxzSzI47XAFz+Py3Amb5hPwCHhFCwA957eqAutCXXdSc8HIvbuON+zu/hm flsmJnDlXP7LXWFk9HdfkvfNecTFJTwZlxHbO416ubDzkh0CwQWM7YUj1PMQ+bND8tj7 34/eIsqN0n+EoezmRBAybtMHrHiQoUODmjEUQgXDhtzQhN529ytuswdo8xOvvo0maUYr yLpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=epRlxGW/5Bel7SOw+oKFXNM4d8mGq4aigvZVx1IC4hs=; fh=VTxoXjitfhoeTDMXpaTAXxby3i0oZN5DGExvRXiO/UM=; b=HPFtecwynO+3rr3sZcowK8D58ZCtjaSS9kR40paWYT0mB7+d6G0EtHvTCzE9/Bs+nG Y6N78zhHR/CaS7S1jcQZ6A4OysiWM1bYanIlQPBXluonHj0UwmvsRfvU0vNZlp5Ncvqx UNmLRBK882QGOREFjwhnPEHMxfBBuxZCiQYL1nYHuzcBD3upDtmmFJC08cJnx+zTiQMi Acwaf0eObSXpHBfownYRIbv+5tCQPHIIgGrBPV9OtQkO0vsImwnivy59my5KzyKLMG8N G5lgp3sntbg3zIGTLXO95KbWwfyR2cbsS++WM0cHjd44atKFHtfQPz+VOVHOIJ0j5coA Helg==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781503605; x=1782108405; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=epRlxGW/5Bel7SOw+oKFXNM4d8mGq4aigvZVx1IC4hs=; b=mP6//pX0zCt3vQ2vwYQ+UAdda1YEdki347qZB2PN5dpOq2hYMd+zULQmVoOIdFPxgS IwL0SR8YxrXNzDQMxMuQlrW6htob2ZsWnENW19F0uY0WIgv/wU3povEoxBpbQLR9iWkh IDLN0VlXuGbsopWNgqxxWKcKLzK03jVtVX/LNzqu168JRbXYXnuYIkFHLogQbEy0Ed1Y NRHOi2drtlx13vG8Asa/Ot9g6QGBg9BkhBLAj1HZ8KyCkldKdb1R6kXlwp9luJD+EFci sQUpSnEmQmst8y2Vy/pvL+ZHO7HMvL9mXLvW9cRN5lZAJISEjXW3t3Q8aB4SQmVWz58+ +NIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781503605; x=1782108405; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=epRlxGW/5Bel7SOw+oKFXNM4d8mGq4aigvZVx1IC4hs=; b=JMyxxiOt1cUsp+HoyvHea1TYPCSns0tUpt1BIkhVFNnoJGbKkZ3PdOfrS624omzBIF HRqHFOzx6KFMPKYOgHaxSfRP+bHhg8+hBgUhOcfcdRvPE7DkpRh6yLeHTnMifYieHxjo Q0xYWtT8uEcujZSoVwRA8SYkerRh8WXeDKRt8NDUN5wGNaeJ6MhLG4Tf8iFE5k/v8fmp ccIMkD4b3gJhgu8r/2BRun+zwZ4vyf+ZFlAqIzD5ZnT80XyCyURmYkk3RmWRHSN8VOzD nUrfDlR7o5rGFBRUrmptS9oWmG1XdsUuYh4ZfEBtycw9Jy4ADZB+SbaaEtNqKenBCAjd 9lzA== X-Forwarded-Encrypted: i=1; AFNElJ8sTMkEaYsmXaP3Sbpq52/p8BJig/E250d7dZfPT9Ee99oBRMmkvInl1v+HJadoUrha7DLjcI5YD9eDwTpM@lists.postgresql.org X-Gm-Message-State: AOJu0YwAwlEDAhZ3uTLzHiRsNeGebndDjXcRV56ub3ROPRZESkmEFkon 2j6YQlBlW3sYHMjGVrPkoG8A0nmoSVXDibWOWB2UP4RGetV3cBa+AZz3ZCFC8bF5yKl+ft4CMoU 7GpVP+XuLhL7nLU2oHAFg4WA6dtjelUg= X-Gm-Gg: Acq92OGkL2so0ohKx8Dzjt9YZ5zVBn1DJOFHgZ6uHz0CNJb9mbWOTgkanrGOq76BXtt wRO6f6o53oeqP3NCiaKf71jBq7Pm9yW8NdUSvtFWb5/SuWm8CNh/Xd3w0tceNSED4eW03h948Zz TkFAVppytKN3mefzkRNq4ySTBw+F7I6iZVxB6menTQOcBkVrkfM6UxjfRxihiWKekj9gNlNmv99 p0HCBfRc8MEl7P2WUg+xETKQsrNUyEszC9fyDgeTfLfv4SyemO5Cfk9EmGmDhDkO4XsZlcnJ84C Z5YqddA= X-Received: by 2002:a05:620a:19a2:b0:915:d322:c47f with SMTP id af79cd13be357-917eefc213emr1628923885a.4.1781503605126; Sun, 14 Jun 2026 23:06:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Mon, 15 Jun 2026 16:06:17 +1000 X-Gm-Features: AVVi8Ccl3HXuYz-BUnunWzZRLn-jx9rtTF7J0ZpUKjBFCLmcx3vDoepiiPWwgPQ Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: vignesh C , shveta malik , Amit Kapila , Nisha Moond , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk A trivial review comment for v50-0003. ====== src/backend/replication/logical/conflict.c 1. +void +ProcessPendingConflictLogTuple(void) +{ + Relation conflictlogrel; + ConflictLogDest dest; + + /* Nothing to do */ + if (MyLogicalRepWorker->conflict_log_tuple == NULL) + return; + + PG_TRY(); + { Those 2 variables are only used within the PG_TRY block, so they can be declared there. ====== Kind Regards, Peter Smith. Fujitsu Australia