Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1t0GiJ-00AP4i-V0
	for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Oct 2024 08:46:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1t0GiH-00BgKv-HI
	for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Oct 2024 08:46:01 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <smithpb2250@gmail.com>)
	id 1t0GiH-00BgKn-3U
	for pgsql-hackers@lists.postgresql.org; Mon, 14 Oct 2024 08:46:01 +0000
Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <smithpb2250@gmail.com>)
	id 1t0GiB-000o5u-1o
	for pgsql-hackers@lists.postgresql.org; Mon, 14 Oct 2024 08:46:00 +0000
Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2fb2f4b282cso26959711fa.2
        for <pgsql-hackers@lists.postgresql.org>; Mon, 14 Oct 2024 01:45:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1728895553; x=1729500353; darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=bDhwVwTBMWshf9AsNBRmoAXuz9sR6uXFcbCGZjdjUxY=;
        b=DmxbaFeRs00qrJPercpNhquwxdPgZnXjDVPvUbJqxCSpeyBg/56A9VKG2zIL73HF+U
         /PW0ldYGYph0t1sJ7LWyxmHFIj/aj4kAzKC5W9zuh321I+OxFG13o4kA6eEux34NYnwn
         k6DYQ1uUNXKNx+Nr0amlLbY/YdXJiyqjmVLFqSlHquWO+M+1n0AUpFqnycUtHwUWzS/6
         yHfkw/btmtjfTnlQbVwzC93ALzOZfA7b3oQg81gugZk5IHzK5fKE88gubEowPL8DjSpa
         vHqOT83qIsgPSs9cTZ3pcWXZ4fQemSDI/DLRrNYOPUP6fn2w36XaEWzoqsbQBI4HAYZh
         +Ohg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1728895553; x=1729500353;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=bDhwVwTBMWshf9AsNBRmoAXuz9sR6uXFcbCGZjdjUxY=;
        b=XlDbNycZMCbeTsF9ZpRYDLRpKrghSet4EEbML3jsibuQW7dfiUYSGhp4aIWWcLAtTc
         85jBOq2rGt01JQ0b34VRmej69f4yZzgLd57F5CFvL7yC7gd18qLevUAxrt+Yd4cVd06i
         Esj2506CMOSjTmZzAuGornywm8/A8lIc8gH9A2V5vFNLCXf6bHP+n409m86+8+7bJpmR
         0ANOCSk/OZhgIxHXJ3TAWGG+55px8wCicDSvkwdJaSGpUJnbRQI/y8Vkg8Y7//HHyUnX
         QiPd4wAiKbVRYm/dHR/MQz4pJO7zo6OyYtQ3ISZ6+ddUUMTglm1ADbpdgE6T4h/gUBnp
         1TOA==
X-Forwarded-Encrypted: i=1; AJvYcCVRd7FPlA/iKQ8iJjz1wNHG6WsIpl5pWZce+hAiITjTknyp8joHwMVRDE/SJUZdcxHVCdWJvGdIIMNOMtQ/@lists.postgresql.org
X-Gm-Message-State: AOJu0YwHlBsY5cNC19CB8sAE530rkQ9uZa+ZJj392+7Yde0uQk1t3C3e
	iG2ssGYLuaaeCp7d9+nzuwD69y+zJTQHxY1T2nUwwWVY5NDY1/d4h12hQg68JFY/YCZ+O8+VMTL
	I9qfGYXGByX2E4WzB+tnCIJ26ls8=
X-Google-Smtp-Source: AGHT+IH13dNF+HKOf9TN4JNV+fn3cYUPTyAie5iyAQHH/1YGwFEOi7oKxAtO3RV8DMvJ0kAD4PhmNI760HvpSYSQEIg=
X-Received: by 2002:a2e:4601:0:b0:2fb:587d:2ee with SMTP id
 38308e7fff4ca-2fb587d03cbmr881951fa.12.1728895552874; Mon, 14 Oct 2024
 01:45:52 -0700 (PDT)
MIME-Version: 1.0
References: <ZwY68OhKx/5jWeCj@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoCAEXmxaDHAjMwqcpV6JVa91wBbXamQbk-rv1QnYhzGhA@mail.gmail.com>
 <ZwdK1UYdLn/zFMHy@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoB-bxBqBEt9zbUQKTTUag1_NRPeT_5aGXC_j+z0+T3Hkw@mail.gmail.com>
 <ZwfSXS/3v73388jh@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoCoyNBCahi6efsjG9Lr_dGsVin1m6Y6tj4dTE6UnTAcbw@mail.gmail.com>
 <Zwkk9Z6rzNxArr1p@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoB31apHCzZ-45rDtB56qQm+TBwJnB48JjBvuqR5xviAEQ@mail.gmail.com>
 <CAD21AoD+opO0SaDSFvz+n+wAxc-kUrpF5Wtxbw80Bqpay+rkgw@mail.gmail.com>
 <CAHut+PsYdTW4+U+fioh9_yO8iT6RnY=PquzfCZu7zRU6Qg6W7g@mail.gmail.com> <Zwy4ys76aPcoVE/I@ip-10-97-1-34.eu-west-3.compute.internal>
In-Reply-To: <Zwy4ys76aPcoVE/I@ip-10-97-1-34.eu-west-3.compute.internal>
From: Peter Smith <smithpb2250@gmail.com>
Date: Mon, 14 Oct 2024 19:45:25 +1100
Message-ID: <CAHut+Put--H2Db9YC4zW_NkLZHNAShTY9Emp8KXP-27yAicfhw@mail.gmail.com>
Subject: Re: Add contrib/pg_logicalsnapinspect
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, 
	shveta malik <shveta.malik@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, 
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAHut%2BPut--H2Db9YC4zW_NkLZHNAShTY9Emp8KXP-27yAicfhw%40mail.gmail.com>
Precedence: bulk

FYI - Although I did not re-apply/test the latest patchset v16*, by
visual inspection of the minor v15/v16 diffs it looks good to me.

======
Kind Regards,
Peter Smith.
Fujitsu Australia