Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7jg7-005dww-1t for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 00:43:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7jg5-00E2OP-32 for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 00:43:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7jg5-00E2OG-1z for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 00:43:26 +0000 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7jg3-00000002GeZ-15dp for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 00:43:25 +0000 Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-5090c7e9081so50386341cf.0 for ; Tue, 31 Mar 2026 17:43:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775004202; cv=none; d=google.com; s=arc-20240605; b=cjN+4NjXNDGhrlM4D5kwB4nl+XqD/+I6wnzZzLgx4UbuIqoox7hhoAZayoCaKT6lOm vafcZFestCZ+hsZHWymJS/uUsJV4+D+eAq65o00ajdrrKNJ6ROaznjROlLEApHKnsRJb knliykKmglVmHkg2urHHnxV2TdTrZQN8NAmLoP/oEETTFMPIm2AV91q4MWj8ahyAGqOD W/WqIdv7Dxtope0EOAuMwfRXnVs4V4bwEhdSnzgJEtngF0MWeG6p9UJ1bgV3yDtxm2DB 9zzGK1fNCKXhkN41S6ws/m9qHEXLoOIjZ+/Hn60+5BWyLjzoCsl7AHMwyGfExLo1YsLb GKkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Xyhiq5gh30oiQ9UhYZVuArLWdhdrI+Kj56XnfCTyV8U=; fh=59azYjHp3eTEsTCl5d0KQT/98I6uPtVx4ZLfJDoLL8I=; b=SLVgrCbEidpdojZrrmbYfuvNTqvbC6/yn9q4n8VC8BCBOyQFQliKSfZKjiqhLibIAs yXvgOx2Jaq7xlfKVVU4Tn3YDu8ESRLMmyiNKuZP7a/+Ru1IHNXJnis624jPxfHMXB82w BhFf1/P2L0m/8i8PBCkMygxbCuuRTCnpPbRxkts/R+YXx5KGwaTQgcUwMBtLTLv42q43 taTbbGTISy4K0hqeP9Q+xr0SWlEtj5aL2GTZel02elp8dvkt0eH/ARWj4y8H0pnoMoNG EYDEohuQGAE87Zyo0/1PP2NpDz9SvP5xysIeHhoo4uKMkqEoAqonVKFrPxwbHVSEU9QJ +qNg==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775004202; x=1775609002; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Xyhiq5gh30oiQ9UhYZVuArLWdhdrI+Kj56XnfCTyV8U=; b=IGVWIR4PA+aCNFfJBo/8jy9p4tKIf68E6qFSvYH7IUqE5n6TiyQr4w8ZWE5iysaGli O5dq2Gsh+vNW0+oceojvqZ/X4whyhHa381NHN/gzAWzp7kF8gj2YW284oi96vk0qTqml 6k5PqKS2OnooGfTVfImXLxv7ERfmqW05Me4/LMc9ov2FT+nCgXnlQ54NP0I1dNvFBRVT pMaRssfmm1WWcEw8YJxXf1Mlkgls+uKqoaSGxZNMviKhU80SPUthIYE6K3Ltwzm0iYgs LG+UuSGHFYaFs7c2qQrprDds+M8Mu0mExYsB1BDma1PMNpRs8m7QbgkJ9hQPV2LOB7E9 BZwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775004202; x=1775609002; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Xyhiq5gh30oiQ9UhYZVuArLWdhdrI+Kj56XnfCTyV8U=; b=nlKMdkZBPmg3SfRfrNqk+b95mwd/v7slWLCyy/jiwc2tWLI+bTeFCdxCRoJ9XL+jF3 I3jaid2fXv1xnB+WqJHnsYlaTvF2lmQoV8SzCsBV1BfsiAkK+Z6GdMIPzNAJai7gqZCl sr2H5moYtgsZ59zpeOHcVcs/Of/HeT2oY9cH5pZstXIxDgHdbpFmwFmO4JSRvk18e/xU ENyg9mZLsDLv7vs3chyR7UBI205sxRQAWitfNmydZaLOEVwAF0wGeoC/VYpNWb+qZBML 3M+6AkoqCDRIivkmf2b/osjIi+AZi7hYox6S2HlwDybMlcqGk2kGBq53Oomf39KNVq1a Gcqw== X-Forwarded-Encrypted: i=1; AJvYcCVSrBS8YEShA9DVCRebBwOyu5OwpNfUHlbRMr/od63fkMuvwJGQtlciVOCU03kd35IROvhKsDk/Ddsk7aZZ@lists.postgresql.org X-Gm-Message-State: AOJu0YyUva3GmMOYsythlajRpsDvMYbpN9vj/LucfwrUUIrAHx8glXOD SPSbTESuf8rYMh3xMNz3P1XHUM2rc8ifHpg00/YM9R9o+4OWCehuNwPeBqt/HQHs7S4KCffCVOx +29vs8HEL4uqwgXy5gFkhKSJqrElsJv8= X-Gm-Gg: ATEYQzzQAuCO0B6QB1hbZpOwEK8gSbDvNZIq2KfSabgYn9iaPqpkLPIgPnXqLcgJ6Tq wnRku/N0jsukcckILYLbZpCdTXyGiePOtMo0yQB0djEEXqv/9XJkvtVJKzZTy1ZRLRKb44pK9+L hmnC539OmkVwaHplDDj7DI/TJNnSRlxx7XGR1t6hWPzVXwHLEVkywqol5UB5hKmabngKhGM35BP rhVBBO1DvJHmXPN9gYxlaAFZL8ONENQ98xjzGwP78EpntAX31DFDuX4VDjpBsOFVY3UMealyXBC HzAej0Nb3ko/tNtWcfbo69ccVB7c/EbORa7HtmG1UQ== X-Received: by 2002:a05:622a:1207:b0:50b:436d:dcc1 with SMTP id d75a77b69052e-50d3bc258c7mr26358661cf.26.1775004202174; Tue, 31 Mar 2026 17:43:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Wed, 1 Apr 2026 11:42:55 +1100 X-Gm-Features: AQROBzCh6q82jaiBRj3hAeROquov6LY6cniyGvSG4hVZyYuaI3Rr5tt-tkHfqGY Message-ID: Subject: Re: Skipping schema changes in publication To: vignesh C Cc: Shlok Kyal , Amit Kapila , Dilip Kumar , shveta malik , Masahiko Sawada , "Hayato Kuroda (Fujitsu)" , Nisha Moond , Ashutosh Sharma , "David G. Johnston" , "Zhijie Hou (Fujitsu)" , YeXiu <1518981153@qq.com>, Ian Lawrence Barwick , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Mar 31, 2026 at 8:30=E2=80=AFPM vignesh C wro= te: > ... > > Thanks for the comments. This is addressed in the 002 patch attached. > The 001 patch has the rebased version of the patch at [1] to fix > Peter's earlier comments at [2]. > > [1] - https://www.postgresql.org/message-id/CALDaNm0mYT55pjdyN-yY%3D5dSOf= MVx307CtP3xYqzWVa0MPRtLQ%40mail.gmail.com > [2] - https://www.postgresql.org/message-id/CAHut%2BPvw-XNBnW-ymGdWpLxaEi= me7_EdOihcUheGyZvw73kcgg%40mail.gmail.com > Hi Vignesh. Thanks for following up on my outstanding review comments. ////// Patch 0001 - Fix few issues in commit fd366065e0 This did not address the review comment 3a about the redundant macro '_("\"%s\"")', but that one might be better handled in a separate thread anyway. I can post a separate thread for that one later. So, patch 0001 LGTM. ////// Patch 0002 - Reuse table_object in publication command syntax LGTM. =3D=3D=3D=3D=3D=3D Kind Regards, Peter Smith. Fujitsu Australia