Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wZ3AA-000jT5-1t for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Jun 2026 08:59:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wZ3A9-00Ap2o-19 for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Jun 2026 08:59:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wZ3A8-00Ap2g-33 for pgsql-hackers@lists.postgresql.org; Mon, 15 Jun 2026 08:59:21 +0000 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wZ3A7-00000000S06-2IQZ for pgsql-hackers@lists.postgresql.org; Mon, 15 Jun 2026 08:59:20 +0000 Received: by mail-qt1-x829.google.com with SMTP id d75a77b69052e-5175eab3a93so25531851cf.2 for ; Mon, 15 Jun 2026 01:59:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781513958; cv=none; d=google.com; s=arc-20240605; b=Q6QQU26uBk2MHoNCsfk6ZLX+MuoAFdYNTtEEC9cuX49CKChHiO9hWbeXaMsDtO408V Fgsu1wT2MLEXfsHQmPTyit6hzUQE5NQlQBWzmsuPPXLqZXfWF0by0NwxyDHHe3LduOyO o2Cn36VJerX7k7YcH2LOD9qGpUAEMW5HSNxEMSEOHWfvsZg/Qun43Frd6RmucQu2Je07 c4ixddS6cR6qgUXXS7hsp5/ptTKLunwMW9xUhXIBRUHOFPMfgkQobiqNexQXJBi5BytR Ec1Ay/8O4m3V6PdXhuLrL9e6pptWWKLcCb/q1iqrtSpGs99DQep0iqBbmA2zNZ/3o7e2 xA5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=l2iPiBGpYWtCGaeHlYQoJYtZNm9pOppjCnacpny0vfU=; fh=mqnxo+zq8TCe+E/n8UKXyl2ZB2h47MGkPyuXM6YhopI=; b=GAJCgPjIGQ1iys7zeXirZeMjBKi6Fl3ROTCotOsiW6uJjKVNXCj0guzORp3JF1RGdC 8A43ftpd8ow2BmOxhd2KMTH9ArqEI2tdsUse/fFt+WV/OTCvhvAALWXjduoQ8LkBxpbl G4ooW0JMZjJhKILYH4NH6TzEnYWxkL4GLROIonNZAafMkN36hiFQXwT1DvHbmhHuTrI5 ClXN9a+D5JvweyPrN6fKmPl1N+xjspBFyEDyjL3mfIHUbjLw3txUn7OqvwqPjv+vRIZE V9H0nQJUBOO7PvhyglznVfzg0getvzwHvsrXb61NixyFl3+XE8sJs5iQ4fXbboOgWHib PUUw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781513958; x=1782118758; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=l2iPiBGpYWtCGaeHlYQoJYtZNm9pOppjCnacpny0vfU=; b=Ck88jepoC1HupEhpnbfrUA0kNdiJEQuOjXhnr441F2PT0XBMYPujgtf5Ylb+25wIgn A05cifG5PsjoFmT9YBXMvXS+WcY0BoftcLX0kvjn7+N/Yk7+xiakaivzxJwBC4u00Q9p Z+VTsS3ozl89IQQ4EEwIzsJtINqe/xM0BjVwEck1UySgiKAh5wed8KY+swrWCR00kYwY Uu6Ism54thwBnXH8qPZB759oylTMV3khtwr5kJnWWXBwyFocX7ZUjW4o8xNDpCvU5b9A 6Pp/0rtYHe/H3/iVZHFbD0tU6opVym1DOVaFqDoC7puZTj5BOMSZT23STho/UabQMwgy JUEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781513958; x=1782118758; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l2iPiBGpYWtCGaeHlYQoJYtZNm9pOppjCnacpny0vfU=; b=EhpR5JPBl2dMTtws8t9rF1ygpYZW2WZW4uBXrW9wWiJNmaiUGaT39vqcZpU9tnRQU6 L4/S3S45PU1UVg5TZPqAyw1qeL9yxrDmNhClM9cQJcYZLS6LNnz4vZUiY4fgR57ustNl 1qVLsCZC8zG4omKPlOzybi2JeoAIQ8v/TCcIk+BgO4EjZLvLqyInD9kUB3cCaShcFVyV mWNEbmSp40z40ZuqOTDtnBNLV9+8v9WxgK1j8zcxPWNz/bhiPY7p9K7qKLjGB/pBX+U3 pFTTE7kBut+bRZ+Xm9hw9BuIrYkaQEcx+2ASCbGVkh1KqLIB8O4FpPofFQyj9CFlJ5x2 +Jnw== X-Forwarded-Encrypted: i=1; AFNElJ8+3hVs3jeWEMNslh5VO1yQHJHIrpAJ7yuZFwxr214B2H6Bc9Hvlu6NdXL6p0bO3BCdDhumnKdXFFXi+mj7@lists.postgresql.org X-Gm-Message-State: AOJu0YzSwMSktRPjmfOXaK21LRJeBbQnXG8rhkSA9pgkn8HHP6pI34rP GC330sNV0mwzBxE9sZhf3+9I2UkOc45oFxxujHUVFQYp67ODoHaZ1EZcztLFcSVer7kgg3FTTLA oAlJD21AbPj9fTD2A2miPCJfoJidmrR8= X-Gm-Gg: Acq92OFNo8cndu1eRSSbyYT0oXQ3nRZscVsf76DS1egNvSL5qEQQJTt0Rnz+zjP98bZ Zu7oE/kO6/Nc1h1oWHd3eb8RXXXeVFvgHK7SuSyAzaSjelmgy1jtWpkriCd4TqRFGdJz+lMvHI9 xvxoZBcvS1nMna6VerOBkdkLGzNLUXuzjD4FGBKQK7hLTD6V5Rq19+guWRoVzGyd6y3zvv1LIaC iXpJZzY8lAWkX246BJRfgwn5CGCsJtlbOAvOk8Z+LsiqqQZsqLmd7H6Qa/AtBEKTurfBh3cvnPW 7Gv6ftg= X-Received: by 2002:a05:622a:2d13:b0:516:d4b1:48e4 with SMTP id d75a77b69052e-51953356ad7mr116250311cf.4.1781513958276; Mon, 15 Jun 2026 01:59:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Mon, 15 Jun 2026 18:58:50 +1000 X-Gm-Features: AVVi8CcImzrEUWoF90lCnRQ5mvjVwRmt6OAZQJU3PTGlRJ7OLOIFTRnOslkUR9s Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: vignesh C , shveta malik , Amit Kapila , Nisha Moond , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Some review comments for v50-0004. ====== src/bin/pg_dump/pg_dump.c dumpSubscription: 1. + * We skip the default value ('log') to match the handling of other + * default subscription options. + */ There is only one "default", so I think this should say "...other subscription options", not "...other default subscription options". ====== src/include/catalog/pg_subscription.h 2. +#define CONFLICT_LOG_RELATION_NAME_FMT "pg_conflict_log_%u" + 2a. This format string (and first usage of it) really be in one of the earlier patches. ~ 2b. Add a comment to explain that the %u is the subscription oid. ~ 2c. Is this the correct header file for this? IMO it is CLT specific, so belongs in conflict.h. ====== Kind Regards, Peter Smith. Fujitsu Australia