MIME-Version: 1.0
References: 
 <CAB-JLwbBFNuASyEnZWP0Tck9uNkthBZqi6WoXNevUT6+mV8XmA@mail.gmail.com>
 <CAD21AoA6i2ui8FMZeuU_KxX4t-fM8G==zTW2Dp6-goujttrpew@mail.gmail.com>
 <CAB-JLwZpp=7c9_r0beWWJxRh2BS_2Vvth8UDv7H57DBeaqggVg@mail.gmail.com>
 <CAD21AoDT3sL2COprsRumM9zEpL1Bk5VWboK4V2mRnjGua8xfeA@mail.gmail.com>
 <CAD21AoDQM62GOtaTzD_CVMSsFhv6o9c0Au1dSM1QuxeKFkWAKw@mail.gmail.com>
 <CAD21AoCz7HjEr3oeb=haK31YHxHZLcvD_wx_a-+xLPKywq++3A@mail.gmail.com>
 <TY4PR01MB16907733B75A99117F013AFCA947FA@TY4PR01MB16907.jpnprd01.prod.outlook.com>
 <CAD21AoA9YgiY1rVKMPZwB00WU_G4UfzoawY=7hyd7hpvBPcK6w@mail.gmail.com>
 <CAA4eK1KoSi60dtakJzn0MxNnHF1Yf4indSAffTjJxQG_31jsgQ@mail.gmail.com>
 <CAD21AoB4B3MOxJ7-v9YLjV5fTOtaLRUhX3jN3kqhEi7D7-uY4A@mail.gmail.com>
 <0c28fbd1-3320-4e9b-815c-6d62753aa063@wi3ck.info>
 <CAD21AoCmHpKrNg9D3mcOA973CZ5N_dBLxb8pERpSxEeRLSQxpA@mail.gmail.com>
 <CAD21AoAEVyxwn_bMWHvcU-Gcz3aUVjAtMbdgfoJ8MZNiLLEh0g@mail.gmail.com>
In-Reply-To: 
 <CAD21AoAEVyxwn_bMWHvcU-Gcz3aUVjAtMbdgfoJ8MZNiLLEh0g@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Tue, 24 Mar 2026 17:59:25 +1100
Message-ID: 
 <CAHut+Pv-N2YO3KB4Ohzkv97eiXC=JyU1cbpDsaSXm+jb7-OPCw@mail.gmail.com>
Subject: Re: Initial COPY of Logical Replication is too slow
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Jan Wieck <jan@wi3ck.info>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000b97ad6064dbfb2f2"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPv-N2YO3KB4Ohzkv97eiXC%3DJyU1cbpDsaSXm%2Bjb7-OPCw%40mail.gmail.com>
Precedence: bulk

--000000000000b97ad6064dbfb2f2
Content-Type: text/plain; charset="UTF-8"

Hi Sawada-San.

Here are some review comments for the v3-0001 test code.

======
src/test/regress/expected/publication.out

1.
+-- Clean up
+DROP FUNCTION test_gpt(text[], relname);
+ERROR:  type "relname" does not exist

This seems a mistake. If the DROP FUNCTION was differently written
there there would be no error. PSA.

======
src/test/regress/sql/publication.sql

2.
+SELECT * FROM test_gpt('pub_normal', 'tbl_normal');
+SELECT * FROM test_gpt('pub_schema', 'tbl_normal'); -- no result

These tests seem strangely different from all the others because
everything else has both a "good result" test and a "no result" test
for every publication.

So I think there should be a "no result" test for 'pub_normal'

So I think there should be a "good result" test for 'pub_schema'

~~~

3.
Consider renaming that 'tbl_parent' to something like 'tbl_root'.
because 'parent' always makes me think of INHERITED parent/child
tables, rather than partitioned tables and their partitions. If you do
this, then you might also want to tweak several publication names --
e.g. 'pub_part_parent' -> 'pub_part_root'

~~~

PSA a diff file that makes those suggested changes #1 and #2.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

--000000000000b97ad6064dbfb2f2
Content-Type: text/plain; charset="US-ASCII"; name="PS_v3_testcode_topup.txt"
Content-Disposition: attachment; filename="PS_v3_testcode_topup.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mn49klun0>
X-Attachment-Id: f_mn49klun0

ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvcHVibGljYXRpb24ub3V0IGIv
c3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9wdWJsaWNhdGlvbi5vdXQKaW5kZXggM2RkZWQ2N2Fi
OTguLjYwMDMzZWEyZmZmIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3B1
YmxpY2F0aW9uLm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3B1YmxpY2F0aW9u
Lm91dApAQCAtMjMwNyw2ICsyMzA3LDE3IEBAIFNFTEVDVCAqIEZST00gdGVzdF9ncHQoJ3B1Yl9u
b3JtYWwnLCAndGJsX25vcm1hbCcpOwogIHB1Yl9ub3JtYWwgfCB0Ymxfbm9ybWFsIHwgMSAgICAg
fCAoaWQgPCAxMCkKICgxIHJvdykKIAorU0VMRUNUICogRlJPTSB0ZXN0X2dwdCgncHViX25vcm1h
bCcsICd0YmxfcGFyZW50Jyk7IC0tIG5vIHJlc3VsdAorIHB1Ym5hbWUgfCByZWxuYW1lIHwgYXR0
cnMgfCBxdWFsIAorLS0tLS0tLS0tKy0tLS0tLS0tLSstLS0tLS0tKy0tLS0tLQorKDAgcm93cykK
KworU0VMRUNUICogRlJPTSB0ZXN0X2dwdCgncHViX3NjaGVtYScsICdncHRfdGVzdF9zY2gudGJs
X3NjaCcpOworICBwdWJuYW1lICAgfCByZWxuYW1lIHwgYXR0cnMgfCBxdWFsIAorLS0tLS0tLS0t
LS0tKy0tLS0tLS0tLSstLS0tLS0tKy0tLS0tLQorIHB1Yl9zY2hlbWEgfCB0Ymxfc2NoIHwgMSAg
ICAgfCAKKygxIHJvdykKKwogU0VMRUNUICogRlJPTSB0ZXN0X2dwdCgncHViX3NjaGVtYScsICd0
Ymxfbm9ybWFsJyk7IC0tIG5vIHJlc3VsdAogIHB1Ym5hbWUgfCByZWxuYW1lIHwgYXR0cnMgfCBx
dWFsIAogLS0tLS0tLS0tKy0tLS0tLS0tLSstLS0tLS0tKy0tLS0tLQpAQCAtMjM4OSw4ICsyNDAw
LDcgQEAgU0VMRUNUICogRlJPTSB0ZXN0X2dwdCgncHViX2FsbF9ub3ZpYV9yb290JywgJ3RibF9w
YXJ0MScpOwogKDEgcm93KQogCiAtLSBDbGVhbiB1cAotRFJPUCBGVU5DVElPTiB0ZXN0X2dwdCh0
ZXh0W10sIHJlbG5hbWUpOwotRVJST1I6ICB0eXBlICJyZWxuYW1lIiBkb2VzIG5vdCBleGlzdAor
RFJPUCBGVU5DVElPTiB0ZXN0X2dwdChwdWJuYW1lIHRleHQsIHJlbG5hbWUgdGV4dCk7CiBEUk9Q
IFBVQkxJQ0FUSU9OIHB1Yl9hbGw7CiBEUk9QIFBVQkxJQ0FUSU9OIHB1Yl9hbGxfbm92aWFfcm9v
dDsKIERST1AgUFVCTElDQVRJT04gcHViX2FsbF9leGNlcHQ7CmRpZmYgLS1naXQgYS9zcmMvdGVz
dC9yZWdyZXNzL3NxbC9wdWJsaWNhdGlvbi5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9wdWJs
aWNhdGlvbi5zcWwKaW5kZXggMTBmZDk3ZmU1NDQuLjk4MDExNzllNjQ1IDEwMDY0NAotLS0gYS9z
cmMvdGVzdC9yZWdyZXNzL3NxbC9wdWJsaWNhdGlvbi5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVz
cy9zcWwvcHVibGljYXRpb24uc3FsCkBAIC0xNDYzLDYgKzE0NjMsOSBAQCBCRUdJTiBBVE9NSUMK
IEVORDsKIAogU0VMRUNUICogRlJPTSB0ZXN0X2dwdCgncHViX25vcm1hbCcsICd0Ymxfbm9ybWFs
Jyk7CitTRUxFQ1QgKiBGUk9NIHRlc3RfZ3B0KCdwdWJfbm9ybWFsJywgJ3RibF9wYXJlbnQnKTsg
LS0gbm8gcmVzdWx0CisKK1NFTEVDVCAqIEZST00gdGVzdF9ncHQoJ3B1Yl9zY2hlbWEnLCAnZ3B0
X3Rlc3Rfc2NoLnRibF9zY2gnKTsKIFNFTEVDVCAqIEZST00gdGVzdF9ncHQoJ3B1Yl9zY2hlbWEn
LCAndGJsX25vcm1hbCcpOyAtLSBubyByZXN1bHQKIAogU0VMRUNUICogRlJPTSB0ZXN0X2dwdCgn
cHViX3BhcnRfcGFyZW50JywgJ3RibF9wYXJlbnQnKTsKQEAgLTE0ODYsNyArMTQ4OSw3IEBAIFNF
TEVDVCAqIEZST00gdGVzdF9ncHQoJ3B1Yl9hbGxfbm92aWFfcm9vdCcsICd0YmxfcGFyZW50Jyk7
IC0tIG5vIHJlc3VsdAogU0VMRUNUICogRlJPTSB0ZXN0X2dwdCgncHViX2FsbF9ub3ZpYV9yb290
JywgJ3RibF9wYXJ0MScpOwogCiAtLSBDbGVhbiB1cAotRFJPUCBGVU5DVElPTiB0ZXN0X2dwdCh0
ZXh0W10sIHJlbG5hbWUpOworRFJPUCBGVU5DVElPTiB0ZXN0X2dwdChwdWJuYW1lIHRleHQsIHJl
bG5hbWUgdGV4dCk7CiBEUk9QIFBVQkxJQ0FUSU9OIHB1Yl9hbGw7CiBEUk9QIFBVQkxJQ0FUSU9O
IHB1Yl9hbGxfbm92aWFfcm9vdDsKIERST1AgUFVCTElDQVRJT04gcHViX2FsbF9leGNlcHQ7Cg==
--000000000000b97ad6064dbfb2f2--