MIME-Version: 1.0
References: <OSBPR01MB255215A39F66932323295854F5DB2@OSBPR01MB2552.jpnprd01.prod.outlook.com>
 <CAA4eK1LOVQ+Qt-FEZPKaPPpggrPrE3AsFXkctp0tDm7CRcHt5Q@mail.gmail.com> <TYCPR01MB56938F06B84DD92A88234667F5A22@TYCPR01MB5693.jpnprd01.prod.outlook.com>
In-Reply-To: <TYCPR01MB56938F06B84DD92A88234667F5A22@TYCPR01MB5693.jpnprd01.prod.outlook.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Wed, 17 Jul 2024 14:28:20 +1000
Message-ID: <CAHut+Pv-up=MFqYXSVzCszdxU-n2kdcs3asbrAiKn4_z0VdrrA@mail.gmail.com>
Subject: Re: Slow catchup of 2PC (twophase) transactions on replica in LR
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, 
	"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, 
	Vitaly Davydov <v.davydov@postgrespro.ru>, Ajin Cherian <itsajin@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000083ac6061d69e62a"
Archived-At: <https://www.postgresql.org/message-id/CAHut%2BPv-up%3DMFqYXSVzCszdxU-n2kdcs3asbrAiKn4_z0VdrrA%40mail.gmail.com>
Precedence: bulk

--000000000000083ac6061d69e62a
Content-Type: multipart/alternative; boundary="000000000000083ac5061d69e628"

--000000000000083ac5061d69e628
Content-Type: text/plain; charset="UTF-8"

Hi, here is my review of the v18-0003 patch.

======
sgml/ref/alter_subscription.sgml

nitpick - some minor tweaks to the documentation text. I also added a link
back to the two_phase parameter. Please see the attached diffs file.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

--000000000000083ac5061d69e628
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi, here is my review of the v18-0003 patch.<br><br>=3D=3D=
=3D=3D=3D=3D<br>sgml/ref/alter_subscription.sgml<br><br>nitpick - some mino=
r tweaks to the documentation text. I also added a link back to the two_pha=
se parameter. Please see the attached diffs file.<br><br>=3D=3D=3D=3D=3D=3D=
<br>Kind Regards,<br>Peter Smith.<br>Fujitsu Australia</div>

--000000000000083ac5061d69e628--
--000000000000083ac6061d69e62a
Content-Type: text/plain; charset="US-ASCII"; name="PS_NITPICKS_20240717_2PC_V180003.txt"
Content-Disposition: attachment; 
	filename="PS_NITPICKS_20240717_2PC_V180003.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_lypcbtcn0>
X-Attachment-Id: f_lypcbtcn0

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfc3Vic2NyaXB0aW9uLnNnbWwgYi9k
b2Mvc3JjL3NnbWwvcmVmL2FsdGVyX3N1YnNjcmlwdGlvbi5zZ21sCmluZGV4IGUwMjFmODcuLjU4
ZGI5N2YgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfc3Vic2NyaXB0aW9uLnNn
bWwKKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9hbHRlcl9zdWJzY3JpcHRpb24uc2dtbApAQCAtMjU2
LDE0ICsyNTYsMTUgQEAgQUxURVIgU1VCU0NSSVBUSU9OIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFy
YW1ldGVyIj5uYW1lPC9yZXBsYWNlYWJsZT4gUkVOQU1FIFRPIDwKICAgICAgPC9wYXJhPgogCiAg
ICAgIDxwYXJhPgotICAgICAgVGhlIDxsaXRlcmFsPnR3b19waGFzZTwvbGl0ZXJhbD4gcGFyYW1l
dGVyIGNhbiBvbmx5IGJlIGFsdGVyZWQgd2hlbiB0aGUKLSAgICAgIHN1YnNjcmlwdGlvbiBpcyBk
aXNhYmxlZC4gV2hlbiBhbHRlcmluZyB0aGUgcGFyYW1ldGVyIGZyb20gPGxpdGVyYWw+dHJ1ZTwv
bGl0ZXJhbD4KKyAgICAgIFRoZSA8bGluayBsaW5rZW5kPSJzcWwtY3JlYXRlc3Vic2NyaXB0aW9u
LXBhcmFtcy13aXRoLXR3by1waGFzZSI+PGxpdGVyYWw+dHdvX3BoYXNlPC9saXRlcmFsPjwvbGlu
az4KKyAgICAgIHBhcmFtZXRlciBjYW4gb25seSBiZSBhbHRlcmVkIHdoZW4gdGhlIHN1YnNjcmlw
dGlvbiBpcyBkaXNhYmxlZC4KKyAgICAgIFdoZW4gYWx0ZXJpbmcgdGhlIHBhcmFtZXRlciBmcm9t
IDxsaXRlcmFsPnRydWU8L2xpdGVyYWw+CiAgICAgICB0byA8bGl0ZXJhbD5mYWxzZTwvbGl0ZXJh
bD4sIHRoZSBiYWNrZW5kIHByb2Nlc3MgY2hlY2tzIGZvciBhbnkgaW5jb21wbGV0ZQogICAgICAg
cHJlcGFyZWQgdHJhbnNhY3Rpb25zIGRvbmUgYnkgdGhlIGxvZ2ljYWwgcmVwbGljYXRpb24gd29y
a2VyIChmcm9tIHdoZW4KICAgICAgIDxsaXRlcmFsPnR3b19waGFzZTwvbGl0ZXJhbD4gcGFyYW1l
dGVyIHdhcyBzdGlsbCA8bGl0ZXJhbD50cnVlPC9saXRlcmFsPikKLSAgICAgIGFuZCwgaWYgYW55
IGFyZSBmb3VuZCwgdGhpcyBjb21tYW5kIGlzIGZhaWxlZCB3aXRoIGFuIGVycm9yLiBJbiB0aGlz
Ci0gICAgICBjYXNlLCB5b3UgY2FuIHJlc29sdmUgcHJlcGFyZWQgdHJhbnNhY3Rpb25zIG9uIHRo
ZSBwdWJsaXNoZXIgbm9kZSBvcgotICAgICAgbWFudWFsbHkgcm9sbCBiYWNrIHRoZW0gb24gdGhl
IHN1YnNjcmliZXIuIEFmdGVyIHRoZSBhbHRlcmluZyBmcm9tCisgICAgICBhbmQsIGlmIGFueSBh
cmUgZm91bmQsIGFuIGVycm9yIGlzIHJlcG9ydGVkLiBJZiB0aGlzIGhhcHBlbnMsIHlvdSBjYW4K
KyAgICAgIHJlc29sdmUgcHJlcGFyZWQgdHJhbnNhY3Rpb25zIG9uIHRoZSBwdWJsaXNoZXIgbm9k
ZSBvcgorICAgICAgbWFudWFsbHkgcm9sbCBiYWNrIHRoZW0gb24gdGhlIHN1YnNjcmliZXIsIHRo
ZW4gdHJ5IGFnYWluLiBBZnRlciB0aGUgYWx0ZXJpbmcgZnJvbQogICAgICAgPGxpdGVyYWw+dHJ1
ZTwvbGl0ZXJhbD4gdG8gPGxpdGVyYWw+ZmFsc2U8L2xpdGVyYWw+LCB0aGUgcHVibGlzaGVyIHdp
bGwKICAgICAgIHJlcGxpY2F0ZSB0cmFuc2FjdGlvbnMgYWdhaW4gd2hlbiB0aGV5IGFyZSBjb21t
aXR0ZWQuCiAgICAgIDwvcGFyYT4K
--000000000000083ac6061d69e62a--