public inbox for [email protected]help / color / mirror / Atom feed
DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS" 5+ messages / 3 participants [nested] [flat]
* DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS" @ 2026-04-01 06:16 Peter Smith <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Peter Smith @ 2026-04-01 06:16 UTC (permalink / raw) To: PostgreSQL Hackers <[email protected]> Hi. I happened to notice that the "DROP PUBLICATION IF EXISTS" parameter is documented [1] ------ IF EXISTS Do not throw an error if the publication does not exist. A notice is issued in this case. ------ But, the equivalent "DROP SUBSCRIPTION IF EXISTS" parameter description is missing [2]. ~~~ PSA a patch to add similar documentation for DROP SUBSCRIPTION IF EXISTS. ====== [1] https://www.postgresql.org/docs/devel/sql-droppublication.html [2] https://www.postgresql.org/docs/devel/sql-dropsubscription.html Kind Regards, Peter Smith. Fujitsu Australia Attachments: [application/octet-stream] v1-0001-DOCS-Add-missing-description-for-DROP-SUBSCRIPTIO.patch (1.1K, 2-v1-0001-DOCS-Add-missing-description-for-DROP-SUBSCRIPTIO.patch) download | inline diff: From 76b7cd9a7a70d1db32504eb7f12ca91ea9a21dfc Mon Sep 17 00:00:00 2001 From: Peter Smith <[email protected]> Date: Wed, 1 Apr 2026 17:10:37 +1100 Subject: [PATCH v1] DOCS - Add missing description for DROP SUBSCRIPTION IF EXISTS --- doc/src/sgml/ref/drop_subscription.sgml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/doc/src/sgml/ref/drop_subscription.sgml b/doc/src/sgml/ref/drop_subscription.sgml index d4f54c7170e..6e84bb0a256 100644 --- a/doc/src/sgml/ref/drop_subscription.sgml +++ b/doc/src/sgml/ref/drop_subscription.sgml @@ -49,6 +49,16 @@ DROP SUBSCRIPTION [ IF EXISTS ] <replaceable class="parameter">name</replaceable <title>Parameters</title> <variablelist> + <varlistentry> + <term><literal>IF EXISTS</literal></term> + <listitem> + <para> + Do not throw an error if the subscription does not exist. A notice is + issued in this case. + </para> + </listitem> + </varlistentry> + <varlistentry> <term><replaceable class="parameter">name</replaceable></term> <listitem> -- 2.47.3 ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS" @ 2026-04-01 06:43 Chao Li <[email protected]> parent: Peter Smith <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Chao Li @ 2026-04-01 06:43 UTC (permalink / raw) To: Peter Smith <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> > On Apr 1, 2026, at 14:16, Peter Smith <[email protected]> wrote: > > Hi. > > I happened to notice that the "DROP PUBLICATION IF EXISTS" parameter > is documented [1] > ------ > IF EXISTS > Do not throw an error if the publication does not exist. A notice is > issued in this case. > ------ > > But, the equivalent "DROP SUBSCRIPTION IF EXISTS" parameter > description is missing [2]. > > ~~~ > > PSA a patch to add similar documentation for DROP SUBSCRIPTION IF EXISTS. > > ====== > [1] https://www.postgresql.org/docs/devel/sql-droppublication.html > [2] https://www.postgresql.org/docs/devel/sql-dropsubscription.html > > Kind Regards, > Peter Smith. > Fujitsu Australia > <v1-0001-DOCS-Add-missing-description-for-DROP-SUBSCRIPTIO.patch> Looks good. The patch uses the same phrase for “if exists” as the doc of “drop publication”. And I verified that a notice is issued: ``` evantest=# drop publication if exists aaa; NOTICE: publication "aaa" does not exist, skipping DROP PUBLICATION evantest=# drop subscription if exists aaa; NOTICE: subscription "aaa" does not exist, skipping DROP SUBSCRIPTION ``` Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS" @ 2026-04-01 14:11 Nathan Bossart <[email protected]> parent: Chao Li <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Nathan Bossart @ 2026-04-01 14:11 UTC (permalink / raw) To: Chao Li <[email protected]>; +Cc: Peter Smith <[email protected]>; PostgreSQL Hackers <[email protected]> On Wed, Apr 01, 2026 at 02:43:15PM +0800, Chao Li wrote: > On Apr 1, 2026, at 14:16, Peter Smith <[email protected]> wrote: >> PSA a patch to add similar documentation for DROP SUBSCRIPTION IF EXISTS. > > Looks good. The patch uses the same phrase for “if exists” as the doc of > “drop publication”. And I verified that a notice is issued: Thanks. Will commit/back-patch shortly. -- nathan ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS" @ 2026-04-01 14:54 Nathan Bossart <[email protected]> parent: Nathan Bossart <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Nathan Bossart @ 2026-04-01 14:54 UTC (permalink / raw) To: Chao Li <[email protected]>; +Cc: Peter Smith <[email protected]>; PostgreSQL Hackers <[email protected]> On Wed, Apr 01, 2026 at 09:11:35AM -0500, Nathan Bossart wrote: > Thanks. Will commit/back-patch shortly. Done. -- nathan ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS" @ 2026-04-01 22:36 Peter Smith <[email protected]> parent: Nathan Bossart <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Peter Smith @ 2026-04-01 22:36 UTC (permalink / raw) To: Nathan Bossart <[email protected]>; +Cc: Chao Li <[email protected]>; PostgreSQL Hackers <[email protected]> On Thu, Apr 2, 2026 at 1:54 AM Nathan Bossart <[email protected]> wrote: > > On Wed, Apr 01, 2026 at 09:11:35AM -0500, Nathan Bossart wrote: > > Thanks. Will commit/back-patch shortly. > > Done. > Thanks for pushing! ====== Kind Regards, Peter Smith. Fujitsu Australia ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-04-01 22:36 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-01 06:16 DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS" Peter Smith <[email protected]> 2026-04-01 06:43 ` Chao Li <[email protected]> 2026-04-01 14:11 ` Nathan Bossart <[email protected]> 2026-04-01 14:54 ` Nathan Bossart <[email protected]> 2026-04-01 22:36 ` Peter Smith <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox