MIME-Version: 1.0
References: 
 <CAApHDvoFSu5zLFvx96aZ5wvL7tcB9aR2hBPCaMPs8D_f0Z7eSw@mail.gmail.com>
In-Reply-To: 
 <CAApHDvoFSu5zLFvx96aZ5wvL7tcB9aR2hBPCaMPs8D_f0Z7eSw@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Wed, 22 Apr 2026 11:17:31 +1000
Message-ID: 
 <CAHut+PvGk6H=B72_3YmyyZp8ZW=aYoSsoGrtiBEuMNUHHXXFmQ@mail.gmail.com>
Subject: Re: Get rid of translation strings that only contain punctuation
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
	Amit Kapila <amit.kapila16@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPvGk6H%3DB72_3YmyyZp8ZW%3DaYoSsoGrtiBEuMNUHHXXFmQ%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 22, 2026 at 10:30=E2=80=AFAM David Rowley <dgrowleyml@gmail.com=
> wrote:
>
> (Follow-on work from [1])
>
> We've got a few parts of the code that translate strings that contain
> only a single punctuation character. I'm not a translator, but I
> suspect that these would be tricky to deal with as such short strings
> could be used for various different things, and if the required
> translation was to differ between requirements, then you're out of
> luck.
>
> I looked at: git grep -A 1 "msgid \", \"" and I see French is the only
> translation to do anything different with the ", " string, and only in
> psql.
>
> src/bin/psql/po/fr.po:msgid ", "
> src/bin/psql/po/fr.po-msgstr " , "
>
> This is used for suffixing "unique" or "unique nulls not distinct". I
> adjusted the logic there to get rid of the short translation string.
>
> Quite a few are new to v19: fd366065e (AmitK), 48efefa6c (AmitK),
> 0fc33b005 (PeterE)
> The relation.c one is from v18: 8fcd80258 (AmitK)
> The describe.c one is from v15: 94aa7cc5f (PeterE)
>
> Should we get rid of these?
>

This question overlaps with another thread of mine [1].

There, I was told that a punctuation double-quote (")  *should* be translat=
ed.

OTOH, I did not see why the comma separator (,) should be translated
-- my patch did so only to be the same as existing code.

=3D=3D=3D=3D=3D=3D
[1] https://www.postgresql.org/message-id/CAHut%2BPui7RaQ8OfJEVn2ry-ykjnGc%=
2B3ujsFmcHDFw9FsXw_tRw%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia