MIME-Version: 1.0
References: 
 <CAJDiXgi=Vcp1nh2UoZ5=7BCoR+uXoYzqMsfOfga-XxSUHjFj5Q@mail.gmail.com>
In-Reply-To: 
 <CAJDiXgi=Vcp1nh2UoZ5=7BCoR+uXoYzqMsfOfga-XxSUHjFj5Q@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Mon, 30 Mar 2026 08:51:49 +1100
Message-ID: 
 <CAHut+PvX8s0KBFeKOq+O1T+R0pdBGOp445QK1p6nVScnxSLFaA@mail.gmail.com>
Subject: Re: Get rid of redundant StringInfo accumulation
To: Daniil Davydov <3danissimo@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPvX8s0KBFeKOq%2BO1T%2BR0pdBGOp445QK1p6nVScnxSLFaA%40mail.gmail.com>
Precedence: bulk

On Sun, Mar 29, 2026 at 11:26=E2=80=AFPM Daniil Davydov <3danissimo@gmail.c=
om> wrote:
>
> Hi,
>
> I have noticed that there are several places in the code where we are
> creating StringInfo in order to log its content. But this work may be was=
ted
> if the specified log level is not interesting both for client and server.
> I.e. now we can allocate memory for StringInfo which will never be displa=
yed.
>
> I think that at first we should check whether log level is interesting an=
d
> only then start creating the StringInfo.
>
> Please, see the attached patch that fixes it. I hope I have found all the
> places where it would be appropriate.
>

Hi,

1.
@@ -108,6 +108,9 @@ ReportApplyConflict(EState *estate, ResultRelInfo
*relinfo, int elevel,
  Relation localrel =3D relinfo->ri_RelationDesc;
  StringInfoData err_detail;

+ if (!message_level_is_interesting(elevel))
+ return;
+

AFAICT, this change will also cause the
pgstat_report_subscription_conflict() to be skipped. But that call was
not associated with the log level.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia