Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTVSM-005Lu2-UW for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 00:54:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uTVSK-00GF0s-Sy for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 00:54:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTVSK-00GF0k-FJ for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 00:54:41 +0000 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uTVSH-003Saz-1L for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 00:54:38 +0000 Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-4a58d95ea53so39897751cf.0 for ; Sun, 22 Jun 2025 17:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750640076; x=1751244876; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4fGOy1PsZSBkzE1BZTYdShai0DBKM6Sb6rU+gWNwahY=; b=GSoCkmR4W47vDwLG51+2zcfjZEKDckS+bmKettQyr3wh/COhUWtuNYRa4wxUxjMlx5 l2ETODHdOWSb28xsjUjlHx45iEiiA1jOro65ie3pw8mTSQHHBEHgQq68/Nvkg1DnlviC HSOC318VVYo5NfrnmFT9Dlpmu6MmNF5OPM0whIolQMAkOrA5e67Yi/BNs/JmRYgINq0D O3FL3vSsh2R/u373oILcLYLivpIjbsygy3Oi/DXk21YOZySZgDWbWjZTEGPYUX8o5eKo rYcBTdSEXE70zLXpJrEF31wBI2L0tBCcfDZG23FYoLPK6RSCKVRqPMZu2csb2+BdVTaE UuDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750640076; x=1751244876; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4fGOy1PsZSBkzE1BZTYdShai0DBKM6Sb6rU+gWNwahY=; b=hZamPQEb5avbaDfY4qXDHV5q1cqjPg+IiwB6CSzQqvt+iITuAMvOkZkgYQaAI86Z87 SEW7e09lSx5su0zAlssFH2ijdVw7UmsZfM1XIbjy4h8hBldV1PgGk7w2jLBCCoeIVF3b oPO2yazWr8pyjsOUyXeDiTE7Y6ZrzmaPQmcrlBw0ZyjWYqfGu+yv/x5ZRu64f3p8lHbv d4CqF6LXejT1u+rGYNVdk5HJW5orZLgaU5HnkOCQOWgIwtmS7xh77XiO+uDk+GJBAjfY IviQR5b4UZIKVyysoKj/Yw7yb04Qn8O+FFXwy8ZoR6/9Xo8PYyTyOqvU+8PwEZrQu8wO gpzA== X-Forwarded-Encrypted: i=1; AJvYcCVqAy+gtkipRVJ/eZXB4d7WoLui3hyN+bou2NpDVrv+fRHYUlbcIpDHlEuqLaFbiMWqXnxXcHz2r5ezhQhe@lists.postgresql.org X-Gm-Message-State: AOJu0YwXLvO2LWMFoC3UiLQZSlwfLGO6YDXOShWzsw1AousHH7xMKAzI 4DzrfQOa/Q1vxNgn1H/AUPAXxjzx/Xwt+6hqUNcmWXfKTsctGc8y3VE6eXb/Lp4wEgemQFBTjqv qUnusXoFpJKAr5BFTL33uF60u/L0FUa8= X-Gm-Gg: ASbGncsudsD+dviLl3GHpQyXSnT3eeYeCJxIfcETZWTCv+v2hCZUoSV7PaJrb7jG7dR BQm6yC5xbfIPGbZ2vdAFg8fe1op/iZeNNvJCfmobIIm37ypvWTq09eWgbrxMeH/HCycDmnM330v WnbIwoaCgWv6goTtJdjk0lI5lnlui/42AvVWYwIZIowxg5Ud63/TxTq5y/iVKnleWaew2WqAQwN WH4 X-Google-Smtp-Source: AGHT+IHL5qzRahh5BbPUFVQHq2Qvaebe2HZYAmFxR+UA3cWKdyp10i0E5Oz0g23MMgVfgmq47YTyzegRMwFstIxbd/8= X-Received: by 2002:ac8:5dc7:0:b0:4a4:31e0:c824 with SMTP id d75a77b69052e-4a77c37bd17mr184727821cf.19.1750640076567; Sun, 22 Jun 2025 17:54:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Smith Date: Mon, 23 Jun 2025 10:54:10 +1000 X-Gm-Features: AX0GCFsRW81eZrfbqplyQjE4phu0ss-kQY9PoNrTEMD35oILlS26-gHhcUdY_CA Message-ID: Subject: Re: Skipping schema changes in publication To: Shlok Kyal Cc: Amit Kapila , "Zhijie Hou (Fujitsu)" , vignesh C , YeXiu <1518981153@qq.com>, Ian Lawrence Barwick , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > > > 5. > > > + > > > + Alter publication mypublication to add table > > > + users except column > > > + security_pin: > > > + > > > +ALTER PUBLICATION production_publication ADD TABLE users EXCEPT (security_pin); > > > > > > Those tags don't seem correct. e.g. "users" and "security_pin" are not > > > (???). > > > > > > Perhaps, every other example here is wrong too and you just copied > > > them? Anyway, something here looks wrong to me. > > > > > I saw different documents and usage of tags seems not well defined. > > For example for table we are using tags in document > > create_publication.sgml, update.sgml is used, in document > > table.sgml, advanced.sgml is used, and in > > logical-replication.sgml is used. Similarly for column > > names , or are used in different > > parts of the document. > > > > I kept the changed tag to for the column for this patch. > > Do you have any suggestions? > > No, for this patch I think it is best that you just follow nearby code > (as you are already doing). I plan to raise another thread to ask what > are the guidelines for this sort of markup which is currently used > inconsistently in different places. > FYI - I created a new thread asking this markup question [1]. ====== [1] https://www.postgresql.org/message-id/CAHut%2BPvtf24r%2BbdPgBind84dBLPvgNL7aB%2B%3DHxAUupdPuo2gRg%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia