MIME-Version: 1.0
References: 
 <CAHut+PszSntkUgN+Qa9matGY6MLEoFGSuVbuKDgnnTdZ7YPRwg@mail.gmail.com>
 <74359511-9F84-481E-B133-D2F68775D1CE@gmail.com>
 <CAHut+PvAaR3h1wyGgO+761Oa_ywjFToX9AmKNnHhQX6e-N=k_w@mail.gmail.com>
 <CAHut+PtBNKnBVcidXbx4c-ifq44KRb+J4dCUh-2-2sccy0w3Pg@mail.gmail.com>
 <CAHut+Pt=M3AFJjSFHAzgvuxtuQJDnB38FPrA9EH3PsSvZkLcdw@mail.gmail.com>
 <CALDaNm06akDhu1RVVRhYuSXPT-TsWZyCOSci8tFCOvfiYaP4AQ@mail.gmail.com>
In-Reply-To: 
 <CALDaNm06akDhu1RVVRhYuSXPT-TsWZyCOSci8tFCOvfiYaP4AQ@mail.gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
Date: Tue, 14 Apr 2026 16:28:37 +1000
Message-ID: 
 <CAHut+PvmHoOonAosaO1YUnU7fa+4BpUZGA4oHq7pPF7_=+FrEQ@mail.gmail.com>
Subject: Re: Add missing period to DETAIL messages
To: vignesh C <vignesh21@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPvmHoOonAosaO1YUnU7fa%2B4BpUZGA4oHq7pPF7_%3D%2BFrEQ%40mail.gmail.com>
Precedence: bulk

On Tue, Apr 14, 2026 at 3:51=E2=80=AFPM vignesh C <vignesh21@gmail.com> wro=
te:
>
> On Mon, 13 Apr 2026 at 06:36, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > (here's the missing attachment)
> >
> > On Mon, Apr 13, 2026 at 11:04=E2=80=AFAM Peter Smith <smithpb2250@gmail=
.com> wrote:
> > >
> > > Found one more oversight.
> > >
> > > PSA v3.
>

Hi Vignesh.

Thanks for your review!

I deliberately avoided any potentially controversial or troublesome
modifications.

So I have already seen all those you questioned and chose to avoid
them for various reasons.

In general, I did not put a period on any message that ended with a
":" followed by some substitution, for fear that the period (.) might
ambiguously appear to be part of the substituted value. Below are some
other reasons...

> Should these also be updated:
> 1) ginfuncs.c
> if (opaq->flags !=3D (GIN_DATA | GIN_LEAF | GIN_COMPRESSED))
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("input page is not a compressed GIN data leaf page"),
> errdetail("Flags %04X, expected %04X",
>    opaq->flags,
>    (GIN_DATA | GIN_LEAF | GIN_COMPRESSED))));
>

Yeah. This was one I was wavering about. I didn't want to be worried
that the '.' might somehow mess with the last format specifier. And
escaping the period using "\." just seemed overkill. I concluded there
seemed to be more reasons to avoid changing it than to change it.

> 2) shell_archive.c
> ereport(lev,
> (errmsg("archive command failed with exit code %d",
> WEXITSTATUS(rc)),
> errdetail("The failed archive command was: %s",
>    xlogarchcmd)));

Not done because I didn't want it to appear that the '.' might be part
of the substituted command.

>
> 3) shell_archive.c
> ereport(lev,
> (errmsg("archive command was terminated by exception 0x%X",
> WTERMSIG(rc)),
> errhint("See C include file \"ntstatus.h\" for a description of the
> hexadecimal value."),
> errdetail("The failed archive command was: %s",
>    xlogarchcmd)));

Not done because I didn't want it to appear that the '.' might be part
of the substituted command.

>
> 4) shell_archive.c
> ereport(lev,
> (errmsg("archive command was terminated by signal %d: %s",
> WTERMSIG(rc), pg_strsignal(WTERMSIG(rc))),
> errdetail("The failed archive command was: %s",
>    xlogarchcmd)));
>

Not done because I didn't want it to appear that the '.' might be part
of the substituted command.

> 5) shell_archive.c
> ereport(lev,
> (errmsg("archive command exited with unrecognized status %d",
> rc),
> errdetail("The failed archive command was: %s",
>    xlogarchcmd)));
>

Not done because I didn't want it to appear that the '.' might be part
of the substituted command.

> 6) matview.c
> ereport(ERROR,
> (errcode(ERRCODE_CARDINALITY_VIOLATION),
> errmsg("new data for materialized view \"%s\" contains duplicate rows
> without any null columns",
> RelationGetRelationName(matviewRel)),
> errdetail("Row: %s",
>    SPI_getvalue(SPI_tuptable->vals[0], SPI_tuptable->tupdesc, 1))));
>

Not done because I didn't want it to appear that the '.' might be part
of the substituted row value.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia