MIME-Version: 1.0
From: Peter Smith <smithpb2250@gmail.com>
Date: Wed, 1 Apr 2026 14:48:08 +1100
Message-ID: 
 <CAHut+Pvp7jYcaiZ3pXedXgLcWZWDBLXFUK05JtZpGv3Mj=UOjw@mail.gmail.com>
Subject: Redundant/mis-use of _(x) gettext macro?
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000004ff128064e5df5c7"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPvp7jYcaiZ3pXedXgLcWZWDBLXFUK05JtZpGv3Mj%3DUOjw%40mail.gmail.com>
Precedence: bulk

--0000000000004ff128064e5df5c7
Content-Type: text/plain; charset="UTF-8"

Hi.

As originally reported [1] in the EXCEPT (TABLE ...) thread, I felt
the _() gettext macro is mis-used when it contains nothing but a
quoted format string.

AFAIK the purpose of using gettext (e.g. the "_(x)" macro) is for
marking the string for i18n translation. But there's nothing even to
translate here.

Only 2 examples were found like this. Granted, this is probably not
very harmful, but IMO it's better to patch the mis-use to prevent it
from propagating.

PSA the patch for more details.

======
[1] https://www.postgresql.org/message-id/CAHut%2BPtVaOYVP1R0TOoNh5G9CUBurrP%3D6i7fJCdfWEZiqVCRvw%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

--0000000000004ff128064e5df5c7
Content-Type: application/octet-stream;
	name="v1-0001-misuse-of-gettext-macro.patch"
Content-Disposition: attachment;
	filename="v1-0001-misuse-of-gettext-macro.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnfi7sc40>
X-Attachment-Id: f_mnfi7sc40

RnJvbSBiZDJhNWJhOWU3ZDY1YjRmYzZlOTY0MDQ4NDM3YWQ3NzYyNDZiMDY3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBTbWl0aCA8cGV0ZXIuYi5zbWl0aEBmdWppdHN1LmNv
bT4KRGF0ZTogV2VkLCAxIEFwciAyMDI2IDE0OjQwOjE4ICsxMTAwClN1YmplY3Q6IFtQQVRDSCB2
MV0gbWlzdXNlIG9mIGdldHRleHQgbWFjcm8KCi0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFi
bGVjbWRzLmMgICAgICAgICAgIHwgMiArLQogc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNh
bC9yZWxhdGlvbi5jIHwgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIg
ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRz
LmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYwppbmRleCA0ZWU1OGZlYjEwZS4u
NjUyMjliNzM4NGUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5j
CisrKyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jCkBAIC0yMDczMiw3ICsyMDcz
Miw3IEBAIEFURXhlY0F0dGFjaFBhcnRpdGlvbihMaXN0ICoqd3F1ZXVlLCBSZWxhdGlvbiByZWws
IFBhcnRpdGlvbkNtZCAqY21kLAogCiAJCQlmaXJzdCA9IGZhbHNlOwogCi0JCQlhcHBlbmRTdHJp
bmdJbmZvKCZwdWJuYW1lcywgXygiXCIlc1wiIiksIHB1Ym5hbWUpOworCQkJYXBwZW5kU3RyaW5n
SW5mbygmcHVibmFtZXMsICJcIiVzXCIiLCBwdWJuYW1lKTsKIAkJfQogCiAJCWVyZXBvcnQoRVJS
T1IsCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL3JlbGF0aW9u
LmMgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL3JlbGF0aW9uLmMKaW5kZXggMGIx
ZDgwYjViMGYuLjAyZTYwZGRmNTE2IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlv
bi9sb2dpY2FsL3JlbGF0aW9uLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNh
bC9yZWxhdGlvbi5jCkBAIC0yNTMsNyArMjUzLDcgQEAgbG9naWNhbHJlcF9nZXRfYXR0cnNfc3Ry
KExvZ2ljYWxSZXBSZWxhdGlvbiAqcmVtb3RlcmVsLCBCaXRtYXBzZXQgKmF0dHMpCiAJCQkvKiB0
cmFuc2xhdG9yOiBUaGlzIGlzIGEgc2VwYXJhdG9yIGluIGEgbGlzdCBvZiBlbnRpdHkgbmFtZXMu
ICovCiAJCQlhcHBlbmRTdHJpbmdJbmZvU3RyaW5nKCZhdHRzYnVmLCBfKCIsICIpKTsKIAotCQlh
cHBlbmRTdHJpbmdJbmZvKCZhdHRzYnVmLCBfKCJcIiVzXCIiKSwgcmVtb3RlcmVsLT5hdHRuYW1l
c1tpXSk7CisJCWFwcGVuZFN0cmluZ0luZm8oJmF0dHNidWYsICJcIiVzXCIiLCByZW1vdGVyZWwt
PmF0dG5hbWVzW2ldKTsKIAl9CiAKIAlyZXR1cm4gYXR0c2J1Zi5kYXRhOwotLSAKMi40Ny4zCgo=
--0000000000004ff128064e5df5c7--