Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vdU8Q-001Aqd-01 for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Jan 2026 14:03:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vdU8O-00EGBQ-0h for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Jan 2026 14:03:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vdU8N-00EGBI-2g for pgsql-hackers@lists.postgresql.org; Wed, 07 Jan 2026 14:03:36 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vdU8L-0055ec-27 for pgsql-hackers@postgresql.org; Wed, 07 Jan 2026 14:03:36 +0000 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-7c75b829eb6so1337336a34.1 for ; Wed, 07 Jan 2026 06:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tigerdata.com; s=google; t=1767794611; x=1768399411; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bAYHxUn6WbxeHp3m1+dpNh6d+HfhvuecaBKE+sdFJ9A=; b=EsV8SlxqQZIBuG6ew9sy5ZgYSST46MEV5vMdvifzUxsLkQVnuzUnZM8LNx+IbAwpw6 /WKUr3f7C49q785ryn5t/TtHHv4TgMhYvhpooAjCW9zVUfYUNiqFlqWBX4gkkZzRT1IE EmfQHFBu6pmsUn9AeeDOXtQuTrJLWlqJ90qg5yIW213V9N31veWRsm93aLra1n424IXT 2PfOuE6JKL5z2NjsnN/+jVyMQldkUbUydKqR8+eIWQZ6wHjWsoXmicHPpZnkyoGDizgz 561I4Y/gfxF/4Uiu+aQjLBvbdV41zlrl61CozrBpqGQ23QK5u7xdclE69FjVIK0QNBPV 00cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767794611; x=1768399411; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bAYHxUn6WbxeHp3m1+dpNh6d+HfhvuecaBKE+sdFJ9A=; b=jdbRsskapHn9S1IYfuqrg7abs+JfBN87UTBI5xbKRms9TW8zn+Yq35LCEKn4C2huhM 8UZm7ic+vtpHljPIsZv3bxyUeGHFYNB2MXPG/g4unCIMpq37I0GQJ1PbqU/pQHkVLF+k WIw945SUc6zLyrxXmSEAlMM4vT1MDjc06EYKTzRfJTl5GMh+tb299oHx0o/lX8m/MU8x LATyd3xRGZ8sbaiYRmcNTfCWnKD5PkyicjJU7/aba3sGUuK5UfXmHEqMF/aWW7HrBl6D YKTM7QmVh8L6gW8QXdj3mO1/m9v24bUyAVdX8YRTNYGm3/U+hW/hpfm6tjrT5R0xPmLX R+NQ== X-Gm-Message-State: AOJu0YxkK1hpTjxq4yrM6QLyQqFuYYSEcwwKM8vmkVtLLnD9GALbVRVj Bb9xXSz77l/e+Hc0c2zARg0rlx99jonH5aA5tf95lTV3+gyRXtX2qletBU9wUmbvuwFuTVaJG95 OaK/Ktvw7IEhOa1tBkfiYw5GSaWK5bCrE5Dt1BNAx9TOno8ifAzFKAjaIZg== X-Gm-Gg: AY/fxX4mT/gfTibILwcN/FPRFYLmfQn9bVZZv7yfMNJ9PdXA6iZwSf8I7AsyPyYd6sx QQVKFXKEZf/D7D86QXZR9hb+5sAWM9B0UPyvsDVJwCRHqMtyUBGElBKOlj+Bvr3JdmYFSTvOe+Z lfLRlCilxwWpPIOzyiLR+LLYpSYZyXMvzFsTU3Hdzyr5usS8X2c4RFjkYe0WUjTFX532SC8UYIi uchqaD19NEpqJo0lEozPZf041eTj2yCCiqnOsjDRZrjSVSx8fqhp6M31jHBCZEB48Wa4dJPMQ9p 42P4Sq0= X-Google-Smtp-Source: AGHT+IFnGBhCHzFpfCaFuFwrB9b361FWwwYQ6fPxW42nAyJqLkQCYZY9dU7Tu8uDyo+fiCzatf8HCEezk+PofBED6OY= X-Received: by 2002:a05:6830:230e:b0:7ca:ee2d:fd8d with SMTP id 46e09a7af769-7ce508d7fb0mr1454791a34.9.1767794611244; Wed, 07 Jan 2026 06:03:31 -0800 (PST) MIME-Version: 1.0 References: <2869012.1767023578@sss.pgh.pa.us> In-Reply-To: From: Aleksander Alekseev Date: Wed, 7 Jan 2026 17:03:19 +0300 X-Gm-Features: AQt7F2pgxHdKE-Ika3VwqLYhXIa-VGd92M15djvawGfHMECxA06FNpUtVbXuwCU Message-ID: Subject: Re: Define DatumGetInt8 function. To: pgsql-hackers Cc: Kirill Reshke , David Rowley , Tom Lane Content-Type: multipart/mixed; boundary="000000000000d6fd7a0647ccc1a2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000d6fd7a0647ccc1a2 Content-Type: text/plain; charset="UTF-8" Hi, > Hmm, v1 looks good and self-contained to me. Like, anyway, making two > commits (one for signed Int8 and one for unsigned) here is better for > sake of atomicy? > Anyway, I can see there are users of UInt8GetDatum, which are [0] and > forks of Greenplum. So, I am not super-sure removing UInt8* is > desirable. Fair enough. Let it be a separate patch then. -- Best regards, Aleksander Alekseev --000000000000d6fd7a0647ccc1a2 Content-Type: text/x-patch; charset="US-ASCII"; name="v2-0002-Remove-DatumGetUInt8-and-UInt8GetDatum.patch" Content-Disposition: attachment; filename="v2-0002-Remove-DatumGetUInt8-and-UInt8GetDatum.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mk439a4k1 RnJvbSA3MjgxODQ5MTBiNzI3NGQ2NGM0ZWEyNWVkM2ZkMmJiZmI4NzViOGI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2Vy ZGF0YS5jb20+CkRhdGU6IFdlZCwgNyBKYW4gMjAyNiAxNjozNjozNiArMDMwMApTdWJqZWN0OiBb UEFUQ0ggdjIgMi8yXSBSZW1vdmUgRGF0dW1HZXRVSW50OCBhbmQgVUludDhHZXREYXR1bQoKVGhl c2UgZnVuY3Rpb25zIHdlcmUgcmFyZWx5IHVzZWQgYW5kIGNyZWF0ZWQgc29tZSBjb25mdXNpb24u IFJlcGxhY2UgdGhlIGZldwpleGlzdGluZyB1c2FnZXMgd2l0aCBtb3JlIGFwcHJvcHJpYXRlIGFs dGVybmF0aXZlczoKCi0gdXNlIEludDE2R2V0RGF0dW0gaW4gaGVhcGZ1bmNzLmMKLSB1c2UgQ2hh ckdldERhdHVtL0RhdHVtR2V0Q2hhciBpbiBuYnRjb21wYXJlLmMKCkFsc28gdXBkYXRlIHRoZSBj aGFyIGluY3JlbWVudC9kZWNyZW1lbnQgZnVuY3Rpb25zIHRvIHVzZSBwcm9wZXIgU0NIQVJfTUlO IGFuZApTQ0hBUl9NQVggYm91bmRhcmllcyBpbnN0ZWFkIG9mIDAvVUNIQVJfTUFYLgoKQXV0aG9y OiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2VyZGF0YS5jb20+ClN1Z2dlc3Rl ZC1ieTogVG9tIExhbmUgPHRnbEBzc3MucGdoLnBhLnVzPgpTdWdnZXN0ZWQtYnk6IERhdmlkIFJv d2xleSA8ZGdyb3dsZXltbEBnbWFpbC5jb20+CkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVz L20vQ0FMZFNTUGhGeWI5cUxTSGVlNzNYdFptMUNCV0pObzklMkJKekZOZi16VUVXQ1JXNXlFaVEl NDBtYWlsLmdtYWlsLmNvbQotLS0KIGNvbnRyaWIvcGFnZWluc3BlY3QvaGVhcGZ1bmNzLmMgICAg ICAgIHwgIDIgKy0KIHNyYy9iYWNrZW5kL2FjY2Vzcy9uYnRyZWUvbmJ0Y29tcGFyZS5jIHwgMTYg KysrKysrKystLS0tLS0tLQogc3JjL2luY2x1ZGUvcG9zdGdyZXMuaCAgICAgICAgICAgICAgICAg fCAxOSAtLS0tLS0tLS0tLS0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygr KSwgMjggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY29udHJpYi9wYWdlaW5zcGVjdC9oZWFw ZnVuY3MuYyBiL2NvbnRyaWIvcGFnZWluc3BlY3QvaGVhcGZ1bmNzLmMKaW5kZXggMWNmMGI0NGU3 MzEuLjhiMzViM2MzMzdhIDEwMDY0NAotLS0gYS9jb250cmliL3BhZ2VpbnNwZWN0L2hlYXBmdW5j cy5jCisrKyBiL2NvbnRyaWIvcGFnZWluc3BlY3QvaGVhcGZ1bmNzLmMKQEAgLTIyMyw3ICsyMjMs NyBAQCBoZWFwX3BhZ2VfaXRlbXMoUEdfRlVOQ1RJT05fQVJHUykKIAkJCXZhbHVlc1s3XSA9IFBv aW50ZXJHZXREYXR1bSgmdHVwaGRyLT50X2N0aWQpOwogCQkJdmFsdWVzWzhdID0gVUludDMyR2V0 RGF0dW0odHVwaGRyLT50X2luZm9tYXNrMik7CiAJCQl2YWx1ZXNbOV0gPSBVSW50MzJHZXREYXR1 bSh0dXBoZHItPnRfaW5mb21hc2spOwotCQkJdmFsdWVzWzEwXSA9IFVJbnQ4R2V0RGF0dW0odHVw aGRyLT50X2hvZmYpOworCQkJdmFsdWVzWzEwXSA9IEludDE2R2V0RGF0dW0odHVwaGRyLT50X2hv ZmYpOwogCiAJCQkvKgogCQkJICogV2UgYWxyZWFkeSBjaGVja2VkIHRoYXQgdGhlIGl0ZW0gaXMg Y29tcGxldGVseSB3aXRoaW4gdGhlIHJhdwpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNz L25idHJlZS9uYnRjb21wYXJlLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvbmJ0cmVlL25idGNvbXBh cmUuYwppbmRleCA4NDI1ODA1YTI5Mi4uMmExMjMwODJkODYgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNr ZW5kL2FjY2Vzcy9uYnRyZWUvbmJ0Y29tcGFyZS5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy9u YnRyZWUvbmJ0Y29tcGFyZS5jCkBAIC02MTcsOSArNjE3LDkgQEAgYnRjaGFyY21wKFBHX0ZVTkNU SU9OX0FSR1MpCiBzdGF0aWMgRGF0dW0KIGNoYXJfZGVjcmVtZW50KFJlbGF0aW9uIHJlbCwgRGF0 dW0gZXhpc3RpbmcsIGJvb2wgKnVuZGVyZmxvdykKIHsKLQl1aW50OAkJY2V4aXN0aW5nID0gRGF0 dW1HZXRVSW50OChleGlzdGluZyk7CisJY2hhcgkJY2V4aXN0aW5nID0gRGF0dW1HZXRDaGFyKGV4 aXN0aW5nKTsKIAotCWlmIChjZXhpc3RpbmcgPT0gMCkKKwlpZiAoY2V4aXN0aW5nID09IFNDSEFS X01JTikKIAl7CiAJCS8qIHJldHVybiB2YWx1ZSBpcyB1bmRlZmluZWQgKi8KIAkJKnVuZGVyZmxv dyA9IHRydWU7CkBAIC02MjcsMTUgKzYyNywxNSBAQCBjaGFyX2RlY3JlbWVudChSZWxhdGlvbiBy ZWwsIERhdHVtIGV4aXN0aW5nLCBib29sICp1bmRlcmZsb3cpCiAJfQogCiAJKnVuZGVyZmxvdyA9 IGZhbHNlOwotCXJldHVybiBDaGFyR2V0RGF0dW0oKHVpbnQ4KSBjZXhpc3RpbmcgLSAxKTsKKwly ZXR1cm4gQ2hhckdldERhdHVtKGNleGlzdGluZyAtIDEpOwogfQogCiBzdGF0aWMgRGF0dW0KIGNo YXJfaW5jcmVtZW50KFJlbGF0aW9uIHJlbCwgRGF0dW0gZXhpc3RpbmcsIGJvb2wgKm92ZXJmbG93 KQogewotCXVpbnQ4CQljZXhpc3RpbmcgPSBEYXR1bUdldFVJbnQ4KGV4aXN0aW5nKTsKKwljaGFy CQljZXhpc3RpbmcgPSBEYXR1bUdldENoYXIoZXhpc3RpbmcpOwogCi0JaWYgKGNleGlzdGluZyA9 PSBVQ0hBUl9NQVgpCisJaWYgKGNleGlzdGluZyA9PSBTQ0hBUl9NQVgpCiAJewogCQkvKiByZXR1 cm4gdmFsdWUgaXMgdW5kZWZpbmVkICovCiAJCSpvdmVyZmxvdyA9IHRydWU7CkBAIC02NDMsNyAr NjQzLDcgQEAgY2hhcl9pbmNyZW1lbnQoUmVsYXRpb24gcmVsLCBEYXR1bSBleGlzdGluZywgYm9v bCAqb3ZlcmZsb3cpCiAJfQogCiAJKm92ZXJmbG93ID0gZmFsc2U7Ci0JcmV0dXJuIENoYXJHZXRE YXR1bSgodWludDgpIGNleGlzdGluZyArIDEpOworCXJldHVybiBDaGFyR2V0RGF0dW0oY2V4aXN0 aW5nICsgMSk7CiB9CiAKIERhdHVtCkBAIC02NTUsOCArNjU1LDggQEAgYnRjaGFyc2tpcHN1cHBv cnQoUEdfRlVOQ1RJT05fQVJHUykKIAlza3N1cC0+aW5jcmVtZW50ID0gY2hhcl9pbmNyZW1lbnQ7 CiAKIAkvKiBidGNoYXJjbXAgY29tcGFyZXMgY2hhcnMgYXMgdW5zaWduZWQgKi8KLQlza3N1cC0+ bG93X2VsZW0gPSBVSW50OEdldERhdHVtKDApOwotCXNrc3VwLT5oaWdoX2VsZW0gPSBVSW50OEdl dERhdHVtKFVDSEFSX01BWCk7CisJc2tzdXAtPmxvd19lbGVtID0gQ2hhckdldERhdHVtKFNDSEFS X01JTik7CisJc2tzdXAtPmhpZ2hfZWxlbSA9IENoYXJHZXREYXR1bShTQ0hBUl9NQVgpOwogCiAJ UEdfUkVUVVJOX1ZPSUQoKTsKIH0KZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL3Bvc3RncmVzLmgg Yi9zcmMvaW5jbHVkZS9wb3N0Z3Jlcy5oCmluZGV4IDFhZmZjMDU2NWJjLi5iNTliNmI0MWU1NCAx MDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvcG9zdGdyZXMuaAorKysgYi9zcmMvaW5jbHVkZS9wb3N0 Z3Jlcy5oCkBAIC0xMzQsMjUgKzEzNCw2IEBAIENoYXJHZXREYXR1bShjaGFyIFgpCiAJcmV0dXJu IChEYXR1bSkgWDsKIH0KIAotLyoKLSAqIERhdHVtR2V0VUludDgKLSAqCQlSZXR1cm5zIDgtYml0 IHVuc2lnbmVkIGludGVnZXIgdmFsdWUgb2YgYSBkYXR1bS4KLSAqLwotc3RhdGljIGlubGluZSB1 aW50OAotRGF0dW1HZXRVSW50OChEYXR1bSBYKQotewotCXJldHVybiAodWludDgpIFg7Ci19Ci0K LS8qCi0gKiBVSW50OEdldERhdHVtCi0gKgkJUmV0dXJucyBkYXR1bSByZXByZXNlbnRhdGlvbiBm b3IgYW4gOC1iaXQgdW5zaWduZWQgaW50ZWdlci4KLSAqLwotc3RhdGljIGlubGluZSBEYXR1bQot VUludDhHZXREYXR1bSh1aW50OCBYKQotewotCXJldHVybiAoRGF0dW0pIFg7Ci19CiAKIC8qCiAg KiBEYXR1bUdldEludDE2Ci0tIAoyLjQzLjAKCg== --000000000000d6fd7a0647ccc1a2 Content-Type: text/x-patch; charset="US-ASCII"; name="v2-0001-Remove-Int8GetDatum-function.patch" Content-Disposition: attachment; filename="v2-0001-Remove-Int8GetDatum-function.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mk439a4c0 RnJvbSA4Y2NkMTMzY2QwNmQ2NjQxNmM5ZjcxOGIxMGNlODg5YTI3MDQ2NzI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiByZXNoa2UgPHJlc2hrZUBkb3VibGUuY2xvdWQ+CkRhdGU6IFR1 ZSwgNiBKYW4gMjAyNiAxNDowMzo0OSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjIgMS8yXSBSZW1v dmUgSW50OEdldERhdHVtIGZ1bmN0aW9uLgoKV2UgaGF2ZSBubyB1c2VzIG9mIEludDhHZXREYXR1 bSBpbiBvdXIgdHJlZSBhbmQKZGlkIG5vdCBoYXZlIGZvciBhIGxvbmcgdGltZSAob3IgbmV2ZXIp LgoKU3VnZ2VzdGVkLWJ5OiAJVG9tIExhbmUgPHRnbEBzc3MucGdoLnBhLnVzPgotLS0KIHNyYy9p bmNsdWRlL3Bvc3RncmVzLmggfCAxMCAtLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvcG9zdGdyZXMuaCBiL3NyYy9pbmNs dWRlL3Bvc3RncmVzLmgKaW5kZXggN2Q5M2ZiY2U3MDkuLjFhZmZjMDU2NWJjIDEwMDY0NAotLS0g YS9zcmMvaW5jbHVkZS9wb3N0Z3Jlcy5oCisrKyBiL3NyYy9pbmNsdWRlL3Bvc3RncmVzLmgKQEAg LTEzNCwxNiArMTM0LDYgQEAgQ2hhckdldERhdHVtKGNoYXIgWCkKIAlyZXR1cm4gKERhdHVtKSBY OwogfQogCi0vKgotICogSW50OEdldERhdHVtCi0gKgkJUmV0dXJucyBkYXR1bSByZXByZXNlbnRh dGlvbiBmb3IgYW4gOC1iaXQgaW50ZWdlci4KLSAqLwotc3RhdGljIGlubGluZSBEYXR1bQotSW50 OEdldERhdHVtKGludDggWCkKLXsKLQlyZXR1cm4gKERhdHVtKSBYOwotfQotCiAvKgogICogRGF0 dW1HZXRVSW50OAogICoJCVJldHVybnMgOC1iaXQgdW5zaWduZWQgaW50ZWdlciB2YWx1ZSBvZiBh IGRhdHVtLgotLSAKMi40My4wCgo= --000000000000d6fd7a0647ccc1a2--