MIME-Version: 1.0
References: 
 <CAJ7c6TPQ0kkHQG-AqeAJ3PV_YtmDzcc7s+_V4=t+xgSnZm1cFw@mail.gmail.com>
 <CAE7r3MJ=CcWw65=C=tET32z5joixFqMDY_XhCxvjpLcOL3nVAQ@mail.gmail.com>
 <CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D+zFWBwae-80do6o-rA@mail.gmail.com>
 <aFVomQjfkDvtQRwo@momjian.us>
 <CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
 <CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
 <CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
 <aPqPK4ERy5-jj185@nathan>
In-Reply-To: <aPqPK4ERy5-jj185@nathan>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Mon, 27 Oct 2025 15:13:33 +0300
Message-ID: 
 <CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
	Bruce Momjian <bruce@momjian.us>, Michael Paquier <michael@paquier.xyz>
Content-Type: multipart/mixed; boundary="000000000000ade946064222d41a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TMTzQsnKfM%2B_4i-4WO7%3DYnV4nO8ABWA6enSpdtg6DKhqQ%40mail.gmail.com>
Precedence: bulk

--000000000000ade946064222d41a
Content-Type: text/plain; charset="UTF-8"

Hi Nathan,

> > Personally I don't have a strong opinion on this. We can easily add an
> > exception for "/* ---" and "/* ===" comments if somebody believes this
> > is a problem. I choose not to add such an exception just yet only
> > because I don't like unnecessary exceptions :)
>
> +1 for adding an exception for "/* -----" style comments.  I tested running
> pgindent after applying the patch, and the first thing I noticed was all
> these (IMHO) unnecessary changes.  I don't think it helps readability, and
> even if it did, it's arguably not worth the churn.

OK, here is the corrected patch v5.

-- 
Best regards,
Aleksander Alekseev

--000000000000ade946064222d41a
Content-Type: text/x-patch; charset="US-ASCII";
	name="v5-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Disposition: attachment;
	filename="v5-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mh93mkd80>
X-Attachment-Id: f_mh93mkd80

RnJvbSBmODcxMzc2NzNjMGIzZGE1YWVkMjk2Zjg4MDE2ZThkOGVkZmQzOTE1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpbWVz
Y2FsZS5jb20+CkRhdGU6IEZyaSwgMjAgSnVuIDIwMjUgMTY6MzE6MzYgKzAzMDAKU3ViamVjdDog
W1BBVENIIHY1XSBwZ2luZGVudDogaW1wcm92ZSBmb3JtYXR0aW5nIG9mIG11bHRpbGluZSBjb21t
ZW50cwoKRm9ybWF0IG11bHRpbGluZSBjb21tZW50cyBsaWtlIHRoaXM6CgovKiBsaW5lIDEKICog
bGluZSAyCiAqLwoKLi4uIGludG86CgovKgogKiBsaW5lIDEKICogbGluZSAyCiAqLwoKVGhpcyBp
cyBtb3JlIGNvbnNpc3RlbnQgd2l0aCB3aGF0IHdlIGN1cnJlbnRseSBoYXZlIGluIHRoZSB0cmVl
LgoKQXV0aG9yOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2VyZGF0YS5jb20+
ClJlcG9ydGVkLWJ5OiBNaWNoYWVsIFBhcXVpZXIgPG1pY2hhZWxAcGFxdWllci54eXo+ClJldmll
d2VkLWJ5OiBBcnNlbml5IE11a2hpbiA8YXJzZW5peS5tdWtoaW4uZGV2QGdtYWlsLmNvbT4KUmV2
aWV3ZWQtYnk6IE5hdGhhbiBCb3NzYXJ0IDxuYXRoYW5kYm9zc2FydEBnbWFpbC5jb20+CkRpc2N1
c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vQ0FKN2M2VFBRMGtrSFFHLUFxZUFKM1BWX1l0bUR6
Y2M3cyUyQl9WNCUzRHQlMkJ4Z1NuWm0xY0Z3JTQwbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdG9v
bHMvcGdpbmRlbnQvcGdpbmRlbnQgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3Jj
L3Rvb2xzL3BnaW5kZW50L3BnaW5kZW50IGIvc3JjL3Rvb2xzL3BnaW5kZW50L3BnaW5kZW50Cmlu
ZGV4IGI3ZDcxODA4OTI0Li42NzBlMjA0ZTkxNyAxMDA3NTUKLS0tIGEvc3JjL3Rvb2xzL3BnaW5k
ZW50L3BnaW5kZW50CisrKyBiL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudApAQCAtMjgxLDYg
KzI4MSw5IEBAIHN1YiBwb3N0X2luZGVudAogCSMgRml4IHJ1bi10b2dldGhlciBjb21tZW50cyB0
byBoYXZlIGEgdGFiIGJldHdlZW4gdGhlbQogCSRzb3VyY2UgPX4gcyFcKi8oL1wqLipcKi8pJCEq
L1x0JDEhZ207CiAKKwkjIFBvc3Rwcm9jZXNzIG11bHRpbGluZSBjb21tZW50cyBleGNlcHQgZm9y
IC8qKi4uLiBhbmQgLyotLi4uIG9uZXMKKwkkc291cmNlID1+IHMhXigvXCpbXlwqXC1dLio/XCov
KSFwb3N0cHJvY2Vzc19tdWx0aWxpbmVfY29tbWVudCgkMSkhbWdzZTsKKwogCSMjIEZ1bmN0aW9u
cwogCiAJIyBVc2UgYSBzaW5nbGUgc3BhY2UgYmVmb3JlICcqJyBpbiBmdW5jdGlvbiByZXR1cm4g
dHlwZXMKQEAgLTI4OSw2ICsyOTIsMzkgQEAgc3ViIHBvc3RfaW5kZW50CiAJcmV0dXJuICRzb3Vy
Y2U7CiB9CiAKK3N1YiBwb3N0cHJvY2Vzc19tdWx0aWxpbmVfY29tbWVudAoreworICAgIG15ICRz
b3VyY2UgPSBzaGlmdDsKKyAgICBteSBAbGluZXMgPSBzcGxpdCAiXG4iLCAkc291cmNlOworCisg
ICAgIyBPbmx5IGZvcm1hdCBjb21tZW50cyB0aGF0IG1hdGNoIHRoZSBleHBlY3RlZCBmb3JtYXQs
CisgICAgIyBvciBhdCBsZWFzdCB0aGF0IGNvdWxkIGhhdmUgYmVlbiB0aGUgYXV0aG9yJ3MgaW50
ZW50LgorICAgIGlmICgoJGxpbmVzWzBdIG5lICIvKiIgJiYgJGxpbmVzWy0xXSBuZSAiICovIikg
b3IgKCRsaW5lc1sxXSAhfiBtIV4gXCohKSkKKyAgICB7CisgICAgICAgIHJldHVybiAkc291cmNl
OworICAgIH0KKworICAgICMgQ2hlY2sgZWFjaCBsaW5lIGV4Y2VwdCBmb3IgdGhlIGZpc3QgYW5k
IHRoZSBsYXN0IG9uZQorICAgIGZvciBteSAkaSAoIDEgLi4gc2NhbGFyIEBsaW5lcyAtIDIgKQor
ICAgIHsKKyAgICAgICAgJGxpbmVzWyRpXSA9ICIgKiIuJGxpbmVzWyRpXSBpZiAkbGluZXNbJGld
ICF+IC9eIFwqLzsKKyAgICB9CisKKyAgICAjIEtlZXAgLyogPT09IGFuZCAvKiAtLS0gbGluZXMg
YXMgaXMKKyAgICBpZiAoJGxpbmVzWzBdICF+IG0hXi9cKiBbPS1dKyEpIHsKKyAgICAgICAgJGxp
bmVzWzBdID1+IHMhL1wqKC4rKSEvXCpcbiAqJDEhOworICAgIH0KKworICAgICMgS2VlcCA9PT0g
Ki8gYW5kIC0tLSAqLyBsaW5lcyBhcyBpcworICAgIGlmICgkbGluZXNbLTFdICF+IG0hWz0tXSsg
XCovJCEpIHsKKyAgICAgICAgJGxpbmVzWy0xXSA9fiBzISguKykgXCovISQxXG4gXCovITsKKyAg
ICB9CisKKyAgICAkc291cmNlID0gam9pbiAiXG4iLCBAbGluZXM7CisKKyAgICByZXR1cm4gJHNv
dXJjZTsKK30KKwogc3ViIHJ1bl9pbmRlbnQKIHsKIAlteSAkc291cmNlID0gc2hpZnQ7Ci0tIAoy
LjQzLjAKCg==
--000000000000ade946064222d41a--