public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aleksander Alekseev <[email protected]>
To: [email protected] <[email protected]>
Cc: Eduard Stefes <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X
Date: Wed, 7 May 2025 16:15:10 +0300
Message-ID: <CAJ7c6TMian+pDWJeqZ584ix_ht_rR_PHxZfWgrriRtxjGw2Jrg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi Eduard,

> Here I send a patch that adds a vectorized version of CRC32C for the
> IBM S390X hardware. I kindly ask for a review of the code and to pick
> it up in upstream postgresql.
> [...]
> Cheers and thanks to all for their work,

Thanks for submitting this patch.

Please register it on the nearest open commitfest [1] so that it
wouldn't be lost.

I didn't review the patch but wanted to point out that when it comes
to performance improvements it's typically useful to provide some
benchmarks.

[1]: https://commitfest.postgresql.org/53/

-- 
Best regards,
Aleksander Alekseev

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X
  In-Reply-To: <CAJ7c6TMian+pDWJeqZ584ix_ht_rR_PHxZfWgrriRtxjGw2Jrg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox