MIME-Version: 1.0
References: <CAOYmi+nEqA2LmetcJKUDmctypPLLumkVwj3vQ3idYd8yAGza5Q@mail.gmail.com>
 <CAOYmi+kebAt6wSX7ee0c0kMzV7r0hp93bAt10V5a88yHHUKwog@mail.gmail.com>
 <CAOYmi+=CrBFBRX-foRRES2tx2wXBJJhbsJGjgFbWvPcmBJuK-Q@mail.gmail.com>
 <DDOUZE2TCU8O.89TN0AS4GLP7@jeltef.nl> <DE5BODEZ607Y.3LNII22O5N27O@jeltef.nl>
 <g4gdtfedwwdgu5sbcopjt3djtqk6p2q7n5nymp7ppapfwukoyd@ev2v4jtsbure>
 <CAOYmi+mV97+FC=ME0EZj+3LBFHZ3g_xGmTGA_3u+TwJ_pvpFWw@mail.gmail.com>
 <DFHQQ4VS43SU.25NN2Y5GDWANL@jeltef.nl> <baqtdyuunu42yu7ler4bflifksznt7u7tywj4atdtcxwxhxinj@76taubczsku2>
 <CAGECzQTzG0otdj7Z6--FOtbLLiceJ+eWn3dqRYr6-toG+RWcEg@mail.gmail.com>
 <froy7mvxq76o2asuyzajyvaqelzuv372xsylfvhlhkvis7ojr4@23lg5adaxvdw>
 <DFJ7MRI3WIVU.MZQI2USE0SY7@jeltef.nl> <DFKUXURPKH0L.2KCTC6ED9X8IE@jeltef.nl>
In-Reply-To: <DFKUXURPKH0L.2KCTC6ED9X8IE@jeltef.nl>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Mon, 19 Jan 2026 14:34:37 +0300
Message-ID: <CAJ7c6TMt-aXXmtO9JgXEsh4UvWrPQbW4_CnRxftAacW0QM9a5g@mail.gmail.com>
Subject: Re: RFC: adding pytest as a supported test framework
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Andres Freund <andres@anarazel.de>, 
	Jacob Champion <jacob.champion@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, 
	Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Peter Eisentraut <peter@eisentraut.org>, Nazir Bilal Yavuz <byavuz81@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAJ7c6TMt-aXXmtO9JgXEsh4UvWrPQbW4_CnRxftAacW0QM9a5g%40mail.gmail.com>
Precedence: bulk

Hi,

> v10 attached to resolve merge conflicts.

I tested and reviewed patches 0001 .. 0003 on Linux x64. All in all
the code is in a pretty good shape except for several TODOs:

```
                # TODO: proper quoting
                v = v.replace("\\", "\\\\")
                v = v.replace("'", "\\'")
                v = "'{}'".format(v)
```

and:

```
            # TODO: rather than using callback(), consider explicitly signaling
            # the fn() implementation to stop early if we get an exception.
            # Otherwise we'll hang until the end of the timeout.
            self._thread = threading.Thread(target=_bg)
            self.callback(self._join)
```

Are there any plans to rewrite this code? If not, maybe there should
be no TODOs in the comments?

Also leaving this:

```
        # XXX interacts poorly with testwrap's boilerplate diagnostics
        # self.print("TAP version 13")
```

... doesn't seem to be particularly useful. I see XXX but what are
actionable items? If there are none, perhaps there shouldn't be XXX
here.

I haven't looked at 0004 and 0005.

-- 
Best regards,
Aleksander Alekseev