public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aleksander Alekseev <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Chao Li <[email protected]>
Cc: Arseniy Mukhin <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Michael Paquier <[email protected]>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Date: Fri, 12 Dec 2025 14:32:13 +0300
Message-ID: <CAJ7c6TN2+DiExF=H4rKJ1-hz=QEibGXQ2QNtaaptR+7uZEeuMg@mail.gmail.com> (raw)
In-Reply-To: <aTs8K_okt9MfEnP0@nathan>
References: <CAE7r3MJ=CcWw65=C=tET32z5joixFqMDY_XhCxvjpLcOL3nVAQ@mail.gmail.com>
<CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D+zFWBwae-80do6o-rA@mail.gmail.com>
<[email protected]>
<CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
<CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
<CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
<aPqPK4ERy5-jj185@nathan>
<CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com>
<[email protected]>
<CAJ7c6TPCJz-ExBFL8q2dCkXZpUdpm=+wvTF11gDENGk39n3DYA@mail.gmail.com>
<aTs8K_okt9MfEnP0@nathan>
Hi Nathan,
> [...]
> I think we should also figure out what we want to do for things like this:
>
> ******************************************************************************
> - This file contains routines that can be bound to a Postgres backend and
> - called by the backend in the process of processing queries. The calling
> - format for these routines is dictated by Postgres architecture.
> + * This file contains routines that can be bound to a Postgres backend and
> + * called by the backend in the process of processing queries. The calling
> + * format for these routines is dictated by Postgres architecture.
> ******************************************************************************/
>
> Could we modify the patch to leave these kinds of comments alone?
I see 3 files that have this comment:
- src/tutorial/complex.c
- contrib/seg/seg.c
- contrib/cube/cube.c
Note that cube.c is not affected by the new version of pgindent,
because the comment starts with `/****`. Such comments are kept as is.
seg.c and cube.c use a mixed format. The comments start with `/*`
followed by ` *` lines but several lines below don't have ` *` in the
beginning. I don't instantly see a way to process this situation in
pgindent. We can either let it modify these comments, or alternatively
change the first lines of the comments from `/*` to `/**`.
--
Best regards,
Aleksander Alekseev
view thread (26+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
In-Reply-To: <CAJ7c6TN2+DiExF=H4rKJ1-hz=QEibGXQ2QNtaaptR+7uZEeuMg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox