MIME-Version: 1.0
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Thu, 12 Mar 2026 15:56:26 +0300
Message-ID: 
 <CAJ7c6TN3Hbb5p=UHx0SPVN+h_JwPAV6rxoqOm7gHBMFKfnGK-Q@mail.gmail.com>
Subject: [PATCH] Silence a new Valgrind warning
To: PostgreSQL Development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000007efc57064cd34862"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TN3Hbb5p%3DUHx0SPVN%2Bh_JwPAV6rxoqOm7gHBMFKfnGK-Q%40mail.gmail.com>
Precedence: bulk

--0000000000007efc57064cd34862
Content-Type: text/plain; charset="UTF-8"

Hi,

Commit 4966bd3ed95e revealed a non-critical memory leak in
ProcessStartupPacket() which Valgrind is very much upset about:

```
63 (32 direct, 31 indirect) bytes in 1 blocks are definitely lost in
loss record 355 of 800
   at 0x9D260C: palloc (mcxt.c:1411)
   by 0x54B3D2: new_list (list.c:137)
   by 0x54B8CC: lappend (list.c:344)
   by 0x78B41A: ProcessStartupPacket (backend_startup.c:786)
   by 0x78A411: BackendInitialize (backend_startup.c:295)
   by 0x789F2F: BackendMain (backend_startup.c:110)
   by 0x67EEED: postmaster_child_launch (launch_backend.c:268)
   by 0x685D50: BackendStartup (postmaster.c:3606)
   by 0x6830CF: ServerLoop (postmaster.c:1713)
   by 0x682982: PostmasterMain (postmaster.c:1403)
   by 0x547DFE: main (main.c:231)
```

The proposed patch silences the warnings.

-- 
Best regards,
Aleksander Alekseev

--0000000000007efc57064cd34862
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Free-memory-allocated-for-unrecognized_protocol_o.patch"
Content-Disposition: attachment;
	filename="v1-0001-Free-memory-allocated-for-unrecognized_protocol_o.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmnh0ivd0>
X-Attachment-Id: f_mmnh0ivd0

RnJvbSAwNzlhNjQ2ZjRkYjZmZjgwZWMwMmE2YmI4ODg0ZjRjNWIwNzUzNDVjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2Vy
ZGF0YS5jb20+CkRhdGU6IFRodSwgMTIgTWFyIDIwMjYgMTQ6NTM6MzggKzAzMDAKU3ViamVjdDog
W1BBVENIIHYxXSBGcmVlIG1lbW9yeSBhbGxvY2F0ZWQgZm9yIHVucmVjb2duaXplZF9wcm90b2Nv
bF9vcHRpb25zCgpTaW5jZSA0OTY2YmQzZWQ5NWUgVmFsZ3JpbmQgc3RhcnRlZCB0byB3YXJuIGFi
b3V0IGxpdHRsZSBhbW91bnQgb2YgbWVtb3J5IGJlaW5nCmxlYWtlZCBpbiBQcm9jZXNzU3RhcnR1
cFBhY2tldCgpLiBUaGlzIGlzIG5vdCBjcml0aWNhbCBidXQgdGhlIHdhcm5pbmdzIG1heQpkaXN0
cmFjdCBmcm9tIHJlYWwgaXNzdWVzLiBGaXggaXQgYnkgZnJlZWluZyB0aGUgbGlzdCBhZnRlciB1
c2UuCgpBdXRob3I6IEFsZWtzYW5kZXIgQWxla3NlZXYgPGFsZWtzYW5kZXJAdGlnZXJkYXRhLmNv
bT4KUmV2aWV3ZWQtYnk6IFRPRE8gRklYTUUKRGlzY3Vzc2lvbjogVE9ETyBGSVhNRQotLS0KIHNy
Yy9iYWNrZW5kL3Rjb3AvYmFja2VuZF9zdGFydHVwLmMgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwg
MiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdGNvcC9iYWNrZW5kX3N0
YXJ0dXAuYyBiL3NyYy9iYWNrZW5kL3Rjb3AvYmFja2VuZF9zdGFydHVwLmMKaW5kZXggYzUxNzEx
NTkyN2MuLjVhYmYyNzZjODk4IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC90Y29wL2JhY2tlbmRf
c3RhcnR1cC5jCisrKyBiL3NyYy9iYWNrZW5kL3Rjb3AvYmFja2VuZF9zdGFydHVwLmMKQEAgLTgy
NSw2ICs4MjUsOCBAQCBQcm9jZXNzU3RhcnR1cFBhY2tldChQb3J0ICpwb3J0LCBib29sIHNzbF9k
b25lLCBib29sIGdzc19kb25lKQogCQlpZiAoUEdfUFJPVE9DT0xfTUlOT1IocHJvdG8pID4gUEdf
UFJPVE9DT0xfTUlOT1IoUEdfUFJPVE9DT0xfTEFURVNUKSB8fAogCQkJdW5yZWNvZ25pemVkX3By
b3RvY29sX29wdGlvbnMgIT0gTklMKQogCQkJU2VuZE5lZ290aWF0ZVByb3RvY29sVmVyc2lvbih1
bnJlY29nbml6ZWRfcHJvdG9jb2xfb3B0aW9ucyk7CisKKwkJbGlzdF9mcmVlX2RlZXAodW5yZWNv
Z25pemVkX3Byb3RvY29sX29wdGlvbnMpOwogCX0KIAogCS8qIENoZWNrIGEgdXNlciBuYW1lIHdh
cyBnaXZlbi4gKi8KLS0gCjIuNDMuMAoK
--0000000000007efc57064cd34862--