MIME-Version: 1.0
References: <tencent_6B29EC4570E6F0C659B4EAA7@qq.com>
In-Reply-To: <tencent_6B29EC4570E6F0C659B4EAA7@qq.com>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Mon, 5 Jan 2026 17:51:58 +0300
Message-ID: <CAJ7c6TNEU+hVAysAQL_2wQizzp6DTWg07FT68XAAJ6i2NsUNdw@mail.gmail.com>
Subject: Re: [PATCH] Precompute string lengths in PerformRadiusTransaction
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Cc: zengman <zengman@halodbtech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAJ7c6TNEU%2BhVAysAQL_2wQizzp6DTWg07FT68XAAJ6i2NsUNdw%40mail.gmail.com>
Precedence: bulk

Hi,

> I noticed that the `PerformRadiusTransaction` function is invoked in a lo=
op,
> and the function itself contains internal loops that repeatedly call strl=
en() on the 'passwd' and 'secret' strings.
> While the optimization gain may be minimal, I still think it=E2=80=99s wo=
rth making the change =E2=80=94
> we can precompute the lengths of these two strings at the start of the fu=
nction to eliminate redundant strlen() calls.

Good find. We may also consider making both passwd_len and secret_len `cons=
t`.

--=20
Best regards,
Aleksander Alekseev