MIME-Version: 1.0
References: 
 <CAEze2Wh=PzpX-NT=Vo5c3J45tdyBSdkJM7-VVOWfVPmDYw7fmQ@mail.gmail.com>
 <CAN-LCVMC2ukb=6W2XyUdMc+AF5pipUvTkDLnZMty=dG3CCdaGw@mail.gmail.com>
 <CAN-LCVNkU+kdieu4i_BDnLgGszNY1RCnL6Dsrdz44fY7FOG3vg@mail.gmail.com>
 <CAN-LCVNMot2xqq2pHi4OCbgA1nK4KkRfWiJQGK9EgiTbW3O8gQ@mail.gmail.com>
 <CAEze2Wica9S9b-1ufhKKDVausdv02aObryjddEMF3+K_Sk6c1w@mail.gmail.com>
 <CAN-LCVMBe-U1+phVR21px_kG0rL-5pwz3U2TmCmpM8XtEbPUDg@mail.gmail.com>
 <CAN-LCVOUPnNFV_AAtFsE9oKiWzVji8AF814DBh+C_9e_5ST+AQ@mail.gmail.com>
 <CAJ7c6TPKLpeOrNWV=F=OP0tYEOoX_tDP0FdV48R-qqefU7s77g@mail.gmail.com>
 <CAN-LCVMjh=GW+Otyfe90NqPS8JJjWhia4=n2sLNYLsi43a3bQg@mail.gmail.com>
 <CAN-LCVNLfu-1n94CnZTeD7stToJ=xXGJhrENHjqONZ3n79RRqQ@mail.gmail.com>
 <20220802153704.lhrqpqdrrlpandh7@awork3.anarazel.de>
 <CAN-LCVMXN-igZdOH4kunF0p2jobsksNhFXovEXjr-zVF90Nq1A@mail.gmail.com>
 <CAJ7c6TOhJ5zc+f=OR6F7UmV0BgeO=oSUJ4wnYMuHoysGa4XDmQ@mail.gmail.com>
 <CAN-LCVMpb5t0QheofS=9gQbKSY-Hf_ESCRjBeG-pbL90gRprag@mail.gmail.com>
 <CAAWbhmgeENHPXEY5UR+aGd5VpUiTxwdmtCjEoXq++s6qLjrWZg@mail.gmail.com>
 <CAN-LCVMxZU1F2E5NenDQ6JJDpdUkEK00feM7ih8ts6iqP3FF1w@mail.gmail.com>
 <CAAWbhmgJRhYO0ZN-72vX=pz5VDPfUermexBVLwMgNu1mTWwajA@mail.gmail.com>
 <CAN-LCVN+jjUN3WwY29xbgv3denB2pREYP-ibKY3+62KD0HPkzw@mail.gmail.com>
 <CAN-LCVOqWVWqZ60weCQgbt1F8gDLt8edXO7Fse_UJ0MigDxNiA@mail.gmail.com>
 <CAN-LCVPO3y_bgex36tte9LsHjkiLFsz075CBoxj-c5B=nkL2Dw@mail.gmail.com>
 <CAN-LCVOi20yKrEC198=ty9DLi_dfSP6z55SVZwaXO2YGVeVmZw@mail.gmail.com>
 <CAN-LCVPwNXkYqA_jh0NTRL-YMrrqYPA4Hi5vmpsWhv8+rXoH9A@mail.gmail.com>
 <CAN-LCVMFKfDQ8XDAhuVbF0NPfwFdK283Nd6NupSrvhNGPPVK5Q@mail.gmail.com>
 <CAN-LCVPqU8rH-+PU3t9ZqB8cfs+KkDLgvUr8otAtjyvqbMPtFA@mail.gmail.com>
 <CAN-LCVPVQzStwHD4iRpBWRz1gDChsMnrEqjY5+WLu_AhLzHeww@mail.gmail.com>
 <CAN-LCVNa_uvZTQ1ibMS=-xka-fTuCY=Zf7Set0bJbLRLoix0tQ@mail.gmail.com>
 <CAN-LCVPP+m3uad-adwoUs_afnnUQT2GgZMjcpFyO_NN0eb+G8w@mail.gmail.com>
 <CAJ7c6TOhuezzKjeo56veVqW=uEq207JynUtWPrYxBnS5Eo+Vqg@mail.gmail.com>
 <CAN-LCVN7V4RP6bwfXQriVShGhmod9NLj7K8esHx8YnovuJ1v4g@mail.gmail.com>
 <CAJ7c6TPApg12Ma4eLd04rwVQJQ1AkHa2SnnDyYBHgnoR5EhY1w@mail.gmail.com>
 <CAN-LCVOg4Yt1twJOMefnHAnh07FgoxHeeveyp+86=U_hGkfvGA@mail.gmail.com>
 <CAJ7c6TOLQ9Cx_cdY+axr_6HizvraT8fW_ak1MMMM41f-87rNyw@mail.gmail.com>
 <CAN-LCVNaQy04RvbgVtwygmvfPDFSGxLhzUK=DgUjAEiZ9n9Mfw@mail.gmail.com>
 <CAJ7c6TMMLxbh76b_i-LwSnmvP3uD-emv70EHDkGoNHPDPGK30g@mail.gmail.com>
 <CAN-LCVNvOTHJQSzJZjKyzshQdFeSNh8TSHy6p9PEUPL393ic7Q@mail.gmail.com>
 <CAJ7c6TNNROJcC0ObdeVRM9+kG2gYT+_RBzmf-xDhia5JeYfhGw@mail.gmail.com>
 <CAN-LCVM3zP2SrdFksF3p7sk_hFX_NE081F=r1iT_H39QQp1YkA@mail.gmail.com>
 <CAJ7c6TNBiNt=su47SesPeww=Y92LjhwY9QP5zijCvSrB9OM5nA@mail.gmail.com>
 <CAN-LCVPv-aTC5iH4=nx_q4rymkLt5RXWM=qP9smczmFiwMmwJw@mail.gmail.com>
 <CAJ7c6TNdUocqmcaBnzRzi+YkPGmwuKbr+WnEdBHf9Thd7VDpPg@mail.gmail.com>
 <CAN-LCVMQKiJiyUiQOe-8K9Vg4YRh9KnXn3OOs+v3aeyu80zmAA@mail.gmail.com>
 <CAJ7c6TPKrYfh5j_G7sQdx6iwGgx10qZkUqhV-UtOJOcKAsVt0w@mail.gmail.com>
In-Reply-To: 
 <CAJ7c6TPKrYfh5j_G7sQdx6iwGgx10qZkUqhV-UtOJOcKAsVt0w@mail.gmail.com>
From: Aleksander Alekseev <aleksander@timescale.com>
Date: Wed, 2 Nov 2022 00:15:27 +0300
Message-ID: 
 <CAJ7c6TNNy3gzfYrsQLgpLLQ64f-dv60iudubD=S_Xm46pS8+8Q@mail.gmail.com>
Subject: Re: Pluggable toaster
To: Nikita Malakhov <hukutoc@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Jacob Champion <jchampion@timescale.com>,
	Andres Freund <andres@anarazel.de>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>, Greg Stark <stark@mit.edu>,
 Teodor Sigaev <teodor@sigaev.ru>
Content-Type: multipart/mixed; boundary="000000000000d2c7c805ec6f39f3"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TNNy3gzfYrsQLgpLLQ64f-dv60iudubD%3DS_Xm46pS8%2B8Q%40mail.gmail.com>
Precedence: bulk

--000000000000d2c7c805ec6f39f3
Content-Type: text/plain; charset="UTF-8"

Hi Nikita,

> Please don't forget to run `pgindent` before formatting the patches
> with `git format-patch` next time.

There are also some compiler warnings, please see the attachment.

> I'm going to submit a more detailed code review soon.

-- 
Best regards,
Aleksander Alekseev

--000000000000d2c7c805ec6f39f3
Content-Type: text/plain; charset="UTF-8"; name="warnings.txt"
Content-Disposition: attachment; filename="warnings.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_l9ypl93k0>
X-Attachment-Id: f_l9ypl93k0

L2hvbWUvZWF4L3Byb2plY3RzL3Bnc2NyaXB0cy8uLi9wb3N0Z3Jlc3FsL3NyYy9iYWNrZW5kL2Fj
Y2Vzcy9oZWFwL2hlYXB0b2FzdC5jOiBJbiBmdW5jdGlvbiDigJhoZWFwX2NvbXB1dGVfZGF0YV9z
aXplX3dpdGhvdXRfYXR0cuKAmToKL2hvbWUvZWF4L3Byb2plY3RzL3Bnc2NyaXB0cy8uLi9wb3N0
Z3Jlc3FsL3NyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL2hlYXB0b2FzdC5jOjkwOjE5OiB3YXJuaW5n
OiDigJh0bXDigJkgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBbLVdtYXliZS11bmluaXRpYWxp
emVkXQogICA5MCB8ICAgICAgICAgKnB2YWx1ZSA9IFBvaW50ZXJHZXREYXR1bSgmdG1wKTsKICAg
ICAgfCAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn4KSW4gZmlsZSBpbmNs
dWRlZCBmcm9tIC9ob21lL2VheC9wcm9qZWN0cy9wZ3NjcmlwdHMvLi4vcG9zdGdyZXNxbC9zcmMv
YmFja2VuZC9hY2Nlc3MvaGVhcC9oZWFwdG9hc3QuYzoyNToKL2hvbWUvZWF4L3Byb2plY3RzL3Bn
c2NyaXB0cy8uLi9wb3N0Z3Jlc3FsL3NyYy9pbmNsdWRlL3Bvc3RncmVzLmg6NzM1OjE6IG5vdGU6
IGJ5IGFyZ3VtZW50IDEgb2YgdHlwZSDigJhjb25zdCB2b2lkICrigJkgdG8g4oCYUG9pbnRlckdl
dERhdHVt4oCZIGRlY2xhcmVkIGhlcmUKICA3MzUgfCBQb2ludGVyR2V0RGF0dW0oY29uc3Qgdm9p
ZCAqWCkKICAgICAgfCBefn5+fn5+fn5+fn5+fn4KL2hvbWUvZWF4L3Byb2plY3RzL3Bnc2NyaXB0
cy8uLi9wb3N0Z3Jlc3FsL3NyYy9iYWNrZW5kL2FjY2Vzcy9oZWFwL2hlYXB0b2FzdC5jOjg1OjI0
OiBub3RlOiDigJh0bXDigJkgZGVjbGFyZWQgaGVyZQogICA4NSB8ICAgICAgICAgc3RydWN0IHZh
cmxlbmEgdG1wOwogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgXn5+
--000000000000d2c7c805ec6f39f3--