MIME-Version: 1.0
References: <aFVomQjfkDvtQRwo@momjian.us>
 <CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
 <CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
 <CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
 <aPqPK4ERy5-jj185@nathan>
 <CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com>
 <aP-H6kSsGOxaB21k@nathan> <aQABs_2dbXmGXDvv@paquier.xyz>
 <7415F7DF-FA45-49E1-AC70-04868714DC8A@gmail.com>
 <aTs7A4lbcm0ThXaO@nathan> <aYZqyoNlah_E-Zua@nathan>
 <CAJ7c6TPJVau3Ppih7+KubRwvG9CRpXq16L3X9bE02KuGgL95Nw@mail.gmail.com>
 <206322.1777912819@sss.pgh.pa.us>
In-Reply-To: <206322.1777912819@sss.pgh.pa.us>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Tue, 5 May 2026 16:06:21 +0300
Message-ID: 
 <CAJ7c6TNVeFYAYFs0KDEVsZNPaZtKtHHq+1Mw7=pTw5Hr3g7KGA@mail.gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nathan Bossart <nathandbossart@gmail.com>
Content-Type: multipart/mixed; boundary="00000000000063c66f065111b781"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TNVeFYAYFs0KDEVsZNPaZtKtHHq%2B1Mw7%3DpTw5Hr3g7KGA%40mail.gmail.com>
Precedence: bulk

--00000000000063c66f065111b781
Content-Type: text/plain; charset="UTF-8"

Hi Tom,

Thanks for your feedback.

> In this case the problem is that the cleanup pattern only accounts for
> one trailing space.  But a variant of this, which I think affects many
> of the steps in the patch, is that there could be tab(s) there.  You
> should fix the patterns to allow any number of spaces/tabs at the
> spots where they currently expect just one space.  This might result
> in finding cleanups they miss now.

Fair point. Fixed.

> Another amusing diff I noticed:
>
> [...]
>
> Clearly, this is somebody's off-by-one-key typo, and the correct
> fix is s/&/*/.  I suspect that fixing that manually is the most
> expedient answer, rather than trying to make pg_bsd_indent smart
> enough to DTRT.

Agree.

> One other nitpick is that the patch itself needs to be run through
> pgperltidy (which has different opinions than your editor about
> tabs vs spaces, apparently).

Fixed in v7.

-- 
Best regards,
Aleksander Alekseev

--00000000000063c66f065111b781
Content-Type: text/x-patch; charset="US-ASCII";
	name="v7-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Disposition: attachment;
	filename="v7-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mosn26sh0>
X-Attachment-Id: f_mosn26sh0

RnJvbSA3YzNhYmY2NzFiYWZhZjNhNTQyNTk5NGU5Y2ZlZGY1ZGFmYWY5ODk1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpbWVz
Y2FsZS5jb20+CkRhdGU6IEZyaSwgMjAgSnVuIDIwMjUgMTY6MzE6MzYgKzAzMDAKU3ViamVjdDog
W1BBVENIIHY3XSBwZ2luZGVudDogaW1wcm92ZSBmb3JtYXR0aW5nIG9mIG11bHRpbGluZSBjb21t
ZW50cwoKRm9ybWF0IG11bHRpbGluZSBjb21tZW50cyBsaWtlIHRoaXM6CgovKiBsaW5lIDEKICog
bGluZSAyCiAqLwoKLi4uIGludG86CgovKgogKiBsaW5lIDEKICogbGluZSAyCiAqLwoKVGhpcyBp
cyBtb3JlIGNvbnNpc3RlbnQgd2l0aCB3aGF0IHdlIGN1cnJlbnRseSBoYXZlIGluIHRoZSB0cmVl
LgoKQXV0aG9yOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2VyZGF0YS5jb20+
ClJlcG9ydGVkLWJ5OiBNaWNoYWVsIFBhcXVpZXIgPG1pY2hhZWxAcGFxdWllci54eXo+ClJldmll
d2VkLWJ5OiBBcnNlbml5IE11a2hpbiA8YXJzZW5peS5tdWtoaW4uZGV2QGdtYWlsLmNvbT4KUmV2
aWV3ZWQtYnk6IE5hdGhhbiBCb3NzYXJ0IDxuYXRoYW5kYm9zc2FydEBnbWFpbC5jb20+ClJldmll
d2VkLWJ5OiBUb20gTGFuZSA8dGdsQHNzcy5wZ2gucGEudXM+CkRpc2N1c3Npb246IGh0dHBzOi8v
cG9zdGdyLmVzL20vQ0FKN2M2VFBRMGtrSFFHLUFxZUFKM1BWX1l0bUR6Y2M3cyUyQl9WNCUzRHQl
MkJ4Z1NuWm0xY0Z3JTQwbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdG9vbHMvcGdpbmRlbnQvcGdp
bmRlbnQgfCA0MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUg
Y2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy90b29scy9wZ2luZGVu
dC9wZ2luZGVudCBiL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudAppbmRleCBiMmVjNWUyOTE0
Yi4uZjRiZTc0ZmMzYTQgMTAwNzU1Ci0tLSBhL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudAor
KysgYi9zcmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQKQEAgLTI4NSw2ICsyODUsOSBAQCBzdWIg
cG9zdF9pbmRlbnQKIAkjIEZpeCBydW4tdG9nZXRoZXIgY29tbWVudHMgdG8gaGF2ZSBhIHRhYiBi
ZXR3ZWVuIHRoZW0KIAkkc291cmNlID1+IHMhXCovKC9cKi4qXCovKSQhKi9cdCQxIWdtOwogCisJ
IyBQb3N0cHJvY2VzcyBtdWx0aWxpbmUgY29tbWVudHMgZXhjZXB0IGZvciAvKiouLi4gYW5kIC8q
LS4uLiBvbmVzCisJJHNvdXJjZSA9fiBzIV4oL1wqW15cKlwtXS4qP1wqLykhcG9zdHByb2Nlc3Nf
bXVsdGlsaW5lX2NvbW1lbnQoJDEpIW1nc2U7CisKIAkjIyBGdW5jdGlvbnMKIAogCSMgVXNlIGEg
c2luZ2xlIHNwYWNlIGJlZm9yZSAnKicgaW4gZnVuY3Rpb24gcmV0dXJuIHR5cGVzCkBAIC0yOTMs
NiArMjk2LDQzIEBAIHN1YiBwb3N0X2luZGVudAogCXJldHVybiAkc291cmNlOwogfQogCitzdWIg
cG9zdHByb2Nlc3NfbXVsdGlsaW5lX2NvbW1lbnQKK3sKKwlteSAkc291cmNlID0gc2hpZnQ7CisJ
bXkgQGxpbmVzID0gc3BsaXQgIlxuIiwgJHNvdXJjZTsKKworCSMgT25seSBmb3JtYXQgY29tbWVu
dHMgdGhhdCBtYXRjaCB0aGUgZXhwZWN0ZWQgZm9ybWF0LAorCSMgb3IgYXQgbGVhc3QgdGhhdCBj
b3VsZCBoYXZlIGJlZW4gdGhlIGF1dGhvcidzIGludGVudC4KKwlpZiAoICAgKCRsaW5lc1swXSBu
ZSAiLyoiICYmICRsaW5lc1stMV0gbmUgIiAqLyIpCisJCW9yICgkbGluZXNbMV0gIX4gbSFeXHMr
XCohKSkKKwl7CisJCXJldHVybiAkc291cmNlOworCX0KKworCSMgQ2hlY2sgZWFjaCBsaW5lIGV4
Y2VwdCBmb3IgdGhlIGZpcnN0IGFuZCB0aGUgbGFzdCBvbmUKKwlmb3IgbXkgJGkgKDEgLi4gc2Nh
bGFyIEBsaW5lcyAtIDIpCisJeworCQkkbGluZXNbJGldID0gIiAqIiAuICRsaW5lc1skaV0gaWYg
JGxpbmVzWyRpXSAhfiAvXlxzK1wqLzsKKwl9CisKKwkjIEtlZXAgLyogPT09IGFuZCAvKiAtLS0g
bGluZXMgYXMgaXMKKwlpZiAoJGxpbmVzWzBdICF+IG0hXi9cKlxzK1s9LV0rISkKKwl7CisJCSRs
aW5lc1swXSA9fiBzIS9cKiguKykhL1wqXG4gKiQxITsKKwl9CisKKwkjIEtlZXAgPT09ICovIGFu
ZCAtLS0gKi8gbGluZXMgYXMgaXMKKwlpZiAoJGxpbmVzWy0xXSAhfiBtIVs9LV0rXHMrXCovJCEp
CisJeworCQkjIGFsc28gcmVtb3ZlIHRyYWlsaW5nIHdoaXRlc3BhY2VzCisJCSRsaW5lc1stMV0g
PX4gcyEoLis/KVxzK1wqLyEkMVxuIFwqLyE7CisJfQorCisJJHNvdXJjZSA9IGpvaW4gIlxuIiwg
QGxpbmVzOworCisJcmV0dXJuICRzb3VyY2U7Cit9CisKIHN1YiBydW5faW5kZW50CiB7CiAJbXkg
JHNvdXJjZSA9IHNoaWZ0OwotLSAKMi40My4wCgo=
--00000000000063c66f065111b781--