MIME-Version: 1.0
References: <CA+14427V_B4EAoC_o-iYYucRdMSOTfpuH9k-QbexffY1HYJBiA@mail.gmail.com>
In-Reply-To: <CA+14427V_B4EAoC_o-iYYucRdMSOTfpuH9k-QbexffY1HYJBiA@mail.gmail.com>
From: Aleksander Alekseev <aleksander@timescale.com>
Date: Mon, 4 Mar 2024 15:41:16 +0300
Message-ID: <CAJ7c6TNumEgVKmR+b=r5cfB3pAdxq9eF4+B9QbtCri9tzC5T4Q@mail.gmail.com>
Subject: Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery
To: pgsql-hackers@lists.postgresql.org
Cc: Mats Kindahl <mats@timescale.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAJ7c6TNumEgVKmR%2Bb%3Dr5cfB3pAdxq9eF4%2BB9QbtCri9tzC5T4Q%40mail.gmail.com>
Precedence: bulk

Hi,

> I wanted to hook into the EXPLAIN output for queries and add some extra i=
nformation, but since there is no standard_ExplainOneQuery() I had to copy =
the code and create my own version.
>
> Since the pattern with other hooks for a function WhateverFunction() seem=
s to be that there is a standard_WhateverFunction() for each WhateverFuncti=
on_hook, I created a patch to follow this pattern for your consideration.
>
> I was also considering adding a callback so that you can annotate any nod=
e with explanatory information that is not a custom scan node. This could b=
e used to propagate and summarize information from custom scan nodes, but I=
 had no immediate use for that so did not add it here. I would still be int=
erested in hearing if you think this is something that would be useful to t=
he community.

Thanks for the patch. LGTM.

I registered the patch on the nearest open CF [1] and marked it as
RfC. It is a pretty straightforward refactoring.

[1]: https://commitfest.postgresql.org/48/4879/

--=20
Best regards,
Aleksander Alekseev